David T. Lewis uploaded a new version of KernelTests to project The Trunk:
http://source.squeak.org/trunk/KernelTests-dtl.273.mcz ==================== Summary ==================== Name: KernelTests-dtl.273 Author: dtl Time: 15 July 2014, 7:52:19.461 pm UUID: 31288564-1f42-4fd3-ac23-e15bf1480000 Ancestors: KernelTests-fbs.272 Remove invalid assertions in DateAndTimeTest>>testReadFrom. These had been added to the test in KernelTests-dtl.265 in attempt to restore some missing test assertions from an earlier version of the method. The test assertions pass if and only if time zone has zero offset, so they appear to pass in an image with default UTC time zone. However, they contradict the documented behavior for parsing DateAndTime from a string with time zone offset unspecified. See DateAndTimeTest>>testFromString for coverage of the expected behavior. =============== Diff against KernelTests-fbs.272 =============== Item was changed: ----- Method: DateAndTimeTest>>testReadFrom (in category 'Tests') ----- testReadFrom self assert: '-1199-01-05T20:33:14.321-05:00' equals: (DateAndTime readFrom: '-1199-01-05T20:33:14.321-05:00' readStream) printString. self assert: '-1199-01-05T20:33:14.321-05:00' equals: '-1199-01-05T20:33:14.321-05:00' asDateAndTime printString. self assert: '2002-05-16T17:20:45.1+01:01' equals: '2002-05-16T17:20:45.1+01:01' asDateAndTime printString. self assert: '2002-05-16T17:20:45.02+01:01' equals: ' 2002-05-16T17:20:45.02+01:01' asDateAndTime printString. self assert: '2002-05-16T17:20:45.000000009+01:01' equals: '2002-05-16T17:20:45.000000009+01:01' asDateAndTime printString. - self assert: '2002-05-16T17:20:00+00:00' equals: ' 2002-05-16T17:20' asDateAndTime printString. - self assert: '2002-05-16T17:20:45+00:00' equals: '2002-05-16T17:20:45' asDateAndTime printString. self assert: '2002-05-16T17:20:45+01:57' equals: ' 2002-05-16T17:20:45+01:57' asDateAndTime printString. self assert: '2002-05-16T17:20:45-02:34' equals: ' 2002-05-16T17:20:45-02:34' asDateAndTime printString. self assert: '2002-05-16T17:20:45+00:00' equals: '2002-05-16T17:20:45+00:00' asDateAndTime printString. self assert: '1997-04-26T01:02:03+01:02:3' equals: '1997-04-26T01:02:03+01:02:3' asDateAndTime printString! |
On 16 July 2014 00:52, <[hidden email]> wrote:
> David T. Lewis uploaded a new version of KernelTests to project The Trunk: > http://source.squeak.org/trunk/KernelTests-dtl.273.mcz > > ==================== Summary ==================== > > Name: KernelTests-dtl.273 > Author: dtl > Time: 15 July 2014, 7:52:19.461 pm > UUID: 31288564-1f42-4fd3-ac23-e15bf1480000 > Ancestors: KernelTests-fbs.272 > > Remove invalid assertions in DateAndTimeTest>>testReadFrom. These had been added to the test in KernelTests-dtl.265 in attempt to restore some missing test assertions from an earlier version of the method. > > The test assertions pass if and only if time zone has zero offset, so they appear to pass in an image with default UTC time zone. However, they contradict the documented behavior for parsing DateAndTime from a string with time zone offset unspecified. > > See DateAndTimeTest>>testFromString for coverage of the expected behavior. > frank |
Free forum by Nabble | Edit this page |