The Trunk: KernelTests-klc.163.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: KernelTests-klc.163.mcz

commits-2
Ken Causey uploaded a new version of KernelTests to project The Trunk:
http://source.squeak.org/trunk/KernelTests-klc.163.mcz

==================== Summary ====================

Name: KernelTests-klc.163
Author: klc
Time: 10 September 2010, 5:03:55.522 pm
UUID: dd285f04-4f1e-7e42-8f1f-414b18480296
Ancestors: KernelTests-klc.162

Once more I may be missing something obvious here.  The uncommented assertion was comparing instances of two different classes, I'm pretty sure it was meant to be comparing the increment of an end to the start of the next timespan, which is how I changed it.  Then there was a commented out assertion which I think was missing the #= and once I add it it works fine despite the comment that it wouldn't until some change occurred.  Perhaps this change did?

=============== Diff against KernelTests-klc.161 ===============

Item was changed:
  ----- Method: TimespanTest>>testEnd (in category 'testing') -----
  testEnd
+ self assert: aTimespan end + (Duration  nanoSeconds:1)  =  aDisjointTimespan start.
+ self assert: aTimespan end = (DateAndTime year: 2005 month: 1 day: 7 hour: 23 minute: 59 second: 59 nanoSecond: 999999999 offset: 0 hours)
- self assert: aTimespan end + (Duration  nanoSeconds:1)  =  aDisjointTimespan
- "self assert: aTimespan end (DateAndTime year: 2005 month: 1 day: 7 hour: 23 minute: 59 second: 59 nanoSecond: 999999999 offset: 0 hours). "
- "This should work once DateAndTime >> year:month:day:hour:minute:second:nanoSecond:offset: is fixed"
 
+
  !


Reply | Threaded
Open this post in threaded view
|

RE: The Trunk: KernelTests-klc.163.mcz

Ken Causey-3
Oops.  Forget this one, I've deleted it from the repository.  I first
tried to submit this as a klc.162 but it failed because I hadn't
bothered to fill in my username and password.  Thinking I could just fix
this and give it another go resulted in this version with the
incremented version number as an ancestor of a version that did not
exist in the repository.  Apparently this info is based on what is in
your local package cache not the remote repository to which you are
saving.  Anyway, by the time you see this there should be a proper
klc.162 in the repository.

Ken

> -------- Original Message --------
> Subject: [squeak-dev] The Trunk: KernelTests-klc.163.mcz
> From: [hidden email]
> Date: Fri, September 10, 2010 11:30 am
> To: [hidden email],
> [hidden email]
>
>
> Ken Causey uploaded a new version of KernelTests to project The Trunk:
> http://source.squeak.org/trunk/KernelTests-klc.163.mcz
>
> ==================== Summary ====================
>
> Name: KernelTests-klc.163
> Author: klc
> Time: 10 September 2010, 5:03:55.522 pm
> UUID: dd285f04-4f1e-7e42-8f1f-414b18480296
> Ancestors: KernelTests-klc.162
>
> Once more I may be missing something obvious here.  The uncommented assertion was comparing instances of two different classes, I'm pretty sure it was meant to be comparing the increment of an end to the start of the next timespan, which is how I changed it.  Then there was a commented out assertion which I think was missing the #= and once I add it it works fine despite the comment that it wouldn't until some change occurred.  Perhaps this change did?
>
> =============== Diff against KernelTests-klc.161 ===============
>
> Item was changed:
>   ----- Method: TimespanTest>>testEnd (in category 'testing') -----
>   testEnd
> + self assert: aTimespan end + (Duration  nanoSeconds:1)  =  aDisjointTimespan start.
> + self assert: aTimespan end = (DateAndTime year: 2005 month: 1 day: 7 hour: 23 minute: 59 second: 59 nanoSecond: 999999999 offset: 0 hours)
> - self assert: aTimespan end + (Duration  nanoSeconds:1)  =  aDisjointTimespan
> - "self assert: aTimespan end (DateAndTime year: 2005 month: 1 day: 7 hour: 23 minute: 59 second: 59 nanoSecond: 999999999 offset: 0 hours). "
> - "This should work once DateAndTime >> year:month:day:hour:minute:second:nanoSecond:offset: is fixed"
>  
> +
>   !