The Trunk: KernelTests-nice.103.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: KernelTests-nice.103.mcz

commits-2
Nicolas Cellier uploaded a new version of KernelTests to project The Trunk:
http://source.squeak.org/trunk/KernelTests-nice.103.mcz

==================== Summary ====================

Name: KernelTests-nice.103
Author: nice
Time: 19 October 2009, 9:21:34 am
UUID: e54ca050-d8d0-0a44-b3f2-05e51c074005
Ancestors: KernelTests-nice.102

remove uncessary sends of #values
because (aDictionary values do:) is same as (aDictionary do:)
except when aDictionary is modified in the do loop.

=============== Diff against KernelTests-nice.102 ===============

Item was changed:
  ----- Method: InstVarRefLocatorTest>>testInstructions (in category 'tests') -----
  testInstructions
 
+ | scanner end printer |
- | scanner end printer methods |
-
- methods := Object methodDict values.
 
+ Object methodDict do: [:method |
- methods do: [:method |
  scanner := InstructionStream on: method.
  printer := InstVarRefLocator new.
  end := scanner method endPC.
 
  [scanner pc <= end] whileTrue: [
  self shouldnt: [printer interpretNextInstructionUsing: scanner] raise: Error.
  ].
  ].!

Item was changed:
  ----- Method: InstructionPrinterTest>>testInstructions (in category 'tests') -----
  testInstructions
  "just print all of methods of Object and see if no error accours"
 
+ | printer |
+ printer  := InstructionPrinter.
+ Object methodDict do: [:method |
- | methods printer  |
-
- methods := Object methodDict values.
- printer  := InstructionPrinter.
-
- methods do: [:method |
  self shouldnt: [
  String streamContents: [:stream |
  (printer on: method) printInstructionsOn: stream]] raise: Error.
  ].
  !

Item was changed:
  ----- Method: InstructionClientTest>>testInstructions (in category 'tests') -----
  testInstructions
  "just interpret all of methods of Object"
 
+ | client scanner |
- | methods client scanner|
-
- methods := Object methodDict values.
  client := InstructionClient new.
+ Object methodDict do: [:method |
-
- methods do: [:method |
  scanner := (InstructionStream on: method).
  [scanner pc <= method endPC] whileTrue: [
  self shouldnt: [scanner interpretNextInstructionFor: client] raise: Error.
  ].
  ].
  !