Smalltalk › Squeak › Squeak - Dev

The Trunk: Monticello-bf.523.mcz

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 6 messages Options
commits-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

The Trunk: Monticello-bf.523.mcz

commits-2
Bert Freudenberg uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-bf.523.mcz

==================== Summary ====================

Name: Monticello-bf.523
Author: bf
Time: 7 September 2012, 1:46:20.526 pm
UUID: d75a5c9e-14ea-40dd-baaf-243d2f4fa6c1
Ancestors: Monticello-cmm.522

Sundry improvements:
* trim space for version name when saving
* when browsing a package snapshot, do not show the *Extensions category unless the package actually has extension methods
* mention 'package' in summary line for package load/unload scripts

=============== Diff against Monticello-cmm.522 ===============

Item was changed:
  ----- Method: MCScriptDefinition>>summary (in category 'accessing') -----
  summary
+ ^ packageName, ' package ', self scriptSelector!
- ^ packageName, ' ', self scriptSelector!

Item was added:
+ ----- Method: MCSnapshotBrowser>>hasExtensions (in category 'accessing') -----
+ hasExtensions
+ ^self extensionClassNames notEmpty!

Item was changed:
  ----- Method: MCSnapshotBrowser>>visibleCategories (in category 'listing') -----
  visibleCategories
  ^ ((self packageOrganizations gather: [:ea | ea categories]),
+ (self packageClasses collect: [:ea | ea category]),
+ (self hasExtensions ifTrue: [{self extensionsCategory}] ifFalse: [#()]))
+ asSet asSortedCollection!
- (self packageClasses collect: [:ea | ea category]))
- asSet asSortedCollection add: self extensionsCategory; yourself.!

Item was changed:
  ----- Method: MCWorkingCopy>>newVersion (in category 'operations') -----
  newVersion
  ^ (self requestVersionNameAndMessageWithSuggestion: self uniqueVersionName
  initialMessage: self patchMessageSuggestion) ifNotNil:
  [:pair |
+ self newVersionWithName: pair first withBlanksTrimmed
- self newVersionWithName: pair first
  message: (self patchMessageStripped: pair last)].
  !


Eliot Miranda-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Monticello-bf.523.mcz

Eliot Miranda-2


On Fri, Sep 7, 2012 at 4:46 AM, <[hidden email]> wrote:
Bert Freudenberg uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-bf.523.mcz

==================== Summary ====================

Name: Monticello-bf.523
Author: bf
Time: 7 September 2012, 1:46:20.526 pm
UUID: d75a5c9e-14ea-40dd-baaf-243d2f4fa6c1
Ancestors: Monticello-cmm.522

Sundry improvements:
* trim space for version name when saving
* when browsing a package snapshot, do not show the *Extensions category unless the package actually has extension methods

Thank you!!!!!
 
* mention 'package' in summary line for package load/unload scripts

=============== Diff against Monticello-cmm.522 ===============

Item was changed:
  ----- Method: MCScriptDefinition>>summary (in category 'accessing') -----
  summary
+       ^ packageName, ' package ', self scriptSelector!
-       ^ packageName, ' ', self scriptSelector!

Item was added:
+ ----- Method: MCSnapshotBrowser>>hasExtensions (in category 'accessing') -----
+ hasExtensions
+       ^self extensionClassNames notEmpty!

Item was changed:
  ----- Method: MCSnapshotBrowser>>visibleCategories (in category 'listing') -----
  visibleCategories
        ^ ((self packageOrganizations gather: [:ea | ea categories]),
+               (self packageClasses collect: [:ea | ea category]),
+                       (self hasExtensions ifTrue: [{self extensionsCategory}] ifFalse: [#()]))
+                               asSet asSortedCollection!
-               (self packageClasses collect: [:ea | ea category]))
-                       asSet asSortedCollection add: self extensionsCategory; yourself.!

Item was changed:
  ----- Method: MCWorkingCopy>>newVersion (in category 'operations') -----
  newVersion
        ^ (self requestVersionNameAndMessageWithSuggestion: self uniqueVersionName
                initialMessage: self patchMessageSuggestion) ifNotNil:
                        [:pair |
+                       self newVersionWithName: pair first withBlanksTrimmed
-                       self newVersionWithName: pair first
                                message: (self patchMessageStripped: pair last)].
  !





--
best,
Eliot
Eliot Miranda-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Monticello-bf.523.mcz

Eliot Miranda-2


On Fri, Sep 7, 2012 at 11:08 AM, Eliot Miranda <[hidden email]> wrote:


On Fri, Sep 7, 2012 at 4:46 AM, <[hidden email]> wrote:
Bert Freudenberg uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-bf.523.mcz

==================== Summary ====================

Name: Monticello-bf.523
Author: bf
Time: 7 September 2012, 1:46:20.526 pm
UUID: d75a5c9e-14ea-40dd-baaf-243d2f4fa6c1
Ancestors: Monticello-cmm.522

Sundry improvements:
* trim space for version name when saving
* when browsing a package snapshot, do not show the *Extensions category unless the package actually has extension methods

Thank you!!!!!

any chance of indicating whether there are instance or class side methods too?  I spend an age clicking around a complex package trying to check extensions.

 
* mention 'package' in summary line for package load/unload scripts

=============== Diff against Monticello-cmm.522 ===============

Item was changed:
  ----- Method: MCScriptDefinition>>summary (in category 'accessing') -----
  summary
+       ^ packageName, ' package ', self scriptSelector!
-       ^ packageName, ' ', self scriptSelector!

Item was added:
+ ----- Method: MCSnapshotBrowser>>hasExtensions (in category 'accessing') -----
+ hasExtensions
+       ^self extensionClassNames notEmpty!

Item was changed:
  ----- Method: MCSnapshotBrowser>>visibleCategories (in category 'listing') -----
  visibleCategories
        ^ ((self packageOrganizations gather: [:ea | ea categories]),
+               (self packageClasses collect: [:ea | ea category]),
+                       (self hasExtensions ifTrue: [{self extensionsCategory}] ifFalse: [#()]))
+                               asSet asSortedCollection!
-               (self packageClasses collect: [:ea | ea category]))
-                       asSet asSortedCollection add: self extensionsCategory; yourself.!

Item was changed:
  ----- Method: MCWorkingCopy>>newVersion (in category 'operations') -----
  newVersion
        ^ (self requestVersionNameAndMessageWithSuggestion: self uniqueVersionName
                initialMessage: self patchMessageSuggestion) ifNotNil:
                        [:pair |
+                       self newVersionWithName: pair first withBlanksTrimmed
-                       self newVersionWithName: pair first
                                message: (self patchMessageStripped: pair last)].
  !





--
best,
Eliot




--
best,
Eliot
Bert Freudenberg
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Monticello-bf.523.mcz

Bert Freudenberg
On 2012-09-07, at 20:09, Eliot Miranda <[hidden email]> wrote:

On Fri, Sep 7, 2012 at 11:08 AM, Eliot Miranda <[hidden email]> wrote:

On Fri, Sep 7, 2012 at 4:46 AM, <[hidden email]> wrote:
when browsing a package snapshot, do not show the *Extensions category unless the package actually has extension methods

Thank you!!!!!

any chance of indicating whether there are instance or class side methods too?  I spend an age clicking around a complex package trying to check extensions.

Me too. Which of these is better? Or another UI idea?

 

- Bert -
Chris Muller-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Monticello-bf.523.mcz

Chris Muller-3
How about

    ChangeList
    ChangeList class

?


On Sun, Sep 9, 2012 at 7:44 AM, Bert Freudenberg <[hidden email]> wrote:
On 2012-09-07, at 20:09, Eliot Miranda <[hidden email]> wrote:

On Fri, Sep 7, 2012 at 11:08 AM, Eliot Miranda <[hidden email]> wrote:

On Fri, Sep 7, 2012 at 4:46 AM, <[hidden email]> wrote:
when browsing a package snapshot, do not show the *Extensions category unless the package actually has extension methods

Thank you!!!!!

any chance of indicating whether there are instance or class side methods too?  I spend an age clicking around a complex package trying to check extensions.

Me too. Which of these is better? Or another UI idea?

 

- Bert -
Bert Freudenberg
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Monticello-bf.523.mcz

Bert Freudenberg

On 2012-09-09, at 16:33, Chris Muller <[hidden email]> wrote:

> How about
>
>     ChangeList
>     ChangeList class
>
> ?

That would be nicer, agreed. But the logic of snapshot browser's class list would have to change quite a bit. More than I want to do now.

So I committed mine (Monticello-bf.525) which adds simple labels, and leave improving on this to others :)

- Bert -


> On Sun, Sep 9, 2012 at 7:44 AM, Bert Freudenberg <[hidden email]> wrote:
> On 2012-09-07, at 20:09, Eliot Miranda <[hidden email]> wrote:
>
>> On Fri, Sep 7, 2012 at 11:08 AM, Eliot Miranda <[hidden email]> wrote:
>>>
>>> On Fri, Sep 7, 2012 at 4:46 AM, <[hidden email]> wrote:
>>>> when browsing a package snapshot, do not show the *Extensions category unless the package actually has extension methods
>>>
>>> Thank you!!!!!
>>>
>> any chance of indicating whether there are instance or class side methods too?  I spend an age clicking around a complex package trying to check extensions.
>
> Me too. Which of these is better? Or another UI idea?
>
> <PastedGraphic-6.png> <PastedGraphic-7.png>
>
> - Bert -


Free forum by Nabble Edit this page