The Trunk: Monticello-cmm.558.mcz
Locked
 
|
Chris Muller uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-cmm.558.mcz ==================== Summary ==================== Name: Monticello-cmm.558 Author: cmm Time: 15 August 2013, 11:55:22.698 am UUID: 90d5e73c-dd83-4b82-82c0-7c1a48814f51 Ancestors: Monticello-cmm.557 - If an older version is not found in the repository it should be in, copy it where it should from the MCRepositoryGroup default. If it's not found there, signal an error that it needs to be copied there. =============== Diff against Monticello-cmm.557 =============== Item was changed: ----- Method: MCInfoProxy>>materializeInfo (in category 'private') ----- materializeInfo + ^ (repository versionWithInfo: info) + ifNil: + [ (MCRepositoryGroup default versionWithInfo: info) + ifNil: [ nil error: 'Please copy ' , info name , 'with id ' , info id asString , ' to ' , repository asString , ' and try again.' ] + ifNotNil: + [ : foundVersion | repository storeVersion: foundVersion ] ] + ifNotNil: [ : version | version info ]! - ^ (repository versionWithInfo: info) info! |
Re: The Trunk: Monticello-cmm.558.mcz
|
|
On 2013-08-15, at 16:55, [hidden email] wrote:
> Chris Muller uploaded a new version of Monticello to project The Trunk: > http://source.squeak.org/trunk/Monticello-cmm.558.mcz > > ==================== Summary ==================== > > Name: Monticello-cmm.558 > Author: cmm > Time: 15 August 2013, 11:55:22.698 am > UUID: 90d5e73c-dd83-4b82-82c0-7c1a48814f51 > Ancestors: Monticello-cmm.557 > > - If an older version is not found in the repository it should be in, copy it where it should from the MCRepositoryGroup default. If it's not found there, signal an error that it needs to be copied there. I don't think just browsing something should cause a commit to an arbitrary repository. It's much more likely that a child of this info is in a repository (or even in the image) that has the full ancestry data. You don't need to load that specific version, any descendant will do. The most recent would be the best bet, I'd think. - Bert - |
Re: The Trunk: Monticello-cmm.558.mcz
|
|
>> ==================== Summary ====================
>> >> Name: Monticello-cmm.558 >> Author: cmm >> Time: 15 August 2013, 11:55:22.698 am >> UUID: 90d5e73c-dd83-4b82-82c0-7c1a48814f51 >> Ancestors: Monticello-cmm.557 >> >> - If an older version is not found in the repository it should be in, copy it where it should from the MCRepositoryGroup default. If it's not found there, signal an error that it needs to be copied there. > > > I don't think just browsing something should cause a commit to an arbitrary repository. That's fair. > It's much more likely that a child of this info is in a repository (or even in the image) that has the full ancestry data. You don't need to load that specific version, any descendant will do. The most recent would be the best bet, I'd think. That's an excellent point! In fact, we should be able to go after the repository for the child-most version that's actually loaded. I'll do that. Thanks. |
Re: The Trunk: Monticello-cmm.558.mcz
|
|
In reply to this post by Bert Freudenberg
I thought you were implicitly expressing conditional approval by this
suggestion.. On Thu, Aug 15, 2013 at 2:07 PM, Bert Freudenberg <[hidden email]> wrote: > On 2013-08-15, at 16:55, [hidden email] wrote: > >> Chris Muller uploaded a new version of Monticello to project The Trunk: >> http://source.squeak.org/trunk/Monticello-cmm.558.mcz >> >> ==================== Summary ==================== >> >> Name: Monticello-cmm.558 >> Author: cmm >> Time: 15 August 2013, 11:55:22.698 am >> UUID: 90d5e73c-dd83-4b82-82c0-7c1a48814f51 >> Ancestors: Monticello-cmm.557 >> >> - If an older version is not found in the repository it should be in, copy it where it should from the MCRepositoryGroup default. If it's not found there, signal an error that it needs to be copied there. > > > I don't think just browsing something should cause a commit to an arbitrary repository. > > It's much more likely that a child of this info is in a repository (or even in the image) that has the full ancestry data. You don't need to load that specific version, any descendant will do. The most recent would be the best bet, I'd think. > > - Bert - > > |
Re: The Trunk: Monticello-cmm.558.mcz
|
|
On 2013-08-16, at 17:16, Chris Muller <[hidden email]> wrote:
> I thought you were implicitly expressing conditional approval by this > suggestion.. Didn't mean to imply that. I just want to argue against the best possible case you could have made, not getting hung up on minor flaws. ;) Besides, we may end up using this after all, so far I am alone in speaking out against the idea. - Bert - > > On Thu, Aug 15, 2013 at 2:07 PM, Bert Freudenberg <[hidden email]> wrote: >> On 2013-08-15, at 16:55, [hidden email] wrote: >> >>> Chris Muller uploaded a new version of Monticello to project The Trunk: >>> http://source.squeak.org/trunk/Monticello-cmm.558.mcz >>> >>> ==================== Summary ==================== >>> >>> Name: Monticello-cmm.558 >>> Author: cmm >>> Time: 15 August 2013, 11:55:22.698 am >>> UUID: 90d5e73c-dd83-4b82-82c0-7c1a48814f51 >>> Ancestors: Monticello-cmm.557 >>> >>> - If an older version is not found in the repository it should be in, copy it where it should from the MCRepositoryGroup default. If it's not found there, signal an error that it needs to be copied there. >> >> >> I don't think just browsing something should cause a commit to an arbitrary repository. >> >> It's much more likely that a child of this info is in a repository (or even in the image) that has the full ancestry data. You don't need to load that specific version, any descendant will do. The most recent would be the best bet, I'd think. >> >> - Bert - >> >> |
|
|
So, I for one do not like the 'automatic copy' idea at all. In fact, I'd need to disable it in any image that I ran. Reason: some of the coding that I do gets done at my business, and occassionally a method will be placed in the wrong package and committed (locally). Once I find that and remove it, I may then publish the newly cleaned package out. If I had to worry about the image automatically pushing out an version that should not be released (due to possibly exposing code that shouldn't be), then I couldn't really afford to use it.
I may be the only one with this worry. In any case, I like to know and have control over exactly what I release out in the wild. -Chris On Fri, Aug 16, 2013 at 8:46 AM, Bert Freudenberg <[hidden email]> wrote:
|
Re: The Trunk: Monticello-cmm.558.mcz
|
|
The auto-copy was removed at Berts behest.
Versioning is not "releasing". If you're deleting mcz files but not fixing your ancestry, MC will produce debuggers simply by invoking SCM operations from the menu on those versions in the ancestry list.. That's all what this feature was trying to minimize. But don't worry, it's gone now. On Tue, Aug 20, 2013 at 3:06 PM, Chris Cunningham <[hidden email]> wrote: > So, I for one do not like the 'automatic copy' idea at all. In fact, I'd > need to disable it in any image that I ran. > > Reason: some of the coding that I do gets done at my business, and > occassionally a method will be placed in the wrong package and committed > (locally). Once I find that and remove it, I may then publish the newly > cleaned package out. If I had to worry about the image automatically > pushing out an version that should not be released (due to possibly exposing > code that shouldn't be), then I couldn't really afford to use it. > > I may be the only one with this worry. In any case, I like to know and have > control over exactly what I release out in the wild. > > -Chris > > > On Fri, Aug 16, 2013 at 8:46 AM, Bert Freudenberg <[hidden email]> > wrote: >> >> On 2013-08-16, at 17:16, Chris Muller <[hidden email]> wrote: >> >> > I thought you were implicitly expressing conditional approval by this >> > suggestion.. >> >> Didn't mean to imply that. I just want to argue against the best possible >> case you could have made, not getting hung up on minor flaws. ;) >> >> Besides, we may end up using this after all, so far I am alone in speaking >> out against the idea. >> >> - Bert - >> >> >> >> > >> > On Thu, Aug 15, 2013 at 2:07 PM, Bert Freudenberg <[hidden email]> >> > wrote: >> >> On 2013-08-15, at 16:55, [hidden email] wrote: >> >> >> >>> Chris Muller uploaded a new version of Monticello to project The >> >>> Trunk: >> >>> http://source.squeak.org/trunk/Monticello-cmm.558.mcz >> >>> >> >>> ==================== Summary ==================== >> >>> >> >>> Name: Monticello-cmm.558 >> >>> Author: cmm >> >>> Time: 15 August 2013, 11:55:22.698 am >> >>> UUID: 90d5e73c-dd83-4b82-82c0-7c1a48814f51 >> >>> Ancestors: Monticello-cmm.557 >> >>> >> >>> - If an older version is not found in the repository it should be in, >> >>> copy it where it should from the MCRepositoryGroup default. If it's not >> >>> found there, signal an error that it needs to be copied there. >> >> >> >> >> >> I don't think just browsing something should cause a commit to an >> >> arbitrary repository. >> >> >> >> It's much more likely that a child of this info is in a repository (or >> >> even in the image) that has the full ancestry data. You don't need to load >> >> that specific version, any descendant will do. The most recent would be the >> >> best bet, I'd think. >> >> >> >> - Bert - >> >> >> >> >> >> > > > > |
Re: The Trunk: Monticello-cmm.558.mcz
|
|
In reply to this post by cbc
Also, there's nothing to "disable". If you don't want to trim
ancestry from memory then... simply don't select it from the repository menu. On Tue, Aug 20, 2013 at 3:06 PM, Chris Cunningham <[hidden email]> wrote: > So, I for one do not like the 'automatic copy' idea at all. In fact, I'd > need to disable it in any image that I ran. > > Reason: some of the coding that I do gets done at my business, and > occassionally a method will be placed in the wrong package and committed > (locally). Once I find that and remove it, I may then publish the newly > cleaned package out. If I had to worry about the image automatically > pushing out an version that should not be released (due to possibly exposing > code that shouldn't be), then I couldn't really afford to use it. > > I may be the only one with this worry. In any case, I like to know and have > control over exactly what I release out in the wild. > > -Chris > > > On Fri, Aug 16, 2013 at 8:46 AM, Bert Freudenberg <[hidden email]> > wrote: >> >> On 2013-08-16, at 17:16, Chris Muller <[hidden email]> wrote: >> >> > I thought you were implicitly expressing conditional approval by this >> > suggestion.. >> >> Didn't mean to imply that. I just want to argue against the best possible >> case you could have made, not getting hung up on minor flaws. ;) >> >> Besides, we may end up using this after all, so far I am alone in speaking >> out against the idea. >> >> - Bert - >> >> >> >> > >> > On Thu, Aug 15, 2013 at 2:07 PM, Bert Freudenberg <[hidden email]> >> > wrote: >> >> On 2013-08-15, at 16:55, [hidden email] wrote: >> >> >> >>> Chris Muller uploaded a new version of Monticello to project The >> >>> Trunk: >> >>> http://source.squeak.org/trunk/Monticello-cmm.558.mcz >> >>> >> >>> ==================== Summary ==================== >> >>> >> >>> Name: Monticello-cmm.558 >> >>> Author: cmm >> >>> Time: 15 August 2013, 11:55:22.698 am >> >>> UUID: 90d5e73c-dd83-4b82-82c0-7c1a48814f51 >> >>> Ancestors: Monticello-cmm.557 >> >>> >> >>> - If an older version is not found in the repository it should be in, >> >>> copy it where it should from the MCRepositoryGroup default. If it's not >> >>> found there, signal an error that it needs to be copied there. >> >> >> >> >> >> I don't think just browsing something should cause a commit to an >> >> arbitrary repository. >> >> >> >> It's much more likely that a child of this info is in a repository (or >> >> even in the image) that has the full ancestry data. You don't need to load >> >> that specific version, any descendant will do. The most recent would be the >> >> best bet, I'd think. >> >> >> >> - Bert - >> >> >> >> >> >> > > > > |
«
Return to Squeak - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |