The Trunk: Monticello-cmm.652.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Monticello-cmm.652.mcz

commits-2
Chris Muller uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-cmm.652.mcz

==================== Summary ====================

Name: Monticello-cmm.652
Author: cmm
Time: 7 November 2016, 4:31:31.976467 pm
UUID: 299e8bdb-d834-4875-9d5f-27e4c4fcbed8
Ancestors: Monticello-cmm.651

- For Monticello class and method edition history, adopt the nomenclature of "editions" rather than "history", since it may be used to look at alternative editions in any repository, not just the trunk.
- Sort nil class categories to the end rather than blow up the IDE (MCSnapshotBrowser).

=============== Diff against Monticello-cmm.651 ===============

Item was changed:
  ----- Method: MCOperationsBrowser>>defaultLabel (in category 'ui') -----
  defaultLabel
+ ^ label ifNil: [ 'Editions Browser' ]!
- ^ label ifNil: [ 'History Browser' ]!

Item was changed:
  ----- Method: MCRepository class>>browseMcClassHistoryService (in category 'ui-support') -----
  browseMcClassHistoryService
  ^ ServiceAction
  id: #browseMcClassHistory
+ text: 'browse repository editions'
- text: 'browse mc history'
  button: 'mc'
+ description: 'Browse editions of this class definition from the first-listed HTTP repository of this package.'
- description: 'Browse the Monticello history of this class from the historical code repository.'
  action:
  [ : aBrowserRequestor | aBrowserRequestor browseMcClassHistory ]
  condition:
  [ : aBrowserRequestor | true ]!

Item was changed:
  ----- Method: MCRepository class>>browseMcMethodHistoryService (in category 'ui-support') -----
  browseMcMethodHistoryService
  ^ ServiceAction
  id: #browseMcMethodHistory
+ text: 'browse repository editions'
- text: 'browse mc history'
  button: 'mc'
+ description: 'Browse editions of this method from the first-listed HTTP repository of this package.'
- description: 'Browse the Monticello history of this method from the historical code repository.'
  action:
  [ : aBrowserRequestor | aBrowserRequestor browseMcMethodHistory ]
  condition:
  [ : aBrowserRequestor | true ]!

Item was changed:
  ----- Method: MCSnapshotBrowser>>visibleCategories (in category 'listing') -----
  visibleCategories
+ ^ ((self packageOrganizations gather: [:ea | ea categories])
+ , (self packageClasses collect: [:ea | ea category])
+ , (self hasExtensions
+ ifTrue: [{self extensionsCategory}]
+ ifFalse: [Array empty])) asSet asSortedCollection: [:each | each ifNil: ['~(put nils to the end)']] ascending!
- ^ ((self packageOrganizations gather: [:ea | ea categories]),
- (self packageClasses collect: [:ea | ea category]),
- (self hasExtensions ifTrue: [{self extensionsCategory}] ifFalse: [#()]))
- asSet asSortedCollection!

Item was changed:
  ----- Method: MCWorkingCopyBrowser>>repositoryListMenu: (in category 'morphic ui') -----
  repositoryListMenu: aMenu
  "first add repository-specific commands"
  self repository ifNotNil:
  [ self
  fillMenu: aMenu
  fromSpecs:
  #(('open repository' #openRepository)
  ('edit repository info' #editRepository)
  ('add to package...' #addRepositoryToPackage)
  ('remove repository' #removeRepository)
+ ('demote to bottom' #demoteRepository)
- ('move to bottom' #demoteRepository)
  ('copy image versions here' #copyImageVersions)).
  aMenu
  add:
  (self repository alwaysStoreDiffs
  ifTrue: ['store full versions']
  ifFalse: ['store diffs'])
  target: self
  selector: #toggleDiffs ;
  addLine ].
  "then the non-specific commands"
  ^self fillMenu: aMenu fromSpecs:
  #( ('load repositories' #loadRepositories)
  ('save repositories' #saveRepositories)
  ('flush cached versions' #flushCachedVersions)
  ('flush cached versions and ancestry' #flushCachedVersionsAncestry))!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Monticello-cmm.652.mcz

Tobias Pape

On 07.11.2016, at 23:31, [hidden email] wrote:

> Chris Muller uploaded a new version of Monticello to project The Trunk:
> http://source.squeak.org/trunk/Monticello-cmm.652.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-cmm.652
> Author: cmm
> Time: 7 November 2016, 4:31:31.976467 pm
> UUID: 299e8bdb-d834-4875-9d5f-27e4c4fcbed8
> Ancestors: Monticello-cmm.651
>
> - For Monticello class and method edition history, adopt the nomenclature of "editions" rather than "history", since it may be used to look at alternative editions in any repository, not just the trunk.

Where does this nomenclature come from?

> - Sort nil class categories to the end rather than blow up the IDE (MCSnapshotBrowser).
>
> =============== Diff against Monticello-cmm.651 ===============
>
> Item was changed:
>  ----- Method: MCOperationsBrowser>>defaultLabel (in category 'ui') -----
>  defaultLabel
> + ^ label ifNil: [ 'Editions Browser' ]!
> - ^ label ifNil: [ 'History Browser' ]!
>
> Item was changed:
>  ----- Method: MCRepository class>>browseMcClassHistoryService (in category 'ui-support') -----
>  browseMcClassHistoryService
>   ^ ServiceAction
>   id: #browseMcClassHistory
> + text: 'browse repository editions'
> - text: 'browse mc history'
>   button: 'mc'
> + description: 'Browse editions of this class definition from the first-listed HTTP repository of this package.'
> - description: 'Browse the Monticello history of this class from the historical code repository.'
>   action:
>   [ : aBrowserRequestor | aBrowserRequestor browseMcClassHistory ]
>   condition:
>   [ : aBrowserRequestor | true ]!
>
> Item was changed:
>  ----- Method: MCRepository class>>browseMcMethodHistoryService (in category 'ui-support') -----
>  browseMcMethodHistoryService
>   ^ ServiceAction
>   id: #browseMcMethodHistory
> + text: 'browse repository editions'
> - text: 'browse mc history'
>   button: 'mc'
> + description: 'Browse editions of this method from the first-listed HTTP repository of this package.'
> - description: 'Browse the Monticello history of this method from the historical code repository.'
>   action:
>   [ : aBrowserRequestor | aBrowserRequestor browseMcMethodHistory ]
>   condition:
>   [ : aBrowserRequestor | true ]!
>
> Item was changed:
>  ----- Method: MCSnapshotBrowser>>visibleCategories (in category 'listing') -----
>  visibleCategories
> + ^ ((self packageOrganizations gather: [:ea | ea categories])
> + , (self packageClasses collect: [:ea | ea category])
> + , (self hasExtensions
> + ifTrue: [{self extensionsCategory}]
> + ifFalse: [Array empty])) asSet asSortedCollection: [:each | each ifNil: ['~(put nils to the end)']] ascending!
> - ^ ((self packageOrganizations gather: [:ea | ea categories]),
> - (self packageClasses collect: [:ea | ea category]),
> - (self hasExtensions ifTrue: [{self extensionsCategory}] ifFalse: [#()]))
> - asSet asSortedCollection!
>
> Item was changed:
>  ----- Method: MCWorkingCopyBrowser>>repositoryListMenu: (in category 'morphic ui') -----
>  repositoryListMenu: aMenu
>   "first add repository-specific commands"
>   self repository ifNotNil:
>   [ self
>   fillMenu: aMenu
>   fromSpecs:
>   #(('open repository' #openRepository)
>   ('edit repository info' #editRepository)
>   ('add to package...' #addRepositoryToPackage)
>   ('remove repository' #removeRepository)
> + ('demote to bottom' #demoteRepository)
> - ('move to bottom' #demoteRepository)
>   ('copy image versions here' #copyImageVersions)).
>   aMenu
>   add:
>   (self repository alwaysStoreDiffs
>   ifTrue: ['store full versions']
>   ifFalse: ['store diffs'])
>   target: self
>   selector: #toggleDiffs ;
>   addLine ].
>   "then the non-specific commands"
>   ^self fillMenu: aMenu fromSpecs:
>   #( ('load repositories' #loadRepositories)
>   ('save repositories' #saveRepositories)
>   ('flush cached versions' #flushCachedVersions)
>   ('flush cached versions and ancestry' #flushCachedVersionsAncestry))!
>
>


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Monticello-cmm.652.mcz

Chris Muller-3
English.  Although, yes, I did consider it because it was the
nomenclature chosen for ENVY too.

On Mon, Nov 7, 2016 at 4:34 PM, Tobias Pape <[hidden email]> wrote:

>
> On 07.11.2016, at 23:31, [hidden email] wrote:
>
>> Chris Muller uploaded a new version of Monticello to project The Trunk:
>> http://source.squeak.org/trunk/Monticello-cmm.652.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Monticello-cmm.652
>> Author: cmm
>> Time: 7 November 2016, 4:31:31.976467 pm
>> UUID: 299e8bdb-d834-4875-9d5f-27e4c4fcbed8
>> Ancestors: Monticello-cmm.651
>>
>> - For Monticello class and method edition history, adopt the nomenclature of "editions" rather than "history", since it may be used to look at alternative editions in any repository, not just the trunk.
>
> Where does this nomenclature come from?
>
>> - Sort nil class categories to the end rather than blow up the IDE (MCSnapshotBrowser).
>>
>> =============== Diff against Monticello-cmm.651 ===============
>>
>> Item was changed:
>>  ----- Method: MCOperationsBrowser>>defaultLabel (in category 'ui') -----
>>  defaultLabel
>> +     ^ label ifNil: [ 'Editions Browser' ]!
>> -     ^ label ifNil: [ 'History Browser' ]!
>>
>> Item was changed:
>>  ----- Method: MCRepository class>>browseMcClassHistoryService (in category 'ui-support') -----
>>  browseMcClassHistoryService
>>       ^ ServiceAction
>>               id: #browseMcClassHistory
>> +             text: 'browse repository editions'
>> -             text: 'browse mc history'
>>               button: 'mc'
>> +             description: 'Browse editions of this class definition from the first-listed HTTP repository of this package.'
>> -             description: 'Browse the Monticello history of this class from the historical code repository.'
>>               action:
>>                       [ : aBrowserRequestor | aBrowserRequestor browseMcClassHistory ]
>>               condition:
>>                       [ : aBrowserRequestor | true ]!
>>
>> Item was changed:
>>  ----- Method: MCRepository class>>browseMcMethodHistoryService (in category 'ui-support') -----
>>  browseMcMethodHistoryService
>>       ^ ServiceAction
>>               id: #browseMcMethodHistory
>> +             text: 'browse repository editions'
>> -             text: 'browse mc history'
>>               button: 'mc'
>> +             description: 'Browse editions of this method from the first-listed HTTP repository of this package.'
>> -             description: 'Browse the Monticello history of this method from the historical code repository.'
>>               action:
>>                       [ : aBrowserRequestor | aBrowserRequestor browseMcMethodHistory ]
>>               condition:
>>                       [ : aBrowserRequestor | true ]!
>>
>> Item was changed:
>>  ----- Method: MCSnapshotBrowser>>visibleCategories (in category 'listing') -----
>>  visibleCategories
>> +     ^ ((self packageOrganizations gather: [:ea | ea categories])
>> +             , (self packageClasses collect: [:ea | ea category])
>> +             , (self hasExtensions
>> +                     ifTrue: [{self extensionsCategory}]
>> +                     ifFalse: [Array empty])) asSet asSortedCollection: [:each | each ifNil: ['~(put nils to the end)']] ascending!
>> -     ^ ((self packageOrganizations gather: [:ea | ea categories]),
>> -             (self packageClasses collect: [:ea | ea category]),
>> -                     (self hasExtensions ifTrue: [{self extensionsCategory}] ifFalse: [#()]))
>> -                             asSet asSortedCollection!
>>
>> Item was changed:
>>  ----- Method: MCWorkingCopyBrowser>>repositoryListMenu: (in category 'morphic ui') -----
>>  repositoryListMenu: aMenu
>>       "first add repository-specific commands"
>>       self repository ifNotNil:
>>               [ self
>>                       fillMenu: aMenu
>>                       fromSpecs:
>>                               #(('open repository' #openRepository)
>>                               ('edit repository info' #editRepository)
>>                               ('add to package...' #addRepositoryToPackage)
>>                               ('remove repository' #removeRepository)
>> +                             ('demote to bottom' #demoteRepository)
>> -                             ('move to bottom' #demoteRepository)
>>                               ('copy image versions here' #copyImageVersions)).
>>               aMenu
>>                       add:
>>                               (self repository alwaysStoreDiffs
>>                                       ifTrue: ['store full versions']
>>                                       ifFalse: ['store diffs'])
>>                               target: self
>>                               selector: #toggleDiffs ;
>>                       addLine ].
>>       "then the non-specific commands"
>>       ^self fillMenu: aMenu fromSpecs:
>>               #(      ('load repositories' #loadRepositories)
>>                       ('save repositories' #saveRepositories)
>>                       ('flush cached versions' #flushCachedVersions)
>>                       ('flush cached versions and ancestry' #flushCachedVersionsAncestry))!
>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Monticello-cmm.652.mcz

Tobias Pape

On 07.11.2016, at 23:40, Chris Muller <[hidden email]> wrote:

> English.  Although, yes, I did consider it because it was the
> nomenclature chosen for ENVY too.

Just askin, as I never heard of 'editions' in the context of Monticello,
and finding it in a trunk commit was surprising

>
> On Mon, Nov 7, 2016 at 4:34 PM, Tobias Pape <[hidden email]> wrote:
>>
>> On 07.11.2016, at 23:31, [hidden email] wrote:
>>
>>> Chris Muller uploaded a new version of Monticello to project The Trunk:
>>> http://source.squeak.org/trunk/Monticello-cmm.652.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Monticello-cmm.652
>>> Author: cmm
>>> Time: 7 November 2016, 4:31:31.976467 pm
>>> UUID: 299e8bdb-d834-4875-9d5f-27e4c4fcbed8
>>> Ancestors: Monticello-cmm.651
>>>
>>> - For Monticello class and method edition history, adopt the nomenclature of "editions" rather than "history", since it may be used to look at alternative editions in any repository, not just the trunk.
>>
>> Where does this nomenclature come from?
>>
>>> - Sort nil class categories to the end rather than blow up the IDE (MCSnapshotBrowser).
>>>
>>> =============== Diff against Monticello-cmm.651 ===============
>>>
>>> Item was changed:
>>> ----- Method: MCOperationsBrowser>>defaultLabel (in category 'ui') -----
>>> defaultLabel
>>> +     ^ label ifNil: [ 'Editions Browser' ]!
>>> -     ^ label ifNil: [ 'History Browser' ]!
>>>
>>> Item was changed:
>>> ----- Method: MCRepository class>>browseMcClassHistoryService (in category 'ui-support') -----
>>> browseMcClassHistoryService
>>>      ^ ServiceAction
>>>              id: #browseMcClassHistory
>>> +             text: 'browse repository editions'
>>> -             text: 'browse mc history'
>>>              button: 'mc'
>>> +             description: 'Browse editions of this class definition from the first-listed HTTP repository of this package.'
>>> -             description: 'Browse the Monticello history of this class from the historical code repository.'
>>>              action:
>>>                      [ : aBrowserRequestor | aBrowserRequestor browseMcClassHistory ]
>>>              condition:
>>>                      [ : aBrowserRequestor | true ]!
>>>
>>> Item was changed:
>>> ----- Method: MCRepository class>>browseMcMethodHistoryService (in category 'ui-support') -----
>>> browseMcMethodHistoryService
>>>      ^ ServiceAction
>>>              id: #browseMcMethodHistory
>>> +             text: 'browse repository editions'
>>> -             text: 'browse mc history'
>>>              button: 'mc'
>>> +             description: 'Browse editions of this method from the first-listed HTTP repository of this package.'
>>> -             description: 'Browse the Monticello history of this method from the historical code repository.'
>>>              action:
>>>                      [ : aBrowserRequestor | aBrowserRequestor browseMcMethodHistory ]
>>>              condition:
>>>                      [ : aBrowserRequestor | true ]!
>>>
>>> Item was changed:
>>> ----- Method: MCSnapshotBrowser>>visibleCategories (in category 'listing') -----
>>> visibleCategories
>>> +     ^ ((self packageOrganizations gather: [:ea | ea categories])
>>> +             , (self packageClasses collect: [:ea | ea category])
>>> +             , (self hasExtensions
>>> +                     ifTrue: [{self extensionsCategory}]
>>> +                     ifFalse: [Array empty])) asSet asSortedCollection: [:each | each ifNil: ['~(put nils to the end)']] ascending!
>>> -     ^ ((self packageOrganizations gather: [:ea | ea categories]),
>>> -             (self packageClasses collect: [:ea | ea category]),
>>> -                     (self hasExtensions ifTrue: [{self extensionsCategory}] ifFalse: [#()]))
>>> -                             asSet asSortedCollection!
>>>
>>> Item was changed:
>>> ----- Method: MCWorkingCopyBrowser>>repositoryListMenu: (in category 'morphic ui') -----
>>> repositoryListMenu: aMenu
>>>      "first add repository-specific commands"
>>>      self repository ifNotNil:
>>>              [ self
>>>                      fillMenu: aMenu
>>>                      fromSpecs:
>>>                              #(('open repository' #openRepository)
>>>                              ('edit repository info' #editRepository)
>>>                              ('add to package...' #addRepositoryToPackage)
>>>                              ('remove repository' #removeRepository)
>>> +                             ('demote to bottom' #demoteRepository)
>>> -                             ('move to bottom' #demoteRepository)
>>>                              ('copy image versions here' #copyImageVersions)).
>>>              aMenu
>>>                      add:
>>>                              (self repository alwaysStoreDiffs
>>>                                      ifTrue: ['store full versions']
>>>                                      ifFalse: ['store diffs'])
>>>                              target: self
>>>                              selector: #toggleDiffs ;
>>>                      addLine ].
>>>      "then the non-specific commands"
>>>      ^self fillMenu: aMenu fromSpecs:
>>>              #(      ('load repositories' #loadRepositories)
>>>                      ('save repositories' #saveRepositories)
>>>                      ('flush cached versions' #flushCachedVersions)
>>>                      ('flush cached versions and ancestry' #flushCachedVersionsAncestry))!
>>>
>>>
>>
>>
>


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Monticello-cmm.652.mcz

Nicolas Cellier
Hi Chris,
so you mean that we now browse all editions, including those which are not in current MC version ancestors:
- those in concurrent branches
- those in other packages (if the method was moved from one package to another)


2016-11-07 23:45 GMT+01:00 Tobias Pape <[hidden email]>:

On 07.11.2016, at 23:40, Chris Muller <[hidden email]> wrote:

> English.  Although, yes, I did consider it because it was the
> nomenclature chosen for ENVY too.
 
Just askin, as I never heard of 'editions' in the context of Monticello,
and finding it in a trunk commit was surprising

>
> On Mon, Nov 7, 2016 at 4:34 PM, Tobias Pape <[hidden email]> wrote:
>>
>> On 07.11.2016, at 23:31, [hidden email] wrote:
>>
>>> Chris Muller uploaded a new version of Monticello to project The Trunk:
>>> http://source.squeak.org/trunk/Monticello-cmm.652.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Monticello-cmm.652
>>> Author: cmm
>>> Time: 7 November 2016, 4:31:31.976467 pm
>>> UUID: 299e8bdb-d834-4875-9d5f-27e4c4fcbed8
>>> Ancestors: Monticello-cmm.651
>>>
>>> - For Monticello class and method edition history, adopt the nomenclature of "editions" rather than "history", since it may be used to look at alternative editions in any repository, not just the trunk.
>>
>> Where does this nomenclature come from?
>>
>>> - Sort nil class categories to the end rather than blow up the IDE (MCSnapshotBrowser).
>>>
>>> =============== Diff against Monticello-cmm.651 ===============
>>>
>>> Item was changed:
>>> ----- Method: MCOperationsBrowser>>defaultLabel (in category 'ui') -----
>>> defaultLabel
>>> +     ^ label ifNil: [ 'Editions Browser' ]!
>>> -     ^ label ifNil: [ 'History Browser' ]!
>>>
>>> Item was changed:
>>> ----- Method: MCRepository class>>browseMcClassHistoryService (in category 'ui-support') -----
>>> browseMcClassHistoryService
>>>      ^ ServiceAction
>>>              id: #browseMcClassHistory
>>> +             text: 'browse repository editions'
>>> -             text: 'browse mc history'
>>>              button: 'mc'
>>> +             description: 'Browse editions of this class definition from the first-listed HTTP repository of this package.'
>>> -             description: 'Browse the Monticello history of this class from the historical code repository.'
>>>              action:
>>>                      [ : aBrowserRequestor | aBrowserRequestor browseMcClassHistory ]
>>>              condition:
>>>                      [ : aBrowserRequestor | true ]!
>>>
>>> Item was changed:
>>> ----- Method: MCRepository class>>browseMcMethodHistoryService (in category 'ui-support') -----
>>> browseMcMethodHistoryService
>>>      ^ ServiceAction
>>>              id: #browseMcMethodHistory
>>> +             text: 'browse repository editions'
>>> -             text: 'browse mc history'
>>>              button: 'mc'
>>> +             description: 'Browse editions of this method from the first-listed HTTP repository of this package.'
>>> -             description: 'Browse the Monticello history of this method from the historical code repository.'
>>>              action:
>>>                      [ : aBrowserRequestor | aBrowserRequestor browseMcMethodHistory ]
>>>              condition:
>>>                      [ : aBrowserRequestor | true ]!
>>>
>>> Item was changed:
>>> ----- Method: MCSnapshotBrowser>>visibleCategories (in category 'listing') -----
>>> visibleCategories
>>> +     ^ ((self packageOrganizations gather: [:ea | ea categories])
>>> +             , (self packageClasses collect: [:ea | ea category])
>>> +             , (self hasExtensions
>>> +                     ifTrue: [{self extensionsCategory}]
>>> +                     ifFalse: [Array empty])) asSet asSortedCollection: [:each | each ifNil: ['~(put nils to the end)']] ascending!
>>> -     ^ ((self packageOrganizations gather: [:ea | ea categories]),
>>> -             (self packageClasses collect: [:ea | ea category]),
>>> -                     (self hasExtensions ifTrue: [{self extensionsCategory}] ifFalse: [#()]))
>>> -                             asSet asSortedCollection!
>>>
>>> Item was changed:
>>> ----- Method: MCWorkingCopyBrowser>>repositoryListMenu: (in category 'morphic ui') -----
>>> repositoryListMenu: aMenu
>>>      "first add repository-specific commands"
>>>      self repository ifNotNil:
>>>              [ self
>>>                      fillMenu: aMenu
>>>                      fromSpecs:
>>>                              #(('open repository' #openRepository)
>>>                              ('edit repository info' #editRepository)
>>>                              ('add to package...' #addRepositoryToPackage)
>>>                              ('remove repository' #removeRepository)
>>> +                             ('demote to bottom' #demoteRepository)
>>> -                             ('move to bottom' #demoteRepository)
>>>                              ('copy image versions here' #copyImageVersions)).
>>>              aMenu
>>>                      add:
>>>                              (self repository alwaysStoreDiffs
>>>                                      ifTrue: ['store full versions']
>>>                                      ifFalse: ['store diffs'])
>>>                              target: self
>>>                              selector: #toggleDiffs ;
>>>                      addLine ].
>>>      "then the non-specific commands"
>>>      ^self fillMenu: aMenu fromSpecs:
>>>              #(      ('load repositories' #loadRepositories)
>>>                      ('save repositories' #saveRepositories)
>>>                      ('flush cached versions' #flushCachedVersions)
>>>                      ('flush cached versions and ancestry' #flushCachedVersionsAncestry))!
>>>
>>>
>>
>>
>