The Trunk: Monticello-ct.710.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Monticello-ct.710.mcz

commits-2
Nicolas Cellier uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-ct.710.mcz

==================== Summary ====================

Name: Monticello-ct.710
Author: ct
Time: 30 December 2019, 3:17:37.039602 pm
UUID: 6df89c06-6946-d141-9ebc-bc42ae6d9b7f
Ancestors: Monticello-ct.706

Improve support for traits by moving some class extensions up to ClassDefinition. This is possible because PackageInfo >> #includesClass: also works with metaclasses or traits.

Just by the way, this fixes some bugs introduced by SqueakIssueIntegration's UI extensions (see https://github.com/hpi-swa-teaching/SqueakIssueIntegration/blob/master/packages/IssueIntegration-UI.package/ClassDescription.extension/instance/toolIconSelector..st).

=============== Diff against Monticello-ct.706 ===============

Item was removed:
- ----- Method: Class>>packageInfo (in category '*monticello') -----
- packageInfo
- ^ (PackageInfo allPackages select: [ : each | each includesClass: self ])
- ifEmpty: [ nil ]
- ifNotEmpty:
- [ : myPackages | "Select the most-qualified match."
- myPackages detectMax: [ : each | each packageName size ] ]!

Item was removed:
- ----- Method: Class>>workingCopy (in category '*monticello') -----
- workingCopy
- "Answer the MCWorkingCopy in which I am defined."
- ^ self packageInfo ifNotNil: [ : pi | pi workingCopy ]!

Item was added:
+ ----- Method: ClassDescription>>packageInfo (in category '*monticello') -----
+ packageInfo
+ ^ (PackageInfo allPackages select: [ : each | each includesClass: self ])
+ ifEmpty: [ nil ]
+ ifNotEmpty:
+ [ : myPackages | "Select the most-qualified match."
+ myPackages detectMax: [ : each | each packageName size ] ]!

Item was added:
+ ----- Method: ClassDescription>>workingCopy (in category '*monticello') -----
+ workingCopy
+ "Answer the MCWorkingCopy in which I am defined."
+ ^ self packageInfo ifNotNil: [ : pi | pi workingCopy ]!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Monticello-ct.710.mcz

Tobias Pape

> On 05.03.2020, at 21:04, [hidden email] wrote:
>
> PackageInfo >> #includesClass: also works with metaclasses or traits.

So it should be actually #includesBehavior: ? :)
-t

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Monticello-ct.710.mcz

Christoph Thiede

> PackageInfo >> #includesClass: also works with metaclasses or traits.

> So it should be actually #includesBehavior: ? :)

Oops, yes :D


Von: Squeak-dev <[hidden email]> im Auftrag von Tobias Pape <[hidden email]>
Gesendet: Donnerstag, 5. März 2020 21:19:11
An: [hidden email]
Betreff: Re: [squeak-dev] The Trunk: Monticello-ct.710.mcz
 

> On 05.03.2020, at 21:04, [hidden email] wrote:
>
> PackageInfo >> #includesClass: also works with metaclasses or traits.

So it should be actually #includesBehavior: ? :)
-t



Carpe Squeak!