Smalltalk › Squeak › Squeak - Dev

The Trunk: Monticello-dtl.605.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

commits-2

The Trunk: Monticello-dtl.605.mcz

David T. Lewis uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-dtl.605.mcz

==================== Summary ====================

Name: Monticello-dtl.605
Author: dtl
Time: 30 November 2014, 2:51:55.03 pm
UUID: 7ee2c5c7-7da0-4241-bf1d-148741ed76a2
Ancestors: Monticello-bf.604

Add a nil check, allows saving an initial empty package in a new repository.

=============== Diff against Monticello-bf.604 ===============

Item was changed:
----- Method: MCWorkingCopy>>newVersion (in category 'operations') -----
newVersion
| packageSnapshot parentSnapshot patch patchBlock |
parentSnapshot := self parentSnapshot.
patchBlock := [patch := (packageSnapshot := package snapshot) patchRelativeToBase: parentSnapshot].
patchBlock value. "Ensure that this is called at least once."
^ (self requestVersionNameAndMessageWithSuggestion: self uniqueVersionName
initialMessage: self patchMessageSuggestion
patchBlock: patchBlock
) ifNotNil: [:tuple |
self newVersionWithName: tuple first withBlanksTrimmed
message: (self patchMessageStripped: tuple second)
+ snapshot: ((tuple size >= 3 and: [tuple third notNil and: [tuple third notEmpty]])
- snapshot: ((tuple size >= 3 and: [tuple third notEmpty])
ifTrue: [ MCPatcher apply: (patch ignoring: tuple third) to: parentSnapshot]
ifFalse: [packageSnapshot])]!

Chris Muller-3

Re: The Trunk: Monticello-dtl.605.mcz

We have been experiencing issues with empty mcz versions recently.
Will this make that problem more invisible?

On Sun, Nov 30, 2014 at 1:52 PM, <[hidden email]> wrote:

> David T. Lewis uploaded a new version of Monticello to project The Trunk:
> http://source.squeak.org/trunk/Monticello-dtl.605.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-dtl.605
> Author: dtl
> Time: 30 November 2014, 2:51:55.03 pm
> UUID: 7ee2c5c7-7da0-4241-bf1d-148741ed76a2
> Ancestors: Monticello-bf.604
>
> Add a nil check, allows saving an initial empty package in a new repository.
>
> =============== Diff against Monticello-bf.604 ===============
>
> Item was changed:
> ----- Method: MCWorkingCopy>>newVersion (in category 'operations') -----
> newVersion
> | packageSnapshot parentSnapshot patch patchBlock |
> parentSnapshot := self parentSnapshot.
> patchBlock := [patch := (packageSnapshot := package snapshot) patchRelativeToBase: parentSnapshot].
> patchBlock value. "Ensure that this is called at least once."
> ^ (self requestVersionNameAndMessageWithSuggestion: self uniqueVersionName
> initialMessage: self patchMessageSuggestion
> patchBlock: patchBlock
> ) ifNotNil: [:tuple |
> self newVersionWithName: tuple first withBlanksTrimmed
> message: (self patchMessageStripped: tuple second)
> + snapshot: ((tuple size >= 3 and: [tuple third notNil and: [tuple third notEmpty]])
> - snapshot: ((tuple size >= 3 and: [tuple third notEmpty])
> ifTrue: [ MCPatcher apply: (patch ignoring: tuple third) to: parentSnapshot]
> ifFalse: [packageSnapshot])]!
>
>

David T. Lewis

Re: The Trunk: Monticello-dtl.605.mcz

On Sun, Nov 30, 2014 at 02:28:30PM -0600, Chris Muller wrote:
> We have been experiencing issues with empty mcz versions recently.
> Will this make that problem more invisible?

I doubt it. I was intentionally setting up a new local repository and
saving a newly created empty package to it. It's not something that you
would likely do very often, but I am trying out the idea of moving Chronology
to a separate package outside of Kernel(*), so I was starting with a new empty
Chronology package as a starting point in my local repository. It seems that
nil does not understand the concept of emptiness(**), hence the fix.

I'm sure that whatever might be going wrong to produce an empty mcz would
be unrelated to this scenario.

Dave

(*) The reason I am trying this is that my UTCDateAndTime package is proving
to be unmaintainable in Monticello because it is part of the much larger Kernel
package. A SAR distribution works fine, but I'd prefer to use Monticello to
keep it up to date with trunk, and to make it loadable in the new Spur image
formats for the next Squeak release.

http://wiki.squeak.org/squeak/6197
http://ss3.gemstone.com/ss/UTCDateAndTime.html

(**) I have so far resisted the temptation to initiate a philosophical debate
on this topic ;-)

>
> On Sun, Nov 30, 2014 at 1:52 PM, <[hidden email]> wrote:
> > David T. Lewis uploaded a new version of Monticello to project The Trunk:
> > http://source.squeak.org/trunk/Monticello-dtl.605.mcz
> >
> > ==================== Summary ====================
> >
> > Name: Monticello-dtl.605
> > Author: dtl
> > Time: 30 November 2014, 2:51:55.03 pm
> > UUID: 7ee2c5c7-7da0-4241-bf1d-148741ed76a2
> > Ancestors: Monticello-bf.604
> >
> > Add a nil check, allows saving an initial empty package in a new repository.
> >
> > =============== Diff against Monticello-bf.604 ===============
> >
> > Item was changed:
> > ----- Method: MCWorkingCopy>>newVersion (in category 'operations') -----
> > newVersion
> > | packageSnapshot parentSnapshot patch patchBlock |
> > parentSnapshot := self parentSnapshot.
> > patchBlock := [patch := (packageSnapshot := package snapshot) patchRelativeToBase: parentSnapshot].
> > patchBlock value. "Ensure that this is called at least once."
> > ^ (self requestVersionNameAndMessageWithSuggestion: self uniqueVersionName
> > initialMessage: self patchMessageSuggestion
> > patchBlock: patchBlock
> > ) ifNotNil: [:tuple |
> > self newVersionWithName: tuple first withBlanksTrimmed
> > message: (self patchMessageStripped: tuple second)
> > + snapshot: ((tuple size >= 3 and: [tuple third notNil and: [tuple third notEmpty]])
> > - snapshot: ((tuple size >= 3 and: [tuple third notEmpty])
> > ifTrue: [ MCPatcher apply: (patch ignoring: tuple third) to: parentSnapshot]
> > ifFalse: [packageSnapshot])]!
> >
> >

timrowledge

Re: The Trunk: Monticello-dtl.605.mcz

On 30-11-2014, at 1:15 PM, David T. Lewis <[hidden email]> wrote:
It seems that
> nil does not understand the concept of emptiness(**), hence the fix.
>
> (**) I have so far resisted the temptation to initiate a philosophical debate
> on this topic ;-)

Eh, there’s nothing to it.

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- All foam, no beer.

David T. Lewis

Re: The Trunk: Monticello-dtl.605.mcz

On Sun, Nov 30, 2014 at 02:17:50PM -0800, tim Rowledge wrote:
>
> On 30-11-2014, at 1:15 PM, David T. Lewis <[hidden email]> wrote:
> It seems that
> > nil does not understand the concept of emptiness(**), hence the fix.
> >
> > (**) I have so far resisted the temptation to initiate a philosophical debate
> > on this topic ;-)
>
> Eh, there?s nothing to it.

Easy for you to say, but any attempt at serious debate is sure to come to naught.

Dave