Nicolas Cellier uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-nice.328.mcz ==================== Summary ==================== Name: Monticello-nice.328 Author: nice Time: 22 October 2009, 2:24 am UUID: 17eebb71-2bcb-704b-9190-6fde34973c2a Ancestors: Monticello-nice.327 classVarNames are already sorted now =============== Diff against Monticello-nice.327 =============== Item was changed: ----- Method: PseudoClass>>asClassDefinition (in category '*monticello') ----- asClassDefinition ^ MCClassDefinition name: self name superclassName: self superclass name category: self category instVarNames: self instVarNames + classVarNames: self classVarNames - classVarNames: self classVarNames asSortedCollection poolDictionaryNames: self poolDictionaryNames classInstVarNames: self class instVarNames type: self typeOfClass comment: self organization classComment asString commentStamp: self organization commentStamp ! |
Nicholas,
it's great to see you clean up even the little things :) But I don't think Monticello should rely on #classVarNames being sorted. The fewer difference we have in the trunk version to the upstream version the better (ideally zero). And given the typical number of class vars, this is not a performance issue. Please continue making Squeak nicer (pun intended) but let's not burn bridges unnecessarily. - Bert - On 22.10.2009, at 14:23, [hidden email] wrote: > Nicolas Cellier uploaded a new version of Monticello to project The > Trunk: > http://source.squeak.org/trunk/Monticello-nice.328.mcz > > ==================== Summary ==================== > > Name: Monticello-nice.328 > Author: nice > Time: 22 October 2009, 2:24 am > UUID: 17eebb71-2bcb-704b-9190-6fde34973c2a > Ancestors: Monticello-nice.327 > > classVarNames are already sorted now > > =============== Diff against Monticello-nice.327 =============== > > Item was changed: > ----- Method: PseudoClass>>asClassDefinition (in category > '*monticello') ----- > asClassDefinition > ^ MCClassDefinition > name: self name > superclassName: self superclass name > category: self category > instVarNames: self instVarNames > + classVarNames: self classVarNames > - classVarNames: self classVarNames asSortedCollection > poolDictionaryNames: self poolDictionaryNames > classInstVarNames: self class instVarNames > type: self typeOfClass > comment: self organization classComment asString > commentStamp: self organization commentStamp ! > > |
2009/10/22 Bert Freudenberg <[hidden email]>:
> Nicholas, > > it's great to see you clean up even the little things :) > > But I don't think Monticello should rely on #classVarNames being sorted. The > fewer difference we have in the trunk version to the upstream version the > better (ideally zero). > OK > And given the typical number of class vars, this is not a performance issue. > > Please continue making Squeak nicer (pun intended) but let's not burn > bridges unnecessarily. > > - Bert - > > On 22.10.2009, at 14:23, [hidden email] wrote: > >> Nicolas Cellier uploaded a new version of Monticello to project The Trunk: >> http://source.squeak.org/trunk/Monticello-nice.328.mcz >> >> ==================== Summary ==================== >> >> Name: Monticello-nice.328 >> Author: nice >> Time: 22 October 2009, 2:24 am >> UUID: 17eebb71-2bcb-704b-9190-6fde34973c2a >> Ancestors: Monticello-nice.327 >> >> classVarNames are already sorted now >> >> =============== Diff against Monticello-nice.327 =============== >> >> Item was changed: >> ----- Method: PseudoClass>>asClassDefinition (in category '*monticello') >> ----- >> asClassDefinition >> ^ MCClassDefinition >> name: self name >> superclassName: self superclass name >> category: self category >> instVarNames: self instVarNames >> + classVarNames: self classVarNames >> - classVarNames: self classVarNames asSortedCollection >> poolDictionaryNames: self poolDictionaryNames >> classInstVarNames: self class instVarNames >> type: self typeOfClass >> comment: self organization classComment asString >> commentStamp: self organization commentStamp ! >> >> > > > > |
Free forum by Nabble | Edit this page |