The Trunk: Monticello-ul.374.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Monticello-ul.374.mcz

commits-2
Levente Uzonyi uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-ul.374.mcz

==================== Summary ====================

Name: Monticello-ul.374
Author: ul
Time: 28 February 2010, 2:57:06.129 pm
UUID: c8779e3f-6e45-2d4a-828e-d6e02cb40546
Ancestors: Monticello-ar.372

- replaced MCMethodDefinition's Definitions class variable with a class instance variable. The cached definitions are no longer registered for finalization.
- a bit of cleanup around MCDefinition's Instances class variable

=============== Diff against Monticello-ar.372 ===============

Item was changed:
  ----- Method: MCMethodDefinition class>>shutDown (in category 'as yet unclassified') -----
  shutDown
+
+ definitions := nil.!
- WeakArray removeWeakDependent: Definitions.
- Definitions := nil.!

Item was changed:
  ----- Method: MCMethodDefinition class>>cachedDefinitions (in category 'as yet unclassified') -----
  cachedDefinitions
+
+ ^definitions ifNil: [ definitions := WeakIdentityKeyDictionary new ]!
- Definitions ifNil: [Definitions := WeakIdentityKeyDictionary new.  WeakArray addWeakDependent: Definitions].
- ^ Definitions!

Item was changed:
  MCDefinition subclass: #MCMethodDefinition
  instanceVariableNames: 'classIsMeta source category selector className timeStamp'
+ classVariableNames: ''
- classVariableNames: 'Definitions'
  poolDictionaries: ''
  category: 'Monticello-Modeling'!
+ MCMethodDefinition class
+ instanceVariableNames: 'definitions'!
+ MCMethodDefinition class
+ instanceVariableNames: 'definitions'!

Item was changed:
  ----- Method: MCDefinition class>>instanceLike: (in category 'as yet unclassified') -----
  instanceLike: aDefinition
+
+ ^(Instances ifNil: [ Instances := WeakSet new ])
+ like: aDefinition
+ ifAbsent: [ Instances add: aDefinition ]!
- Instances ifNil: [Instances := WeakSet new].
- ^ (Instances like: aDefinition) ifNil: [Instances add: aDefinition]!

Item was added:
+ (PackageInfo named: 'Monticello') preamble: 'WeakArray removeDependent: (MCMethodDefinition classPool at: #Definitions)'!

Item was changed:
  ----- Method: MCDefinition class>>clearInstances (in category 'as yet unclassified') -----
  clearInstances
+
- WeakArray removeWeakDependent: Instances.
  Instances := nil!

Item was removed:
- ----- Method: MCSnapshotBrowser>>aboutToStyle: (in category 'morphic ui') -----
- aboutToStyle: aStyler
-
- | classOrMetaClass shouldStyle |
- classSelection ifNil: [ ^false ].
- switch = #comment ifTrue: [ ^false ].
- (protocolSelection notNil and: [
- methodSelection notNil ])
- ifTrue: [
- classOrMetaClass := self selectedClassOrMetaClass.
- shouldStyle := true ]
- ifFalse: [
- classOrMetaClass := nil.
- shouldStyle := categorySelection ~= self extensionsCategory ].
- aStyler classOrMetaClass: classOrMetaClass.
- ^shouldStyle!