The Trunk: Monticello-ul.679.mcz
Locked
 
|
Levente Uzonyi uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-ul.679.mcz ==================== Summary ==================== Name: Monticello-ul.679 Author: ul Time: 22 March 2018, 7:32:51.372118 pm UUID: 7f5a3bf7-0cda-4200-b035-d9ce789f19d5 Ancestors: Monticello-ul.678 - enable #useSharedWebClientInstance by default when WebClient is present =============== Diff against Monticello-ul.678 =============== Item was changed: ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') ----- useSharedWebClientInstance <preference: 'Use shared WebClient instance' category: 'Monticello' description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.' type: #Boolean> + ^UseSharedWebClientInstance ifNil: [ Smalltalk hasClassNamed: #WebClient ]! - ^UseSharedWebClientInstance ifNil: [ false ]! |
Re: The Trunk: Monticello-ul.679.mcz
|
|
Hi Levente
I really like the reuse-idea. Also, WebClient is part of Squeak/Trunk since 4.5 I think. I think it is safe to assume that it's there. Let's rather completely deprecate HTTPSocket instead :) Best regards -Tobias > On 22.03.2018, at 19:33, [hidden email] wrote: > > Levente Uzonyi uploaded a new version of Monticello to project The Trunk: > http://source.squeak.org/trunk/Monticello-ul.679.mcz > > ==================== Summary ==================== > > Name: Monticello-ul.679 > Author: ul > Time: 22 March 2018, 7:32:51.372118 pm > UUID: 7f5a3bf7-0cda-4200-b035-d9ce789f19d5 > Ancestors: Monticello-ul.678 > > - enable #useSharedWebClientInstance by default when WebClient is present > > =============== Diff against Monticello-ul.678 =============== > > Item was changed: > ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') ----- > useSharedWebClientInstance > > <preference: 'Use shared WebClient instance' > category: 'Monticello' > description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.' > type: #Boolean> > + ^UseSharedWebClientInstance ifNil: [ Smalltalk hasClassNamed: #WebClient ]! > - ^UseSharedWebClientInstance ifNil: [ false ]! > > |
Re: The Trunk: Monticello-ul.679.mcz
|
|
Hi Tobias,
When WebClient was added, HTTPSocket was modified to use WebClient when it's present, but still work when it's not. I simply followed that path. WebClient still has no dependencies in the Trunk, so one should be able to safely unload it. But sure, we can just "nuke" HTTPSocket & co. in favor of WebClient. Levente On Thu, 22 Mar 2018, Tobias Pape wrote: > Hi Levente > > > I really like the reuse-idea. > Also, WebClient is part of Squeak/Trunk since 4.5 I think. I think it is safe to assume that it's there. Let's rather completely deprecate HTTPSocket instead :) > > Best regards > -Tobias >> On 22.03.2018, at 19:33, [hidden email] wrote: >> >> Levente Uzonyi uploaded a new version of Monticello to project The Trunk: >> http://source.squeak.org/trunk/Monticello-ul.679.mcz >> >> ==================== Summary ==================== >> >> Name: Monticello-ul.679 >> Author: ul >> Time: 22 March 2018, 7:32:51.372118 pm >> UUID: 7f5a3bf7-0cda-4200-b035-d9ce789f19d5 >> Ancestors: Monticello-ul.678 >> >> - enable #useSharedWebClientInstance by default when WebClient is present >> >> =============== Diff against Monticello-ul.678 =============== >> >> Item was changed: >> ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') ----- >> useSharedWebClientInstance >> >> <preference: 'Use shared WebClient instance' >> category: 'Monticello' >> description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.' >> type: #Boolean> >> + ^UseSharedWebClientInstance ifNil: [ Smalltalk hasClassNamed: #WebClient ]! >> - ^UseSharedWebClientInstance ifNil: [ false ]! >> >> |
|
|
I've finally started moving my use over to WebClient directly. I like the ability to tune the timeout (or turn it off) and the extended capabilities to modify response handling (some tricky rest clients didn't quite work out of the box). I see no pressing reason not to move Trunk to using WebClient. Maybe wait a release (or 3+, as seems to be common) to remove HTTPSocket, but move our usage away seems reasonable. -cbc On Thu, Mar 22, 2018 at 5:05 PM, Levente Uzonyi <[hidden email]> wrote: Hi Tobias, |
Re: The Trunk: Monticello-ul.679.mcz
|
|
In reply to this post by Levente Uzonyi
> On 23.03.2018, at 01:05, Levente Uzonyi <[hidden email]> wrote: > > Hi Tobias, > > When WebClient was added, HTTPSocket was modified to use WebClient when it's present, but still work when it's not. I simply followed that path. > WebClient still has no dependencies in the Trunk, so one should be able to > safely unload it. I think Chris Muller went ahead and changed that in HTTPSocket so that it is now no longer possible to remove it… (see protocol *webclient-http in HTTPSocket class) But I maybe wrong. Maybe it was already the case when we fully loaded webclient, we probably killed the HTTPRequestHandler functionality. Thus, if we unload WebClient, everything using HTTPSocket already breaks… HTTPSocket is now merely a - shim for WebClient - holder of various, maybe dubious, preferences and data - The only thing that knows what a HTTPBlabEmail is for (w.t.h...) Best regards -Tobias > But sure, we can just "nuke" HTTPSocket & co. in favor of WebClient. > > Levente > > On Thu, 22 Mar 2018, Tobias Pape wrote: > >> Hi Levente >> >> >> I really like the reuse-idea. >> Also, WebClient is part of Squeak/Trunk since 4.5 I think. I think it is safe to assume that it's there. Let's rather completely deprecate HTTPSocket instead :) >> >> Best regards >> -Tobias >>> On 22.03.2018, at 19:33, [hidden email] wrote: >>> Levente Uzonyi uploaded a new version of Monticello to project The Trunk: >>> http://source.squeak.org/trunk/Monticello-ul.679.mcz >>> ==================== Summary ==================== >>> Name: Monticello-ul.679 >>> Author: ul >>> Time: 22 March 2018, 7:32:51.372118 pm >>> UUID: 7f5a3bf7-0cda-4200-b035-d9ce789f19d5 >>> Ancestors: Monticello-ul.678 >>> - enable #useSharedWebClientInstance by default when WebClient is present >>> =============== Diff against Monticello-ul.678 =============== >>> Item was changed: >>> ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') ----- >>> useSharedWebClientInstance >>> >>> <preference: 'Use shared WebClient instance' >>> category: 'Monticello' >>> description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.' >>> type: #Boolean> >>> + ^UseSharedWebClientInstance ifNil: [ Smalltalk hasClassNamed: #WebClient ]! >>> - ^UseSharedWebClientInstance ifNil: [ false ]! >>> > |
«
Return to Squeak - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |