Smalltalk › Squeak › Squeak - Dev

The Trunk: Monticello-ul.702.mcz

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 4 messages Options
commits-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

The Trunk: Monticello-ul.702.mcz

commits-2
Levente Uzonyi uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-ul.702.mcz

==================== Summary ====================

Name: Monticello-ul.702
Author: ul
Time: 23 September 2019, 5:42:41.889162 pm
UUID: a4a352f6-efcd-41ce-b716-f490b49229bb
Ancestors: Monticello-ul.701

- disable #useSharedWebClientInstance on Windows by default until the issue is resolved

=============== Diff against Monticello-ul.701 ===============

Item was changed:
  ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') -----
  useSharedWebClientInstance
 
  <preference: 'Use shared WebClient instance'
  category: 'Monticello'
  description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.'
  type: #Boolean>
+ ^UseSharedWebClientInstance ifNil: [
+ "The is some issue on Windows, so don't use it there by default. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2019-September/thread.html#203921 for details."
+ Smalltalk os platformName ~= 'Win32' ]!
- ^UseSharedWebClientInstance ifNil: [ true ]!


Hannes Hirzel
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Monticello-ul.702.mcz

Hannes Hirzel
Thank you for this fix. Good to have the reference to the thread.

--Hannes

On Mon, 23 Sep 2019 15:43:06 0000, [hidden email]
<[hidden email]> wrote:

> Levente Uzonyi uploaded a new version of Monticello to project The Trunk:
> http://source.squeak.org/trunk/Monticello-ul.702.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-ul.702
> Author: ul
> Time: 23 September 2019, 5:42:41.889162 pm
> UUID: a4a352f6-efcd-41ce-b716-f490b49229bb
> Ancestors: Monticello-ul.701
>
> - disable #useSharedWebClientInstance on Windows by default until the issue
> is resolved
>
> =============== Diff against Monticello-ul.701 ===============
>
> Item was changed:
>   ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in
> category 'preferences') -----
>   useSharedWebClientInstance
>  
>   <preference: 'Use shared WebClient instance'
>   category: 'Monticello'
>   description: 'When true, use a shared WebClient instance to speed up
> downloads from MCHttpRepositories. Requires WebClient to be present.'
>   type: #Boolean>
> + ^UseSharedWebClientInstance ifNil: [
> + "The is some issue on Windows, so don't use it there by default. See
> http://lists.squeakfoundation.org/pipermail/squeak-dev/2019-September/thread.html#203921
> for details."
> + Smalltalk os platformName ~= 'Win32' ]!
> - ^UseSharedWebClientInstance ifNil: [ true ]!
>
>
>

Christoph Thiede
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Monticello-ul.702.mcz

Christoph Thiede
In reply to this post by commits-2

Maybe we should even disable it on all clients via script? Most users are likely not to read each commit message ...

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Montag, 23. September 2019 17:43:06
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: Monticello-ul.702.mcz
 
Levente Uzonyi uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-ul.702.mcz

==================== Summary ====================

Name: Monticello-ul.702
Author: ul
Time: 23 September 2019, 5:42:41.889162 pm
UUID: a4a352f6-efcd-41ce-b716-f490b49229bb
Ancestors: Monticello-ul.701

- disable #useSharedWebClientInstance on Windows by default until the issue is resolved

=============== Diff against Monticello-ul.701 ===============

Item was changed:
  ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') -----
  useSharedWebClientInstance
        
         <preference: 'Use shared WebClient instance'
                 category: 'Monticello'
                 description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.'
                 type: #Boolean>
+        ^UseSharedWebClientInstance ifNil: [
+                "The is some issue on Windows, so don't use it there by default. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2019-September/thread.html#203921 for details."
+                Smalltalk os platformName ~= 'Win32' ]!
-        ^UseSharedWebClientInstance ifNil: [ true ]!

Carpe Squeak!
Levente Uzonyi
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Monticello-ul.702.mcz

Levente Uzonyi
On Wed, 2 Oct 2019, Thiede, Christoph wrote:

>
> Maybe we should even disable it on all clients via script? Most users are likely not to read each commit message ...

Those who have changed the value of the preference either turned it off,
and they're fine or turned it on, so they know what they're doing.
For everyone else, the default value be in effect, which is: disabled on
Windows, enabled on any other platform.

Levente

>
> __________________________________________________________________________________________________________________________________________________________
> Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
> Gesendet: Montag, 23. September 2019 17:43:06
> An: [hidden email]; [hidden email]
> Betreff: [squeak-dev] The Trunk: Monticello-ul.702.mcz  
> Levente Uzonyi uploaded a new version of Monticello to project The Trunk:
> http://source.squeak.org/trunk/Monticello-ul.702.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-ul.702
> Author: ul
> Time: 23 September 2019, 5:42:41.889162 pm
> UUID: a4a352f6-efcd-41ce-b716-f490b49229bb
> Ancestors: Monticello-ul.701
>
> - disable #useSharedWebClientInstance on Windows by default until the issue is resolved
>
> =============== Diff against Monticello-ul.701 ===============
>
> Item was changed:
>   ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') -----
>   useSharedWebClientInstance
>         
>          <preference: 'Use shared WebClient instance'
>                  category: 'Monticello'
>                  description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be
> present.'
>                  type: #Boolean>
> +        ^UseSharedWebClientInstance ifNil: [
> +                "The is some issue on Windows, so don't use it there by default. See
> http://lists.squeakfoundation.org/pipermail/squeak-dev/2019-September/thread.html#203921 for details."
> +                Smalltalk os platformName ~= 'Win32' ]!
> -        ^UseSharedWebClientInstance ifNil: [ true ]!
>
>
>
>
Free forum by Nabble Edit this page