Smalltalk › Squeak › Squeak - Dev

The Trunk: Morphic-bf.751.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

commits-2

The Trunk: Morphic-bf.751.mcz

Bert Freudenberg uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-bf.751.mcz

==================== Summary ====================

Name: Morphic-bf.751
Author: bf
Time: 15 November 2014, 6:05:35.432 pm
UUID: 5fb78a95-2971-460e-88c7-99b58c3152ca
Ancestors: Morphic-topa.750, Morphic-dhn.723

Merge Morphic-dhn.723:
Reduce cropping of SystemWindow submorphs by fullScreen

=============== Diff against Morphic-topa.750 ===============

Item was changed:
----- Method: SystemWindow>>fullScreen (in category 'menu') -----
fullScreen
+ "Zoom Window to full owner size, allowing for scroll bars and desk margins"
- "Zoom Window to Full World size with possible DeskMargins"
- "SystemWindow fullScreen"

| left right possibleBounds |
left := right := 0.
self paneMorphs
do: [:pane | ((pane isKindOf: ScrollPane)
and: [pane retractableScrollBar])
ifTrue: [pane scrollBarOnLeft
ifTrue: [left := left max: pane scrollBarThickness]
ifFalse: [right := right max: pane scrollBarThickness]]].
+ possibleBounds := (RealEstateAgent maximumUsableAreaInWorld: self owner)
- possibleBounds := (RealEstateAgent maximumUsableAreaInWorld: self world)
insetBy: (left @ 0 corner: right @ 0).
Preferences fullScreenLeavesDeskMargins
ifTrue: [possibleBounds := possibleBounds insetBy: 22].
self bounds: possibleBounds!

marcel.taeumel (old)

Re: The Trunk: Morphic-bf.751.mcz

Hi, Bert. :)

Looks good, except that the interface of RealEstateAgent seems now strange. Here, we make the assumption that either the owner is a world or that the selector #maximumUsableAreaInWorld: should be renamed to something more generic. In combination with "Preferences fullScreenLeavesDeskMargins" one could question such a global preference for this owner-specific implementation.

If sytem windows can be embedded in any kind of morph, the thing about desk margins should be redesigned and the interface of RealEstateAgent should be refactored.

If system windows can only be embedded into paste-up morphs, "self owner" seems semantically wrong.

Just for documentation. :)

Best,
Marcel

Bert Freudenberg

Morphic-dhn.723.mcz (was: Morphic-bf.751.mcz)

On 17.11.2014, at 12:05, Marcel Taeumel <[hidden email]> wrote:

> Hi, Bert. :)
>
> Looks good, except that the interface of RealEstateAgent seems now strange.
> Here, we make the assumption that either the owner is a world or that the
> selector #maximumUsableAreaInWorld: should be renamed to something more
> generic. In combination with "Preferences fullScreenLeavesDeskMargins" one
> could question such a global preference for this owner-specific
> implementation.
>
> If sytem windows can be embedded in any kind of morph, the thing about desk
> margins should be redesigned and the interface of RealEstateAgent should be
> refactored.
>
> If system windows can only be embedded into paste-up morphs, "self owner"
> seems semantically wrong.
>
> Just for documentation. :)

Go ahead and rewrite it, or at least add a "todo" comment ;)

I didn't actually write this, was simply merging Morphic-dhn.723, because it looked innocuous. Who is "dhn"?

- Bert -

smime.p7s (5K) Download Attachment

Dan Norton

Re: Morphic-dhn.723.mcz (was: Morphic-bf.751.mcz)

-----Original Message-----

>From: Bert Freudenberg <[hidden email]>
>Sent: Nov 17, 2014 10:06 AM
>To: The general-purpose Squeak developers list <[hidden email]>
>Subject: [squeak-dev] Morphic-dhn.723.mcz (was: Morphic-bf.751.mcz)
>
>On 17.11.2014, at 12:05, Marcel Taeumel <[hidden email]> wrote:
>
>> Hi, Bert. :)
>>
>> Looks good, except that the interface of RealEstateAgent seems now strange.
>> Here, we make the assumption that either the owner is a world or that the
>> selector #maximumUsableAreaInWorld: should be renamed to something more
>> generic. In combination with "Preferences fullScreenLeavesDeskMargins" one
>> could question such a global preference for this owner-specific
>> implementation.
>>
>> If sytem windows can be embedded in any kind of morph, the thing about desk
>> margins should be redesigned and the interface of RealEstateAgent should be
>> refactored.
>>
>> If system windows can only be embedded into paste-up morphs, "self owner"
>> seems semantically wrong.
>>
>> Just for documentation. :)
>
>Go ahead and rewrite it, or at least add a "todo" comment ;)
>
>I didn't actually write this, was simply merging Morphic-dhn.723, because it looked innocuous. Who is "dhn"?
>
>- Bert -
>

When SystemWindow is embedded in a paste-up morph other than World it will be cropped by fullScreen unless the paste-up is the same size (?) :) There are other problems with the border that I have not isolated.

I agree with the point about semantics.

How can I get my initials to be recognized in case I submit something else?

- Dan Norton "dhn"

Bert Freudenberg

Re: Morphic-dhn.723.mcz (was: Morphic-bf.751.mcz)

On 18.11.2014, at 04:25, <[hidden email]> <[hidden email]> wrote:

>
>
>
> -----Original Message-----
>> From: Bert Freudenberg <[hidden email]>
>> Sent: Nov 17, 2014 10:06 AM
>> To: The general-purpose Squeak developers list <[hidden email]>
>> Subject: [squeak-dev] Morphic-dhn.723.mcz (was: Morphic-bf.751.mcz)
>>
>> On 17.11.2014, at 12:05, Marcel Taeumel <[hidden email]> wrote:
>>
>>> Hi, Bert. :)
>>>
>>> Looks good, except that the interface of RealEstateAgent seems now strange.
>>> Here, we make the assumption that either the owner is a world or that the
>>> selector #maximumUsableAreaInWorld: should be renamed to something more
>>> generic. In combination with "Preferences fullScreenLeavesDeskMargins" one
>>> could question such a global preference for this owner-specific
>>> implementation.
>>>
>>> If sytem windows can be embedded in any kind of morph, the thing about desk
>>> margins should be redesigned and the interface of RealEstateAgent should be
>>> refactored.
>>>
>>> If system windows can only be embedded into paste-up morphs, "self owner"
>>> seems semantically wrong.
>>>
>>> Just for documentation. :)
>>
>> Go ahead and rewrite it, or at least add a "todo" comment ;)
>>
>> I didn't actually write this, was simply merging Morphic-dhn.723, because it looked innocuous. Who is "dhn"?
>>
>> - Bert -
>>
> When SystemWindow is embedded in a paste-up morph other than World it will be cropped by fullScreen unless the paste-up is the same size (?) :) There are other problems with the border that I have not isolated.
>
> I agree with the point about semantics.
>
> How can I get my initials to be recognized in case I submit something else?
>
> - Dan Norton "dhn"

Register on

http://source.squeak.org/

This at least let's us look you up.

Additionally, you can add your initials and password to the Inbox repository in your image. If you do that, then the source server will be able to show your name with the submission (e.g. in the commit notification it posts to squeak-dev).

- Bert -

smime.p7s (5K) Download Attachment

Chris Muller-3

Re: Morphic-dhn.723.mcz (was: Morphic-bf.751.mcz)

In reply to this post by Dan Norton

> How can I get my initials to be recognized in case I submit something else?

I would recommend registering your same initials on SqueakMap too.

map.squeak.org

>
> - Dan Norton "dhn"
>