The Trunk: Morphic-cbc.1451.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-cbc.1451.mcz

commits-2
Chris Cunningham uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cbc.1451.mcz

==================== Summary ====================

Name: Morphic-cbc.1451
Author: cbc
Time: 12 June 2018, 10:20:33.204594 pm
UUID: eeba2c6d-1d3b-8c4f-9798-2d5f590eb318
Ancestors: Morphic-cbc.1450

Fix so that Projects>Jump To Project submenu is readable in dark color themes (by commenting out setting of the color - default works much better).

=============== Diff against Morphic-cbc.1450 ===============

Item was changed:
  ----- Method: MorphicProject>>addItem:toMenu:selection:color:thumbnail: (in category 'utilities') -----
  addItem: item toMenu: menu selection: action color: aColor thumbnail: aForm
  "Add menu item representing the sender to a menu"
+ "Removed setting the color - it wasn't working well with dark color themes."
 
  menu
  add: item
  selector: #jumpToSelection:
  argument: action.
- menu lastItem color: aColor.
  aForm isNil
  ifFalse: [menu lastItem
  icon: (aForm
  scaledIntoFormOfSize: (Preferences tinyDisplay
  ifTrue: [16]
  ifFalse: [28]))]!


cbc
Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-cbc.1451.mcz

cbc
This one had been bugging me for a bit.
Before fix:

After the fix: 

The method changed was only ever called to build this menu.  The sub-menu 'New Project' above this one was readable before - and after.
-cbc

On Tue, Jun 12, 2018 at 10:20 PM, <[hidden email]> wrote:
Chris Cunningham uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cbc.1451.mcz

==================== Summary ====================

Name: Morphic-cbc.1451
Author: cbc
Time: 12 June 2018, 10:20:33.204594 pm
UUID: eeba2c6d-1d3b-8c4f-9798-2d5f590eb318
Ancestors: Morphic-cbc.1450

Fix so that Projects>Jump To Project submenu is readable in dark color themes (by commenting out setting of the color - default works much better).

=============== Diff against Morphic-cbc.1450 ===============

Item was changed:
  ----- Method: MorphicProject>>addItem:toMenu:selection:color:thumbnail: (in category 'utilities') -----
  addItem: item toMenu: menu selection: action color: aColor thumbnail: aForm
        "Add menu item representing the sender to a menu"
+       "Removed setting the color - it wasn't working well with dark color themes."

        menu
                add: item
                selector: #jumpToSelection:
                argument: action.
-       menu lastItem color: aColor.
        aForm isNil
                ifFalse: [menu lastItem
                                icon: (aForm
                                                scaledIntoFormOfSize: (Preferences tinyDisplay
                                                                ifTrue: [16]
                                                                ifFalse: [28]))]!