Smalltalk › Squeak › Squeak - Dev

The Trunk: Morphic-cbc.1664.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

commits-2

The Trunk: Morphic-cbc.1664.mcz

Chris Cunningham uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cbc.1664.mcz

==================== Summary ====================

Name: Morphic-cbc.1664
Author: cbc
Time: 5 June 2020, 8:31:07.419315 am
UUID: bf356d19-6ce6-6f4f-8c68-5f973a0c9f0c
Ancestors: Morphic-mt.1632, Morphic-mt.1663

locked messageMorph in DialogWindow so that the morph can once again be controlled by keystrokes.

=============== Diff against Morphic-mt.1663 ===============

Item was changed:
----- Method: DialogWindow>>createMessage: (in category 'initialization') -----
createMessage: aString

messageMorph := aString asText asMorph.
messageMorph
name: 'Message';
readOnly: true;
+ setProperty: #indicateKeyboardFocus toValue: #never;
+ lock.
- setProperty: #indicateKeyboardFocus toValue: #never.
self setMessageParameters.
^ messageMorph!

marcel.taeumel

Re: The Trunk: Morphic-cbc.1664.mcz

Hi there!

...and the text of larger dialogs can once again not be selected, copied, and interacted with anymore. Think of clickable text URLs.

Maybe we find a better solution. :-)

#lock is generic in Morphic to reject all events

#readOnly: is specific to text fields to not mess up its contents

Something like #rejectsKeyboardFocus .... along the line of #keyboardFocusDelegate...

Note that this is not a -1. Its okay that you -- kind of -- reverted my recent change to DialogMorph where I made text contents more accessible. There was another issue with message-category creation and the keyboard-focus interfering...

We will find something.

Best,

Marcel

Am 05.06.2020 17:31:30 schrieb [hidden email] <[hidden email]>:
Chris Cunningham uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cbc.1664.mcz

==================== Summary ====================

Name: Morphic-cbc.1664
Author: cbc
Time: 5 June 2020, 8:31:07.419315 am
UUID: bf356d19-6ce6-6f4f-8c68-5f973a0c9f0c
Ancestors: Morphic-mt.1632, Morphic-mt.1663

locked messageMorph in DialogWindow so that the morph can once again be controlled by keystrokes.

=============== Diff against Morphic-mt.1663 ===============

Item was changed:
----- Method: DialogWindow>>createMessage: (in category 'initialization') -----
createMessage: aString

messageMorph := aString asText asMorph.
messageMorph
name: 'Message';
readOnly: true;
+ setProperty: #indicateKeyboardFocus toValue: #never;
+ lock.
- setProperty: #indicateKeyboardFocus toValue: #never.
self setMessageParameters.
^ messageMorph!

cbc

Re: The Trunk: Morphic-cbc.1664.mcz

Hmm. Which context are you wanting to select/copy/interact with the dialog contents?

I do see the clickable URLs - those I definitely want (awesome), but not at the expense of killing other ingrained interactions.

Maybe another approach is to create a specific 'interactionable' dialog and other non-interactionable. Or move several of the existing users of the this class to a newer class?

The context where this finally drove me over the edge was when creating new categories, I'd type in and partially select an existing category, hit entry, then couldn't actually select a confirmation choice except by mouse - no keyboard shortcuts allowed.

Alternatively, maybe a #keyboardLocked method?

-cbc

On Fri, Jun 5, 2020 at 8:41 AM Marcel Taeumel <[hidden email]> wrote:

Hi there!

...and the text of larger dialogs can once again not be selected, copied, and interacted with anymore. Think of clickable text URLs.

Maybe we find a better solution. :-)

#lock is generic in Morphic to reject all events
#readOnly: is specific to text fields to not mess up its contents

Something like #rejectsKeyboardFocus .... along the line of #keyboardFocusDelegate...

Note that this is not a -1. Its okay that you -- kind of -- reverted my recent change to DialogMorph where I made text contents more accessible. There was another issue with message-category creation and the keyboard-focus interfering...

We will find something.

Best,
Marcel

Am 05.06.2020 17:31:30 schrieb [hidden email] <[hidden email]>:
Chris Cunningham uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cbc.1664.mcz

==================== Summary ====================

Name: Morphic-cbc.1664
Author: cbc
Time: 5 June 2020, 8:31:07.419315 am
UUID: bf356d19-6ce6-6f4f-8c68-5f973a0c9f0c
Ancestors: Morphic-mt.1632, Morphic-mt.1663

locked messageMorph in DialogWindow so that the morph can once again be controlled by keystrokes.

=============== Diff against Morphic-mt.1663 ===============

Item was changed:
----- Method: DialogWindow>>createMessage: (in category 'initialization') -----
createMessage: aString

messageMorph := aString asText asMorph.
messageMorph
name: 'Message';
readOnly: true;
+ setProperty: #indicateKeyboardFocus toValue: #never;
+ lock.
- setProperty: #indicateKeyboardFocus toValue: #never.
self setMessageParameters.
^ messageMorph!

Christoph Thiede

Re: The Trunk: Morphic-cbc.1664.mcz

Hi Chris,

> Which context are you wanting to select/copy/interact with the dialog contents?

just update your image, or to manually trigger that message, do:

self inform: (MCMcmUpdater new updateMessageFor: 0).

I love this feature and would not like to miss it again in arbitrary dialog windows.

Indeed I can also imagine keyboard control for selecting within the message would be a nice feature. However, I was confused by Enter not any longer closing the dialog, too.

Could we kind of override #mouseOverForKeyboardFocus in this text morph? Then you would need to click into the text once before you can press <cmd>a, for example, to select the whole message.

We would only need to add such a hook to PluggableTextMorph and add it to the ToolBuilder protocol.

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Chris Cunningham <[hidden email]>
Gesendet: Freitag, 5. Juni 2020 18:28 Uhr
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] The Trunk: Morphic-cbc.1664.mcz

Hmm. Which context are you wanting to select/copy/interact with the dialog contents?

I do see the clickable URLs - those I definitely want (awesome), but not at the expense of killing other ingrained interactions.

Maybe another approach is to create a specific 'interactionable' dialog and other non-interactionable. Or move several of the existing users of the this class to a newer class?

Alternatively, maybe a #keyboardLocked method?

-cbc

On Fri, Jun 5, 2020 at 8:41 AM Marcel Taeumel <[hidden email]> wrote:

Hi there!

...and the text of larger dialogs can once again not be selected, copied, and interacted with anymore. Think of clickable text URLs.

Maybe we find a better solution. :-)

#lock is generic in Morphic to reject all events

#readOnly: is specific to text fields to not mess up its contents

Something like #rejectsKeyboardFocus .... along the line of #keyboardFocusDelegate...

Note that this is not a -1. Its okay that you -- kind of -- reverted my recent change to DialogMorph where I made text contents more accessible. There was another issue with message-category creation and the keyboard-focus interfering...

We will find something.

Best,

Marcel

Am 05.06.2020 17:31:30 schrieb [hidden email] <[hidden email]>:

Chris Cunningham uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cbc.1664.mcz

==================== Summary ====================

Name: Morphic-cbc.1664
Author: cbc
Time: 5 June 2020, 8:31:07.419315 am
UUID: bf356d19-6ce6-6f4f-8c68-5f973a0c9f0c
Ancestors: Morphic-mt.1632, Morphic-mt.1663

locked messageMorph in DialogWindow so that the morph can once again be controlled by keystrokes.

=============== Diff against Morphic-mt.1663 ===============

Item was changed:
----- Method: DialogWindow>>createMessage: (in category 'initialization') -----
createMessage: aString

messageMorph := aString asText asMorph.
messageMorph
name: 'Message';
readOnly: true;
+ setProperty: #indicateKeyboardFocus toValue: #never;
+ lock.
- setProperty: #indicateKeyboardFocus toValue: #never.
self setMessageParameters.
^ messageMorph!

Carpe Squeak!

marcel.taeumel

Re: The Trunk: Morphic-cbc.1664.mcz

In reply to this post by cbc

>Which context are you wanting to select/copy/interact with the dialog contents?

Best,

Marcel

Am 05.06.2020 18:28:51 schrieb Chris Cunningham <[hidden email]>:

Hmm. Which context are you wanting to select/copy/interact with the dialog contents?

I do see the clickable URLs - those I definitely want (awesome), but not at the expense of killing other ingrained interactions.

Maybe another approach is to create a specific 'interactionable' dialog and other non-interactionable. Or move several of the existing users of the this class to a newer class?

The context where this finally drove me over the edge was when creating new categories, I'd type in and partially select an existing category, hit entry, then couldn't actually select a confirmation choice except by mouse - no keyboard shortcuts allowed.

Alternatively, maybe a #keyboardLocked method?

-cbc

On Fri, Jun 5, 2020 at 8:41 AM Marcel Taeumel <[hidden email]> wrote:
Hi there!

...and the text of larger dialogs can once again not be selected, copied, and interacted with anymore. Think of clickable text URLs.

Maybe we find a better solution. :-)

#lock is generic in Morphic to reject all events
#readOnly: is specific to text fields to not mess up its contents

Something like #rejectsKeyboardFocus .... along the line of #keyboardFocusDelegate...

Note that this is not a -1. Its okay that you -- kind of -- reverted my recent change to DialogMorph where I made text contents more accessible. There was another issue with message-category creation and the keyboard-focus interfering...

We will find something.

Best,
Marcel

Am 05.06.2020 17:31:30 schrieb [hidden email] <[hidden email]>:
Chris Cunningham uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cbc.1664.mcz

==================== Summary ====================

Name: Morphic-cbc.1664
Author: cbc
Time: 5 June 2020, 8:31:07.419315 am
UUID: bf356d19-6ce6-6f4f-8c68-5f973a0c9f0c
Ancestors: Morphic-mt.1632, Morphic-mt.1663

locked messageMorph in DialogWindow so that the morph can once again be controlled by keystrokes.

=============== Diff against Morphic-mt.1663 ===============

Item was changed:
----- Method: DialogWindow>>createMessage: (in category 'initialization') -----
createMessage: aString

messageMorph := aString asText asMorph.
messageMorph
name: 'Message';
readOnly: true;
+ setProperty: #indicateKeyboardFocus toValue: #never;
+ lock.
- setProperty: #indicateKeyboardFocus toValue: #never.
self setMessageParameters.
^ messageMorph!