The Trunk: Morphic-cmm.756.mcz
Locked
 
|
Chris Muller uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cmm.756.mcz ==================== Summary ==================== Name: Morphic-cmm.756 Author: cmm Time: 1 February 2015, 1:06:11.045 pm UUID: c1553853-472d-45ca-a182-c07497c6f7a9 Ancestors: Morphic-cmm.755 - Present the comparison to clipboard text from the context of paste-modification, since that is what the user is determining whether to do with the clipboard contents. - Make the same change to ParagraphEditor, for consistency. =============== Diff against Morphic-cmm.755 =============== Item was changed: ----- Method: TextEditor>>compareToClipboard (in category 'menu messages') ----- compareToClipboard + "If any text is selected, present the modifications that would be made to it if the clipboard contents were pasted over it. If no text is selected, present the differences betwen the entire pane's contents and the clipboard text." + | subjectText proposedText | + subjectText := self selection string ifEmpty: [ paragraph text string ]. + proposedText := self clipboardText string. + subjectText = proposedText ifTrue: [^ self inform: 'Exact match']. + (StringHolder new + textContents: + (TextDiffBuilder + buildDisplayPatchFrom: subjectText + to: proposedText)) openLabel: 'Differences with Clipboard Text'! - "Check to see if whether the receiver's text is the same as the text currently on the clipboard, and inform the user." - | s1 s2 | - s1 := self clipboardText string. - s2 := self selection string. - s1 = s2 ifTrue: [^ self inform: 'Exact match']. - - (StringHolder new textContents: - (TextDiffBuilder buildDisplayPatchFrom: s1 to: s2)) - openLabel: 'Comparison to Clipboard Text'! |
Re: The Trunk: Morphic-cmm.756.mcz
|
|
ParagraphEditor is in ST-80, so not part of this package. Speaking of
that, is a corresponding change to ParagraphEditor necessary? Is ParagraphEditor intended to be purged at some point? On Sun, Feb 1, 2015 at 1:06 PM, <[hidden email]> wrote: > Chris Muller uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-cmm.756.mcz > > ==================== Summary ==================== > > Name: Morphic-cmm.756 > Author: cmm > Time: 1 February 2015, 1:06:11.045 pm > UUID: c1553853-472d-45ca-a182-c07497c6f7a9 > Ancestors: Morphic-cmm.755 > > - Present the comparison to clipboard text from the context of paste-modification, since that is what the user is determining whether to do with the clipboard contents. > - Make the same change to ParagraphEditor, for consistency. > > =============== Diff against Morphic-cmm.755 =============== > > Item was changed: > ----- Method: TextEditor>>compareToClipboard (in category 'menu messages') ----- > compareToClipboard > + "If any text is selected, present the modifications that would be made to it if the clipboard contents were pasted over it. If no text is selected, present the differences betwen the entire pane's contents and the clipboard text." > + | subjectText proposedText | > + subjectText := self selection string ifEmpty: [ paragraph text string ]. > + proposedText := self clipboardText string. > + subjectText = proposedText ifTrue: [^ self inform: 'Exact match']. > + (StringHolder new > + textContents: > + (TextDiffBuilder > + buildDisplayPatchFrom: subjectText > + to: proposedText)) openLabel: 'Differences with Clipboard Text'! > - "Check to see if whether the receiver's text is the same as the text currently on the clipboard, and inform the user." > - | s1 s2 | > - s1 := self clipboardText string. > - s2 := self selection string. > - s1 = s2 ifTrue: [^ self inform: 'Exact match']. > - > - (StringHolder new textContents: > - (TextDiffBuilder buildDisplayPatchFrom: s1 to: s2)) > - openLabel: 'Comparison to Clipboard Text'! > > |
Re: The Trunk: Morphic-cmm.756.mcz
|
|
On Sun, Feb 1, 2015 at 1:05 PM, Chris Muller <[hidden email]> wrote: ParagraphEditor is in ST-80, so not part of this package. Speaking of Not necessarily. People use it as a way of reducing footprint. Whether we can afford to keep it going long term is debatable but so far people like David Lewis have done a good job of keeping it working. So by all means fix compare to clipboard therein.
best,
Eliot |
Re: The Trunk: Morphic-cmm.756.mcz
|
|
On Sun, Feb 01, 2015 at 05:57:40PM -0800, Eliot Miranda wrote:
> On Sun, Feb 1, 2015 at 1:05 PM, Chris Muller <[hidden email]> wrote: > > > ParagraphEditor is in ST-80, so not part of this package. Speaking of > > that, is a corresponding change to ParagraphEditor necessary? Is > > ParagraphEditor intended to be purged at some point? > > > > Not necessarily. People use it as a way of reducing footprint. Whether we > can afford to keep it going long term is debatable but so far people like > David Lewis have done a good job of keeping it working. So by all means > fix compare to clipboard therein. > +1 There are several reasons why this matters. 1) If you care about modularity, then you should care about packages that are unloadable and reloadable. MVC (the ST-80 package) is (or was? hopefully this is still true) fully reloadable. ParagraphEditor is a key part of the MVC environment, so if you want it to go away, you should just unload MVC. Morphic needs to be made reloadable also, but that has not happened yet. 2) If you care about making Morphic modular, either in the sense that it might become unloadable and reloadable, or in the sense that it might be replaced by something better (Morphic 3, or maybe something entirely different), then it is important to know where the boundaries of the Morphic package and behaviors lie. That is critical to the ToolBuilder, UIManager, and Project architecture. For better or for worse, we have only two working implementations of that architecture right now, so I think that it is important to keep both Morphic and MVC in good working order if we are to have any chance of knowing and maintaining the boundaries. 3) If you were interested in light weight images that might run on very large numbers of processors, then it would be convenient to have a small but usable UI environment available for those images. In that case, you might want to unload Morphic and everything that goes with it. You might then be happy to have a working MVC at hand, and of course you would want ParagraphEditor to work also. Dave |
«
Return to Squeak - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |