The Trunk: Morphic-dtl.1459.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-dtl.1459.mcz

commits-2
David T. Lewis uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-dtl.1459.mcz

==================== Summary ====================

Name: Morphic-dtl.1459
Author: dtl
Time: 2 July 2018, 9:13:27.506225 pm
UUID: dea580bf-a9ac-401c-88b9-c9dd2b7eb101
Ancestors: Morphic-cmm.1458

Morph>>openNearMorph should open in a world. If the nearby morph does not know its world and self does not know either, then fall back on Project current world as a sensible place to be opened.

This fixes the first of possibly several bugs identified in the test case described at GenericPropertiesMorph allSubInstances. The remaining bug(s) involve Etoys integration. The #thingsToRevert in GenericPropertiesMorph is expected to be a Dictionary, but subclass TextPropertiesMorph from Etoys makes it an OrderedCollection of associations. The (earlier) Dictionary implementation appears correct, so the TextPropertiesmorph>>initialize from Etoys-Experimental should probably be changed to match the earlier implementation.

=============== Diff against Morphic-cmm.1458 ===============

Item was changed:
  ----- Method: Morph>>openNearMorph: (in category 'initialization') -----
  openNearMorph: aMorph
  self
  openNear: aMorph boundsInWorld
+ in: (aMorph world
+ ifNil: [self world
+ ifNil: [Project current world]])!
- in: (aMorph world ifNil: [ self world ])!