Smalltalk › Squeak › Squeak - Dev

The Trunk: Morphic-dtl.1459.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Trunk: Morphic-dtl.1459.mcz

David T. Lewis uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-dtl.1459.mcz

==================== Summary ====================

Name: Morphic-dtl.1459
Author: dtl
Time: 2 July 2018, 9:22:17.292098 pm
UUID: ec5201c6-26aa-452d-b447-36fe3e0721fb
Ancestors: Morphic-cmm.1458

Morph>>openNearMorph should open in a world. If the nearby morph does not know its world and self does not know either, then fall back on Project current world as a sensible place to be opened.

This fixes the first of possibly several bugs identified in the test case described at http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-July/199422.html. The remaining bug(s) involve Etoys integration. The #thingsToRevert in GenericPropertiesMorph is expected to be a Dictionary, but subclass TextPropertiesMorph from Etoys makes it an OrderedCollection of associations. The (earlier) Dictionary implementation appears correct, so the TextPropertiesmorph>>initialize from Etoys-Experimental should probably be changed to match the earlier implementation.

=============== Diff against Morphic-cmm.1458 ===============

Item was changed:
----- Method: Morph>>openNearMorph: (in category 'initialization') -----
openNearMorph: aMorph
self
openNear: aMorph boundsInWorld
+ in: (aMorph world
+ ifNil: [self world
+ ifNil: [Project current world]])!
- in: (aMorph world ifNil: [ self world ])!

David T. Lewis

Re: The Trunk: Morphic-dtl.1459.mcz

Sorry for the duplicate commit, this is to correct a cut and paste error in the commit comment.

Dave

On Tue, Jul 03, 2018 at 01:22:41AM +0000, [hidden email] wrote:

> David T. Lewis uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-dtl.1459.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-dtl.1459
> Author: dtl
> Time: 2 July 2018, 9:22:17.292098 pm
> UUID: ec5201c6-26aa-452d-b447-36fe3e0721fb
> Ancestors: Morphic-cmm.1458
>
> Morph>>openNearMorph should open in a world. If the nearby morph does not know its world and self does not know either, then fall back on Project current world as a sensible place to be opened.
>
> This fixes the first of possibly several bugs identified in the test case described at http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-July/199422.html. The remaining bug(s) involve Etoys integration. The #thingsToRevert in GenericPropertiesMorph is expected to be a Dictionary, but subclass TextPropertiesMorph from Etoys makes it an OrderedCollection of associations. The (earlier) Dictionary implementation appears correct, so the TextPropertiesmorph>>initialize from Etoys-Experimental should probably be changed to match the earlier implementation.
>
> =============== Diff against Morphic-cmm.1458 ===============
>
> Item was changed:
> ----- Method: Morph>>openNearMorph: (in category 'initialization') -----
> openNearMorph: aMorph
> self
> openNear: aMorph boundsInWorld
> + in: (aMorph world
> + ifNil: [self world
> + ifNil: [Project current world]])!
> - in: (aMorph world ifNil: [ self world ])!
>
>