The Trunk: Morphic-kfr.930.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-kfr.930.mcz

commits-2
Karl Ramberg uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-kfr.930.mcz

==================== Summary ====================

Name: Morphic-kfr.930
Author: kfr
Time: 26 April 2015, 7:56:20.732 am
UUID: 719010c7-4822-d540-842d-0091f1df654d
Ancestors: Morphic-kfr.929

Added a missing semicolon

=============== Diff against Morphic-kfr.929 ===============

Item was changed:
  ----- Method: LayoutProperties>>stringWithLayout (in category 'table defaults') -----
  stringWithLayout
  | defaultValues uniqueValues |
  defaultValues := TableLayoutProperties new.
  uniqueValues := self class allInstVarNames
  select: [:title | (self instVarNamed: title)
  ~= (defaultValues instVarNamed: title)].
  ^ String
  streamContents: [:aStream |
+ aStream nextPutAll: 'TableLayout new; '.
- aStream nextPutAll: 'TableLayout new '.
  uniqueValues
  do: [:title | aStream nextPutAll: title;
  nextPut: $:;
  space;
 
  print: (self instVarNamed: title).
  (title = uniqueValues last)
  ifTrue:[ aStream nextPut:$.]
  ifFalse:[ aStream nextPut: $;; cr]
  ]]!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-kfr.930.mcz

Tobias Pape
Hey Karl

On 26.04.2015, at 05:56, [hidden email] wrote:

> Karl Ramberg uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-kfr.930.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-kfr.930
> Author: kfr
> Time: 26 April 2015, 7:56:20.732 am
> UUID: 719010c7-4822-d540-842d-0091f1df654d
> Ancestors: Morphic-kfr.929
>
> Added a missing semicolon
>
> =============== Diff against Morphic-kfr.929 ===============
>
> Item was changed:
> ----- Method: LayoutProperties>>stringWithLayout (in category 'table defaults') -----
> stringWithLayout
> | defaultValues uniqueValues |
> defaultValues := TableLayoutProperties new.
> uniqueValues := self class allInstVarNames
> select: [:title | (self instVarNamed: title)
> ~= (defaultValues instVarNamed: title)].
> ^ String
> streamContents: [:aStream |
> + aStream nextPutAll: 'TableLayout new; '.
> - aStream nextPutAll: 'TableLayout new '.

can you explain why this is necessary?
Why should subsequent messages go to the class instead of the instance?

Best regards
        -Tobias


> uniqueValues
> do: [:title | aStream nextPutAll: title;
> nextPut: $:;
> space;
>
> print: (self instVarNamed: title).
> (title = uniqueValues last)
> ifTrue:[ aStream nextPut:$.]
> ifFalse:[ aStream nextPut: $;; cr]
> ]]!
>
>


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-kfr.930.mcz

Karl Ramberg
I got confused, too.

But it's reason is that it's a cascade sent to a morph, not to TableLayout, like this:

aMorph layoutPolicy: TableLayout new;
 listDirection: #leftToRight;
 wrapCentering: #topLeft;
 hResizing: #shrinkWrap;
 vResizing: #shrinkWrap;
 layoutInset: 2;
 rubberBandCells: true

Karl


On Sun, Apr 26, 2015 at 2:29 PM, Tobias Pape <[hidden email]> wrote:
Hey Karl

On 26.04.2015, at 05:56, [hidden email] wrote:

> Karl Ramberg uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-kfr.930.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-kfr.930
> Author: kfr
> Time: 26 April 2015, 7:56:20.732 am
> UUID: 719010c7-4822-d540-842d-0091f1df654d
> Ancestors: Morphic-kfr.929
>
> Added a missing semicolon
>
> =============== Diff against Morphic-kfr.929 ===============
>
> Item was changed:
> ----- Method: LayoutProperties>>stringWithLayout (in category 'table defaults') -----
> stringWithLayout
>       | defaultValues uniqueValues |
>       defaultValues := TableLayoutProperties new.
>       uniqueValues := self class allInstVarNames
>               select: [:title | (self instVarNamed: title)
>                                       ~= (defaultValues instVarNamed: title)].
>       ^ String
>               streamContents: [:aStream |
> +                     aStream nextPutAll: 'TableLayout new; '.
> -                     aStream nextPutAll: 'TableLayout new '.

can you explain why this is necessary?
Why should subsequent messages go to the class instead of the instance?

Best regards
        -Tobias


>                       uniqueValues
>                               do: [:title | aStream nextPutAll: title;
>                                                nextPut: $:;
>                                                space;
>
>                                               print: (self instVarNamed: title).
>                                               (title = uniqueValues last)
>                                               ifTrue:[ aStream nextPut:$.]
>                                               ifFalse:[ aStream nextPut: $;; cr]
>                                               ]]!
>
>





Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-kfr.930.mcz

Tobias Pape
On 26.04.2015, at 14:39, karl ramberg <[hidden email]> wrote:

> I got confused, too.
>
> But it's reason is that it's a cascade sent to a morph, not to TableLayout, like this:
>
> aMorph layoutPolicy: TableLayout new;
>  listDirection: #leftToRight;
>  wrapCentering: #topLeft;
>  hResizing: #shrinkWrap;
>  vResizing: #shrinkWrap;
>  layoutInset: 2;
>  rubberBandCells: true
>

Thanks for the clarification!
Makes perfectly sense :D

Best regards
        -Tobias

> Karl
>
>
> On Sun, Apr 26, 2015 at 2:29 PM, Tobias Pape <[hidden email]> wrote:
> Hey Karl
>
> On 26.04.2015, at 05:56, [hidden email] wrote:
>
> > Karl Ramberg uploaded a new version of Morphic to project The Trunk:
> > http://source.squeak.org/trunk/Morphic-kfr.930.mcz
> >
> > ==================== Summary ====================
> >
> > Name: Morphic-kfr.930
> > Author: kfr
> > Time: 26 April 2015, 7:56:20.732 am
> > UUID: 719010c7-4822-d540-842d-0091f1df654d
> > Ancestors: Morphic-kfr.929
> >
> > Added a missing semicolon
> >
> > =============== Diff against Morphic-kfr.929 ===============
> >
> > Item was changed: