The Trunk: Morphic-laza.389.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-laza.389.mcz

commits-2
Alexander Lazarević uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-laza.389.mcz

==================== Summary ====================

Name: Morphic-laza.389
Author: laza
Time: 25 March 2010, 3:55:38.504 pm
UUID: 2559029d-daab-4085-b080-eb9f63f493de
Ancestors: Morphic-ar.388

make inactive Window buttons dimmed

=============== Diff against Morphic-ar.388 ===============

Item was added:
+ ----- Method: SystemWindowButton>>unlock (in category 'accessing') -----
+ unlock
+ self restoreImage.
+ super unlock!

Item was added:
+ ----- Method: SystemWindowButton>>lock (in category 'accessing') -----
+ lock
+ self passivate.
+ super lock!

Item was changed:
  ----- Method: SystemWindow>>passivate (in category 'top window') -----
  passivate
  "Make me unable to respond to mouse and keyboard"
 
  label ifNotNil: [label color: Color darkGray].
  self setStripeColorsFrom: self paneColorToUse.
  model modelSleep.
 
- "Control boxes remain active, except in novice mode"
  self submorphsDo: [:m |
  m == labelArea ifFalse:
  [m lock]].
+
+ "Control boxes remain active, except in novice mode"
+ labelArea
+ ifNotNil: [
+ labelArea submorphsDo: [:m |
+ (Preferences noviceMode not and: [m == closeBox or: [m == collapseBox]]) ifFalse: [m lock]]]
- labelArea ifNotNil:
- [labelArea submorphsDo: [:m |
- m == label
- ifTrue: [m lock]
- ifFalse: [
- Preferences noviceMode
- ifTrue: [m lock; hide]
- ifFalse: [
- (m == closeBox or: [m == collapseBox])
- ifFalse: [m lock; hide]]]]]
  ifNil: "i.e. label area is nil, so we're titleless"
  [self adjustBorderUponDeactivationWhenLabeless].
  !

Item was added:
+ ----- Method: SystemWindowButton>>passivate (in category 'visual properties') -----
+ passivate
+
+ self firstSubmorph form: (self firstSubmorph form dimmed)
+ !


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-laza.389.mcz

Chris Muller-3
Why should the window buttons be dimmed just because the window is not
the one with keyboard focus?  Normally, buttons are dimmed when the
buttons _themselves_ are not active, which is not always the case with
window buttons sticking out of background windows..

On Thu, Mar 25, 2010 at 9:56 AM,  <[hidden email]> wrote:

> Alexander Lazarevi&#263; uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-laza.389.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-laza.389
> Author: laza
> Time: 25 March 2010, 3:55:38.504 pm
> UUID: 2559029d-daab-4085-b080-eb9f63f493de
> Ancestors: Morphic-ar.388
>
> make inactive Window buttons dimmed
>
> =============== Diff against Morphic-ar.388 ===============
>
> Item was added:
> + ----- Method: SystemWindowButton>>unlock (in category 'accessing') -----
> + unlock
> +       self restoreImage.
> +       super unlock!
>
> Item was added:
> + ----- Method: SystemWindowButton>>lock (in category 'accessing') -----
> + lock
> +       self passivate.
> +       super lock!
>
> Item was changed:
>  ----- Method: SystemWindow>>passivate (in category 'top window') -----
>  passivate
>        "Make me unable to respond to mouse and keyboard"
>
>        label ifNotNil: [label color: Color darkGray].
>        self setStripeColorsFrom: self paneColorToUse.
>        model modelSleep.
>
> -       "Control boxes remain active, except in novice mode"
>        self submorphsDo: [:m |
>                m == labelArea ifFalse:
>                        [m lock]].
> +
> +       "Control boxes remain active, except in novice mode"
> +       labelArea
> +               ifNotNil: [
> +                       labelArea submorphsDo: [:m |
> +                               (Preferences noviceMode not and: [m == closeBox or: [m == collapseBox]]) ifFalse: [m lock]]]
> -       labelArea ifNotNil:
> -               [labelArea submorphsDo: [:m |
> -                       m == label
> -                               ifTrue: [m lock]
> -                               ifFalse: [
> -                                       Preferences noviceMode
> -                                               ifTrue: [m lock; hide]
> -                                               ifFalse: [
> -                                                       (m == closeBox or: [m == collapseBox])
> -                                                               ifFalse: [m lock; hide]]]]]
>                ifNil: "i.e. label area is nil, so we're titleless"
>                        [self adjustBorderUponDeactivationWhenLabeless].
>  !
>
> Item was added:
> + ----- Method: SystemWindowButton>>passivate (in category 'visual properties') -----
> + passivate
> +
> +       self firstSubmorph form: (self firstSubmorph form dimmed)
> + !
>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-laza.389.mcz

Bert Freudenberg
On 26.03.2010, at 00:05, Chris Muller wrote:
>
> Why should the window buttons be dimmed just because the window is not
> the one with keyboard focus?

So they do not stand out. The colored buttons are distractingly attention-grabbing, IMHO.

>  Normally, buttons are dimmed when the
> buttons _themselves_ are not active, which is not always the case with
> window buttons sticking out of background windows..

True, but they don't look like normal buttons either, so this is fine, IMHO. Also, since window buttons are ubiquitous, you learn their specialties really fast.

I just committed this - like it?

- Bert -


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-laza.389.mcz

Bert Freudenberg
On 26.03.2010, at 11:14, Bert Freudenberg wrote:

>
> On 26.03.2010, at 00:05, Chris Muller wrote:
>>
>> Why should the window buttons be dimmed just because the window is not
>> the one with keyboard focus?
>
> So they do not stand out. The colored buttons are distractingly attention-grabbing, IMHO.
>
>> Normally, buttons are dimmed when the
>> buttons _themselves_ are not active, which is not always the case with
>> window buttons sticking out of background windows..
>
> True, but they don't look like normal buttons either, so this is fine, IMHO. Also, since window buttons are ubiquitous, you learn their specialties really fast.
>
> I just committed this - like it?
>
> - Bert -

Ah, looks like you have to

        SystemWindow rebuildAllWindowLabels

for the changes to affect old windows. Should I have put that in a postscript? How did you guys do it earlier?

- Bert -



Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-laza.389.mcz

Josh Gargus
In reply to this post by Bert Freudenberg

On Mar 26, 2010, at 3:14 AM, Bert Freudenberg wrote:

> On 26.03.2010, at 00:05, Chris Muller wrote:
>>
>> Why should the window buttons be dimmed just because the window is not
>> the one with keyboard focus?
>
> So they do not stand out. The colored buttons are distractingly attention-grabbing, IMHO.
>
>> Normally, buttons are dimmed when the
>> buttons _themselves_ are not active, which is not always the case with
>> window buttons sticking out of background windows..
>
> True, but they don't look like normal buttons either, so this is fine, IMHO. Also, since window buttons are ubiquitous, you learn their specialties really fast.
>
> I just committed this - like it?

Just right!

Thanks,
Josh



>
> - Bert -
>
>


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-laza.389.mcz

Bert Freudenberg
On 26.03.2010, at 19:00, Josh Gargus wrote:

>
>
> On Mar 26, 2010, at 3:14 AM, Bert Freudenberg wrote:
>
>> On 26.03.2010, at 00:05, Chris Muller wrote:
>>>
>>> Why should the window buttons be dimmed just because the window is not
>>> the one with keyboard focus?
>>
>> So they do not stand out. The colored buttons are distractingly attention-grabbing, IMHO.
>>
>>> Normally, buttons are dimmed when the
>>> buttons _themselves_ are not active, which is not always the case with
>>> window buttons sticking out of background windows..
>>
>> True, but they don't look like normal buttons either, so this is fine, IMHO. Also, since window buttons are ubiquitous, you learn their specialties really fast.
>>
>> I just committed this - like it?
>
> Just right!
>
> Thanks,
> Josh

Do we have an idea how to fix the look in screen depth less than 32 bits?

- Bert -