The Trunk: Morphic-laza.416.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-laza.416.mcz

commits-2
Alexander Lazarević uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-laza.416.mcz

==================== Summary ====================

Name: Morphic-laza.416
Author: laza
Time: 7 April 2010, 7:26:46.998 pm
UUID: 0c8d2ad9-0e86-4599-81b5-9a570a7e2170
Ancestors: Morphic-tbn.414

The initialization was missing from some earlier commit

=============== Diff against Morphic-tbn.414 ===============

Item was changed:
+ (PackageInfo named: 'Morphic') postscript: 'SystemProgressMorph initialize; reset'!
- (PackageInfo named: 'Morphic') postscript: '"below, add code to be run after the loading of this package"
- MenuMorph initialize.
- Preferences setPreference: #roundedMenuCorners toValue: true.
- TheWorldMainDockingBar updateInstances
- '!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-laza.416.mcz

Levente Uzonyi-2
On Wed, 7 Apr 2010, [hidden email] wrote:

> Alexander Lazarević uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-laza.416.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-laza.416
> Author: laza
> Time: 7 April 2010, 7:26:46.998 pm
> UUID: 0c8d2ad9-0e86-4599-81b5-9a570a7e2170
> Ancestors: Morphic-tbn.414
>
> The initialization was missing from some earlier commit

We should be more careful with preambles and postscripts. Updating from
9885 to 9917 didn't evaluate [TheWorldMainDockingBar updateInstances],
leaving the Search Bar broken. I created a new mcm to ensure that
the postscript is evaluated before this change.


Levente

>
> =============== Diff against Morphic-tbn.414 ===============
>
> Item was changed:
> + (PackageInfo named: 'Morphic') postscript: 'SystemProgressMorph initialize; reset'!
> - (PackageInfo named: 'Morphic') postscript: '"below, add code to be run after the loading of this package"
> - MenuMorph initialize.
> - Preferences setPreference: #roundedMenuCorners toValue: true.
> - TheWorldMainDockingBar updateInstances
> - '!
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-laza.416.mcz

laza
2010/4/8 Levente Uzonyi <[hidden email]>
We should be more careful with preambles and postscripts. Updating from 9885 to 9917 didn't evaluate [TheWorldMainDockingBar updateInstances], leaving the Search Bar broken.

So I accidentally removed my fix for that to leave it in the original state no had complains before, right? ;) 
 
I created a new mcm to ensure that the postscript is evaluated before this change.

Thanks Levente. I keep on forgetting the need for mcm 

Alex