Smalltalk › Squeak › Squeak - Dev

The Trunk: Morphic-laza.430.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

commits-2

The Trunk: Morphic-laza.430.mcz

Alexander Lazarević uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-laza.430.mcz

==================== Summary ====================

Name: Morphic-laza.430
Author: laza
Time: 26 April 2010, 12:25:16.993 pm
UUID: 6362395c-21df-0d4a-a187-99a03416c76c
Ancestors: Morphic-laza.429

Add Seaside 2.8, 2.8 Examples and 3.0 to the "How to extend the system" workspace

=============== Diff against Morphic-laza.429 ===============

Item was changed:
(excessive method size, no diff calculated)

Hannes Hirzel

Re: The Trunk: Morphic-laza.430.mcz

Thanks, this is great. I just wanted to do it this morning and you were faster!

--Hannes

On Mon, 26 Apr 2010 10:25:52.659 0000, [hidden email]
<[hidden email]> wrote:

> Alexander Lazarević uploaded a new version of Morphic to project The
> Trunk:
> http://source.squeak.org/trunk/Morphic-laza.430.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-laza.430
> Author: laza
> Time: 26 April 2010, 12:25:16.993 pm
> UUID: 6362395c-21df-0d4a-a187-99a03416c76c
> Ancestors: Morphic-laza.429
>
> Add Seaside 2.8, 2.8 Examples and 3.0 to the "How to extend the system"
> workspace
>
> =============== Diff against Morphic-laza.429 ===============
>
> Item was changed:
> (excessive method size, no diff calculated)
>
>
>

Levente Uzonyi-2

Re: The Trunk: Morphic-laza.430.mcz

In reply to this post by commits-2

On Mon, 26 Apr 2010, [hidden email] wrote:

> Alexander Lazarević uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-laza.430.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-laza.430
> Author: laza
> Time: 26 April 2010, 12:25:16.993 pm
> UUID: 6362395c-21df-0d4a-a187-99a03416c76c
> Ancestors: Morphic-laza.429
>
> Add Seaside 2.8, 2.8 Examples and 3.0 to the "How to extend the system" workspace
>
> =============== Diff against Morphic-laza.429 ===============
>
> Item was changed:
> (excessive method size, no diff calculated)

Errr, why isn't there a diff? What's excessive?

Levente

>
>
>

Hannes Hirzel

Re: The Trunk: Morphic-laza.430.mcz

I took a fresh 4.1 image, updated it to the last trunk version, chose
'Rebuild menu' and went to the help menu 'Extending the system' and
evaluated

"Seaside 3.0 http://www.seaside.st"
(Installer ss project: 'MetacelloRepository') install:
'ConfigurationOfSeaside30'.
(Smalltalk at: #ConfigurationOfSeaside30) load.
(Smalltalk at: #WASqueakServerAdaptorBrowser) open.

I got what is seen in the attached screenshot.

clicking on 'Start' produced no result.
http://localhost:8080
gave no answer.

HOWEVER after evaluating
WAKom startOn: 8080

http://localhost:8080
was accessible

What shall we do about this. At least we should include a note.

--Hannes

HowToExtendTheSystemWorkSpaceSeaside3.0.PNG (32K) Download Attachment

laza

Re: The Trunk: Morphic-laza.430.mcz

Hi Hannes!

You may want to open the menu on the top frame of the "Seaside Control
Panel" and add an adaptor (eg. WAComancheAdaptor at Port 8080) for
this. Selecting the new entry and pressing (Start) will start the new
server.

2010/4/26 Hannes Hirzel <[hidden email]>:
> HOWEVER after evaluating
> WAKom startOn: 8080
>
> http://localhost:8080
> was accessible

This works for backwards compatibility. See [1] for some description
of the "Seaside Control Panel".

Alex

[1] http://blog.fitzell.ca/2009/03/seaside-server-adaptors.html

Hannes Hirzel

Re: The Trunk: Morphic-laza.430.mcz

Thank you for this quick answer. My suggestion - include the reference
http://blog.fitzell.ca/2009/03/seaside-server-adaptors.html

in the 'How to extend the system workspace'.

Plus a reference to the seaside book.

--Hannes

On 4/26/10, Alexander Lazarević <[hidden email]> wrote:

> Hi Hannes!
>
> You may want to open the menu on the top frame of the "Seaside Control
> Panel" and add an adaptor (eg. WAComancheAdaptor at Port 8080) for
> this. Selecting the new entry and pressing (Start) will start the new
> server.
>
> 2010/4/26 Hannes Hirzel <[hidden email]>:
>> HOWEVER after evaluating
>> WAKom startOn: 8080
>>
>> http://localhost:8080
>> was accessible
>
> This works for backwards compatibility. See [1] for some description
> of the "Seaside Control Panel".
>
> Alex
>
> [1] http://blog.fitzell.ca/2009/03/seaside-server-adaptors.html
>
>

Bert Freudenberg

Re: The Trunk: Morphic-laza.430.mcz

In reply to this post by Levente Uzonyi-2

On 26.04.2010, at 13:04, Levente Uzonyi wrote:

>
> On Mon, 26 Apr 2010, [hidden email] wrote:
>
>> Alexander Lazarević uploaded a new version of Morphic to project The Trunk:
>> http://source.squeak.org/trunk/Morphic-laza.430.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Morphic-laza.430
>> Author: laza
>> Time: 26 April 2010, 12:25:16.993 pm
>> UUID: 6362395c-21df-0d4a-a187-99a03416c76c
>> Ancestors: Morphic-laza.429
>>
>> Add Seaside 2.8, 2.8 Examples and 3.0 to the "How to extend the system" workspace
>>
>> =============== Diff against Morphic-laza.429 ===============
>>
>> Item was changed:
>> (excessive method size, no diff calculated)
>
> Errr, why isn't there a diff? What's excessive?

MCDiffyTextWriter>>writePatchFrom: src to: dst
"src and dst are allowed to bi nil to represent a non-existent source or destination state"

| source target |
source := src ifNotNil: [self visitInFork: src] ifNil: [''].
target := dst ifNotNil: [self visitInFork: dst] ifNil: [''].
source size + target size > 10000
ifTrue: [ stream nextPutAll: '(excessive method size, no diff calculated)'; cr ]
ifFalse: [
stream nextPutAll: (TextDiffBuilder from: source to: target)
buildTextPatch ]

- Bert -

Levente Uzonyi-2

Re: The Trunk: Morphic-laza.430.mcz

On Mon, 26 Apr 2010, Bert Freudenberg wrote:

> On 26.04.2010, at 13:04, Levente Uzonyi wrote:
>>
>> On Mon, 26 Apr 2010, [hidden email] wrote:
>>
>>> Alexander Lazarević uploaded a new version of Morphic to project The Trunk:
>>> http://source.squeak.org/trunk/Morphic-laza.430.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Morphic-laza.430
>>> Author: laza
>>> Time: 26 April 2010, 12:25:16.993 pm
>>> UUID: 6362395c-21df-0d4a-a187-99a03416c76c
>>> Ancestors: Morphic-laza.429
>>>
>>> Add Seaside 2.8, 2.8 Examples and 3.0 to the "How to extend the system" workspace
>>>
>>> =============== Diff against Morphic-laza.429 ===============
>>>
>>> Item was changed:
>>> (excessive method size, no diff calculated)
>>
>> Errr, why isn't there a diff? What's excessive?
>
> MCDiffyTextWriter>>writePatchFrom: src to: dst
> "src and dst are allowed to bi nil to represent a non-existent source or destination state"
>
> | source target |
> source := src ifNotNil: [self visitInFork: src] ifNil: [''].
> target := dst ifNotNil: [self visitInFork: dst] ifNil: [''].
> source size + target size > 10000
> ifTrue: [ stream nextPutAll: '(excessive method size, no diff calculated)'; cr ]
> ifFalse: [
> stream nextPutAll: (TextDiffBuilder from: source to: target)
> buildTextPatch ]
>

A limit based on the number of lines would be better IMHO.

Levente

>
> - Bert -
>
>
>
>

Bert Freudenberg

Re: The Trunk: Morphic-laza.430.mcz

On 26.04.2010, at 15:35, Levente Uzonyi wrote:

>
> On Mon, 26 Apr 2010, Bert Freudenberg wrote:
>
>> On 26.04.2010, at 13:04, Levente Uzonyi wrote:
>>>
>>> On Mon, 26 Apr 2010, [hidden email] wrote:
>>>
>>>> Alexander Lazarević uploaded a new version of Morphic to project The Trunk:
>>>> http://source.squeak.org/trunk/Morphic-laza.430.mcz
>>>>
>>>> ==================== Summary ====================
>>>>
>>>> Name: Morphic-laza.430
>>>> Author: laza
>>>> Time: 26 April 2010, 12:25:16.993 pm
>>>> UUID: 6362395c-21df-0d4a-a187-99a03416c76c
>>>> Ancestors: Morphic-laza.429
>>>>
>>>> Add Seaside 2.8, 2.8 Examples and 3.0 to the "How to extend the system" workspace
>>>>
>>>> =============== Diff against Morphic-laza.429 ===============
>>>>
>>>> Item was changed:
>>>> (excessive method size, no diff calculated)
>>>
>>> Errr, why isn't there a diff? What's excessive?
>>
>> MCDiffyTextWriter>>writePatchFrom: src to: dst
>> "src and dst are allowed to bi nil to represent a non-existent source or destination state"
>>
>> | source target |
>> source := src ifNotNil: [self visitInFork: src] ifNil: [''].
>> target := dst ifNotNil: [self visitInFork: dst] ifNil: [''].
>> source size + target size > 10000
>> ifTrue: [ stream nextPutAll: '(excessive method size, no diff calculated)'; cr ]
>> ifFalse: [
>> stream nextPutAll: (TextDiffBuilder from: source to: target)
>> buildTextPatch ]
>>
>
> A limit based on the number of lines would be better IMHO.
>
>
> Levente

I guess Lukas put this in to avoid excessive load on the squeaksource server. This test is *really* cheap.

But feel free to send a patch :)

(ideally it would limit the length of the diff that gets mailed out, as well as the time spent on calculating it, all the while preserving the simplicity of the code)

- Bert -