The Trunk: Morphic-mt.1439.mcz

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1439.mcz

==================== Summary ====================

Name: Morphic-mt.1439
Author: mt
Time: 24 May 2018, 12:05:26.937891 pm
UUID: df53bb40-690a-4f24-b8c5-9345d0de9ce5
Ancestors: Morphic-mt.1438

Workaround for the mouse-down-focus issue regarding dialog invocation.

Note that even though we have an unresolved issue in the Morphic event handling here, the rule of thumb is that you as an application developer should trigger such effects on mouse-up, not mouse-down. See buttons etc. in Windows or macOS.

=============== Diff against Morphic-mt.1438 ===============

Item was changed:
  SystemOrganization addCategory: #'Morphic-Balloon'!
  SystemOrganization addCategory: #'Morphic-Basic'!
  SystemOrganization addCategory: #'Morphic-Basic-NewCurve'!
  SystemOrganization addCategory: #'Morphic-Borders'!
  SystemOrganization addCategory: #'Morphic-Collections-Arrayed'!
  SystemOrganization addCategory: #'Morphic-Demo'!
  SystemOrganization addCategory: #'Morphic-Events'!
  SystemOrganization addCategory: #'Morphic-Explorer'!
  SystemOrganization addCategory: #'Morphic-Kernel'!
  SystemOrganization addCategory: #'Morphic-Layouts'!
  SystemOrganization addCategory: #'Morphic-Menus'!
  SystemOrganization addCategory: #'Morphic-Menus-DockingBar'!
  SystemOrganization addCategory: #'Morphic-Pluggable Widgets'!
- SystemOrganization addCategory: #'Morphic-Sound'!
  SystemOrganization addCategory: #'Morphic-Sound-Synthesis'!
  SystemOrganization addCategory: #'Morphic-Support'!
  SystemOrganization addCategory: #'Morphic-Text Support'!
  SystemOrganization addCategory: #'Morphic-TrueType'!
  SystemOrganization addCategory: #'Morphic-Widgets'!
  SystemOrganization addCategory: #'Morphic-Windows'!
  SystemOrganization addCategory: #'Morphic-Worlds'!

Item was changed:
  ----- Method: HaloMorph>>addFontEmphHandle: (in category 'handles') -----
  addFontEmphHandle: haloSpec
  (innerTarget isTextMorph)
  ifTrue:
  [self
  addHandle: haloSpec
+ on: #mouseUp
- on: #mouseDown
  send: #chooseEmphasisOrAlignment
  to: innerTarget]!

Item was changed:
  ----- Method: HaloMorph>>addFontSizeHandle: (in category 'handles') -----
  addFontSizeHandle: haloSpec
  (innerTarget isTextMorph)
  ifTrue:
  [self
  addHandle: haloSpec
+ on: #mouseUp
- on: #mouseDown
  send: #chooseFont
  to: innerTarget]!

Item was changed:
  ----- Method: HaloMorph>>addFontStyleHandle: (in category 'handles') -----
  addFontStyleHandle: haloSpec
  (innerTarget isTextMorph)
  ifTrue:
  [self
  addHandle: haloSpec
+ on: #mouseUp
- on: #mouseDown
  send: #chooseStyle
  to: innerTarget]!

Item was removed:
- ----- Method: PopUpChoiceMorph>>mouseDown: (in category 'event handling') -----
- mouseDown: evt
- | items selectedItem |
- (target isNil or: [getItemsSelector isNil]) ifTrue: [^self].
- items := ((target perform: getItemsSelector withArguments: getItemsArgs)
- ifNil: [#()]) asOrderedCollection.
- selectedItem := UIManager default
- chooseFrom: items
- values: items.
- selectedItem ifNil: [^self].
- self contentsClipped: selectedItem. "Client can override this if necess"
- actionSelector ifNotNil:
- [target perform: actionSelector
- withArguments: (arguments copyWith: selectedItem)]!

Item was added:
+ ----- Method: PopUpChoiceMorph>>mouseUp: (in category 'event handling') -----
+ mouseUp: evt
+ | items selectedItem |
+ (target isNil or: [getItemsSelector isNil]) ifTrue: [^self].
+ items := ((target perform: getItemsSelector withArguments: getItemsArgs)
+ ifNil: [#()]) asOrderedCollection.
+ selectedItem := UIManager default
+ chooseFrom: items
+ values: items.
+ selectedItem ifNil: [^self].
+ self contentsClipped: selectedItem. "Client can override this if necess"
+ actionSelector ifNotNil:
+ [target perform: actionSelector
+ withArguments: (arguments copyWith: selectedItem)]!