The Trunk: Morphic-mt.1510.mcz

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1510.mcz

==================== Summary ====================

Name: Morphic-mt.1510
Author: mt
Time: 26 August 2019, 3:57:09.414394 pm
UUID: 1a066b5c-53d2-164a-980b-c331d3616e78
Ancestors: Morphic-dtl.1506, Morphic-kfr.1509

Merges Morphic-dtl.1506 and fixes some docking-bar-layout issues. :-)

Note that I changed the wording to "Git Browser (click to install)" as well as the text in the confirmation dialog. Please review.

If not automatically done, please update your world-dock instances via TheWorldMainDockingBar updateInstances.

=============== Diff against Morphic-kfr.1509 ===============

Item was removed:
- ----- Method: DockingBarItemMorph>>updateLayoutInDockingBar (in category 'private') -----
- updateLayoutInDockingBar
-
- owner isVertical
- ifTrue: [
- self hResizing: #spaceFill.
- self vResizing: #shrinkWrap ]
- ifFalse: [
- self hResizing: #shrinkWrap.
- self vResizing: #spaceFill ].!

Item was added:
+ ----- Method: DockingBarMorph>>addedMorph: (in category 'change reporting') -----
+ addedMorph: aMorph
+ "Update the new morph's layout properties according to my orientation."
+
+ aMorph isMenuItemMorph ifFalse: [^ self].
+
+ self isVertical
+ ifTrue: [
+ aMorph hResizing: #spaceFill.
+ aMorph vResizing: #shrinkWrap ]
+ ifFalse: [
+ aMorph hResizing: #shrinkWrap.
+ aMorph vResizing: #spaceFill ].!

Item was removed:
- ----- Method: MenuItemMorph>>ownerChanged (in category 'change reporting') -----
- ownerChanged
- "The receiver's owner, some kind of a pasteup, has changed its
- layout."
- super ownerChanged.
- self updateLayoutInDockingBar!

Item was changed:
  ----- Method: TheWorldMainDockingBar>>gitInfrastructureMenuItemOn: (in category 'submenu - tools') -----
+ gitInfrastructureMenuItemOn: menu
+
+ menu addItem: [:item |
+ item
+ contents: ((Smalltalk hasClassNamed: #SquitBrowser)
+ ifTrue: ['Git Browser' translated]
+ ifFalse: ['Git Browser (click to install)' translated]);
+ help: 'Browse repositories on github.com' translated;
+ icon: (self colorIcon: ((Smalltalk classNamed: #SquitBrowser) ifNil: Model)
+ basicNew windowColorToUse);
+ target: self;
+ selector: #installAndOpenGitBrowser]!
- gitInfrastructureMenuItemOn: menu
- menu addItem:
- [ : item | item
- contents: 'Git Browser' translated ;
- help: 'Browse repositories on github.com' translated ;
- icon: (self colorIcon: Color lightGray) ;
- target: Installer ;
- selector: #installAndOpenGitBrowser ]!

Item was added:
+ ----- Method: TheWorldMainDockingBar>>installAndOpenGitBrowser (in category 'menu actions') -----
+ installAndOpenGitBrowser
+
+ (Smalltalk hasClassNamed: #SquitBrowser)
+ ifFalse: [ (UIManager default
+ confirm: 'The Git infrastructure and browser is not yet installed.\\Do you want to install the Git Browser?\\(Note that this step requires an internet connection and\may take several minutes.)' withCRs translated
+ title: 'Confirm Installation Request' )
+ ifTrue: [ Installer
+ ensureRecentMetacello;
+ installGitInfrastructure.
+ TheWorldMainDockingBar updateInstances ]
+ ifFalse: [ ^self ] ].
+ (Smalltalk classNamed: #SquitBrowser) open.
+ !

Item was removed:
- ----- Method: TheWorldMainDockingBar>>metacelloMenuItemOn: (in category 'submenu - tools') -----
- metacelloMenuItemOn: menu
- menu addItem:
- [ : item | item
- contents: 'Metacello' translated ;
- help: 'Install Metacello' translated ;
- icon: (self colorIcon: Color lightGray) ;
- target: Installer ;
- selector: #ensureRecentMetacello ]!

Item was changed:
  ----- Method: TheWorldMainDockingBar>>toolsMenuOn: (in category 'construction') -----
  toolsMenuOn: aDockingBar
 
  aDockingBar addItem: [ :item |
  item
  contents: 'Tools' translated;
  addSubMenu: [ :menu |
  self
  browserMenuItemOn: menu;
  workspaceMenuItemOn: menu;
  transcriptMenuItemOn: menu;
  testRunnerMenuItemOn: menu;
  methodFinderMenuItemOn: menu;
  messageNamesMenuItemOn: menu.
  menu addLine.
  self
  simpleChangeSorterMenuItemOn: menu;
  dualChangeSorterMenuItemOn: menu;
  monticelloBrowserMenuItemOn: menu;
  monticelloConfigurationsMenuItemOn: menu ;
- metacelloMenuItemOn: menu ;
  gitInfrastructureMenuItemOn: menu.
  menu addLine.
  self
  processBrowserMenuItemOn: menu;
  preferenceBrowserMenuItemOn: menu;
  fileListMenuItemOn: menu.
  ] ]!

On Mon, Aug 26, 2019 at 01:58:17PM +0000, [hidden email] wrote:
Thanks, the menu wording and confirmation dialog changes look good to me.

Dave