Smalltalk › Squeak › Squeak - Dev

The Trunk: Morphic-mt.1565.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

commits-2

The Trunk: Morphic-mt.1565.mcz

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1565.mcz

==================== Summary ====================

Name: Morphic-mt.1565
Author: mt
Time: 9 October 2019, 5:54:57.18839 pm
UUID: 95a7cebb-cfbc-c94e-b934-d74c88ffa121
Ancestors: Morphic-mt.1564

Fixes text-composition bug for morphs embedded in text morphs through the text-anchor property.

=============== Diff against Morphic-mt.1564 ===============

Item was added:
+ ----- Method: TextMorph>>layoutChanged (in category 'layout') -----
+ layoutChanged
+ "For embedded morphs, we have to invalidate our paragraph if those morphs invalidate their layout. Since paragraph creation will also change this morph's bounds, ignore that case."
+
+ (self hasProperty: #CreatingParagraph) ifFalse: [self releaseParagraph].
+ ^ super layoutChanged!

marcel.taeumel

Re: The Trunk: Morphic-mt.1565.mcz

Well ... there is at least some interference with Shout and/or that "highlight the opening bracket" feature in text editors. Sigh.

If we cannot figure this out, better revert this one.

Best,

Marcel

Am 09.10.2019 17:55:15 schrieb [hidden email] <[hidden email]>:
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1565.mcz

==================== Summary ====================

Name: Morphic-mt.1565
Author: mt
Time: 9 October 2019, 5:54:57.18839 pm
UUID: 95a7cebb-cfbc-c94e-b934-d74c88ffa121
Ancestors: Morphic-mt.1564

Fixes text-composition bug for morphs embedded in text morphs through the text-anchor property.

=============== Diff against Morphic-mt.1564 ===============

Item was added:
+ ----- Method: TextMorph>>layoutChanged (in category 'layout') -----
+ layoutChanged
+ "For embedded morphs, we have to invalidate our paragraph if those morphs invalidate their layout. Since paragraph creation will also change this morph's bounds, ignore that case."
+
+ (self hasProperty: #CreatingParagraph) ifFalse: [self releaseParagraph].
+ ^ super layoutChanged!

Eliot Miranda-2

Re: The Trunk: Morphic-mt.1565.mcz

On Thu, Oct 10, 2019 at 5:27 AM Marcel Taeumel <[hidden email]> wrote:

Well ... there is at least some interference with Shout and/or that "highlight the opening bracket" feature in text editors. Sigh.

If we cannot figure this out, better revert this one.

I would hack it. I would use Shout to find out if the start selection is within code, within a string or within a comment. i would then simply parse forward, counting brackets if in code, not counting if in a comment or string, and instead parsing comment or string delimiters as appropriate to get "back into code".

Best,
Marcel

Am 09.10.2019 17:55:15 schrieb [hidden email] <[hidden email]>:
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1565.mcz

==================== Summary ====================

Name: Morphic-mt.1565
Author: mt
Time: 9 October 2019, 5:54:57.18839 pm
UUID: 95a7cebb-cfbc-c94e-b934-d74c88ffa121
Ancestors: Morphic-mt.1564

Fixes text-composition bug for morphs embedded in text morphs through the text-anchor property.

=============== Diff against Morphic-mt.1564 ===============

Item was added:
+ ----- Method: TextMorph>>layoutChanged (in category 'layout') -----
+ layoutChanged
+ "For embedded morphs, we have to invalidate our paragraph if those morphs invalidate their layout. Since paragraph creation will also change this morph's bounds, ignore that case."
+
+ (self hasProperty: #CreatingParagraph) ifFalse: [self releaseParagraph].
+ ^ super layoutChanged!

_,,,^..^,,,_

best, Eliot