The Trunk: Morphic-mt.1649.mcz

Am 24.04.2020 19:59:20 schrieb Thiede, Christoph <[hidden email]>:

Hi Marcel,

apparently, this change broke the #traceMessage preference since #browseAllImplementorsOf: is not dispatched to the MessageTrace any longer. What was the reason for sending it to the system navigation directly? :-)

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Mittwoch, 22. April 2020 10:46:19
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: Morphic-mt.1649.mcz

 

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1649.mcz

==================== Summary ====================

Name: Morphic-mt.1649
Author: mt
Time: 22 April 2020, 10:46:13.027214 am
UUID: 6b61e640-ba14-0d47-80af-c926334d4b82
Ancestors: Morphic-mt.1648

Fixes small glitch in text editor's #implementorsOfIt to behave like #sendersOfIt.

=============== Diff against Morphic-mt.1648 ===============

Item was changed:
  ----- Method: TextEditor>>implementorsOfIt (in category 'menu messages') -----
  implementorsOfIt
         "Open an implementors browser on the selected selector"
+
-        | aSelector |
         self lineSelectAndEmptyCheck: [^ self].
+        self selectedSelector ifNotNil:
+                [:aSelector| ^self systemNavigation browseAllImplementorsOf: aSelector].
+        self selectedLiteral ifNotNil:
+                [:aLiteral| ^self systemNavigation browseAllImplementorsOf: aLiteral].
+        morph flash.!
-        (aSelector := self selectedSelector) == nil ifTrue: [^ morph flash].
-        model browseAllImplementorsOf: aSelector!

Hi Marcel,

> Maybe #browseIt and #sendersOfIt should also go through the model?

Afaik #browseAllCallsOn: already goes through the model, at least in MessageTraces? Sounds like a good idea for #browseClass:, too :-)

Best,

Christoph

Am 26.04.2020 18:02:31 schrieb Thiede, Christoph <[hidden email]>:

Hi Marcel,

> Maybe #browseIt and #sendersOfIt should also go through the model?

Afaik #browseAllCallsOn: already goes through the model, at least in MessageTraces? Sounds like a good idea for #browseClass:, too :-)

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Sonntag, 26. April 2020 16:30:38
An: Robert via Squeak-dev; [hidden email]
Betreff: Re: [squeak-dev] The Trunk: Morphic-mt.1649.mcz

 

Hi Christoph.

> What was the reason for sending it to the system navigation directly? :-)

No reason, just oversight ... and maybe evidence of a surprising, inconsistent extension point. Maybe #browseIt and #sendersOfIt should also go through the model? Well, #doIt and #printIt do already go through the model if that model reponds to certain messages.

Best,

Marcel

Am 24.04.2020 19:59:20 schrieb Thiede, Christoph <[hidden email]>:

Hi Marcel,

apparently, this change broke the #traceMessage preference since #browseAllImplementorsOf: is not dispatched to the MessageTrace any longer. What was the reason for sending it to the system navigation directly? :-)

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Mittwoch, 22. April 2020 10:46:19
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: Morphic-mt.1649.mcz

 

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1649.mcz

==================== Summary ====================

Name: Morphic-mt.1649
Author: mt
Time: 22 April 2020, 10:46:13.027214 am
UUID: 6b61e640-ba14-0d47-80af-c926334d4b82
Ancestors: Morphic-mt.1648

Fixes small glitch in text editor's #implementorsOfIt to behave like #sendersOfIt.

=============== Diff against Morphic-mt.1648 ===============

Item was changed:
  ----- Method: TextEditor>>implementorsOfIt (in category 'menu messages') -----
  implementorsOfIt
         "Open an implementors browser on the selected selector"
+
-        | aSelector |
         self lineSelectAndEmptyCheck: [^ self].
+        self selectedSelector ifNotNil:
+                [:aSelector| ^self systemNavigation browseAllImplementorsOf: aSelector].
+        self selectedLiteral ifNotNil:
+                [:aLiteral| ^self systemNavigation browseAllImplementorsOf: aLiteral].
+        morph flash.!
-        (aSelector := self selectedSelector) == nil ifTrue: [^ morph flash].
-        model browseAllImplementorsOf: aSelector!