The Trunk: Morphic-mt.1655.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-mt.1655.mcz

commits-2
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1655.mcz

==================== Summary ====================

Name: Morphic-mt.1655
Author: mt
Time: 4 May 2020, 11:28:00.740912 am
UUID: a7baaad5-39dc-9c43-adce-02c055e280e2
Ancestors: Morphic-fn.1654

In fill-in dialogs, it should always be possible to accept the contents even if they are empty or appear otherwise unchanged.

Note that "hasUnacceptedEdits: true" might not be needed anymore. Anyway, the MorphicToolBuilder gave me some hints on how #askBeforeDiscardingEdits and #alwaysAccept are related.

=============== Diff against Morphic-fn.1654 ===============

Item was changed:
  ----- Method: FillInTheBlankMorph>>createTextPaneAcceptOnCR: (in category 'initialization') -----
  createTextPaneAcceptOnCR: acceptBoolean
 
  textPane := PluggableTextMorph
  on: self
  text: #response
  accept: #response:
  readSelection: #selectionInterval
  menu: #codePaneMenu:shifted:.
  textPane
  showScrollBarsOnlyWhenNeeded;
  wantsFrameAdornments: false;
  hasUnacceptedEdits: true;
+ askBeforeDiscardingEdits: false;
+ setProperty: #alwaysAccept toValue: true;
  acceptOnCR: acceptBoolean;
  setNameTo: 'textPane';
  layoutFrame: (LayoutFrame fractions: (0@0 corner: 1@1));
  hResizing: #spaceFill;
  vResizing: #spaceFill;
  scrollToTop.
  ^ textPane!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-mt.1655.mcz

marcel.taeumel
Hi all!

I backported this fix to Squeak 5.3, 5.2, and 5.1.

Best,
Marcel

Am 04.05.2020 11:28:33 schrieb [hidden email] <[hidden email]>:

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1655.mcz

==================== Summary ====================

Name: Morphic-mt.1655
Author: mt
Time: 4 May 2020, 11:28:00.740912 am
UUID: a7baaad5-39dc-9c43-adce-02c055e280e2
Ancestors: Morphic-fn.1654

In fill-in dialogs, it should always be possible to accept the contents even if they are empty or appear otherwise unchanged.

Note that "hasUnacceptedEdits: true" might not be needed anymore. Anyway, the MorphicToolBuilder gave me some hints on how #askBeforeDiscardingEdits and #alwaysAccept are related.

=============== Diff against Morphic-fn.1654 ===============

Item was changed:
----- Method: FillInTheBlankMorph>>createTextPaneAcceptOnCR: (in category 'initialization') -----
createTextPaneAcceptOnCR: acceptBoolean

textPane := PluggableTextMorph
on: self
text: #response
accept: #response:
readSelection: #selectionInterval
menu: #codePaneMenu:shifted:.
textPane
showScrollBarsOnlyWhenNeeded;
wantsFrameAdornments: false;
hasUnacceptedEdits: true;
+ askBeforeDiscardingEdits: false;
+ setProperty: #alwaysAccept toValue: true;
acceptOnCR: acceptBoolean;
setNameTo: 'textPane';
layoutFrame: (LayoutFrame fractions: (0@0 corner: 1@1));
hResizing: #spaceFill;
vResizing: #spaceFill;
scrollToTop.
^ textPane!