Smalltalk › Squeak › Squeak - Dev

The Trunk: Morphic-mt.1663.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Trunk: Morphic-mt.1663.mcz

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1663.mcz

==================== Summary ====================

Name: Morphic-mt.1663
Author: mt
Time: 5 June 2020, 10:02:07.727634 am
UUID: a4b01b68-1ce2-8548-8a33-df76f33a3a89
Ancestors: Morphic-mt.1662

Minor fix for class icons in object explorers. If you happen to actually explore the class, not just instances of it, show that icon, too.

=============== Diff against Morphic-mt.1662 ===============

Item was changed:
----- Method: ObjectExplorerWrapper>>icon (in category 'accessing') -----
icon
"Answer a form to be used as icon"
^ Preferences visualExplorer
ifTrue: [([self object iconOrThumbnailOfSize: 12] on: Error do: [nil])
ifNil: [self class showClassIcons
+ ifTrue: [ToolIcons iconNamed: self object class theNonMetaClass toolIcon]
- ifTrue: [ToolIcons iconNamed: self object class toolIcon]
ifFalse: [self class showContentsInColumns
ifTrue: [ToolIcons iconNamed: #blank]
ifFalse: [nil]]]]
ifFalse: [nil]!

Christoph Thiede

Re: The Trunk: Morphic-mt.1663.mcz

Hi Marcel,

nice, I did not even notice these icons before! But is it really helpful to mix up meta and non-meta states here? I could imagine that an extra class icon might be more helpful when you are debugging something and are wondering "whether this object here is lacking its instance variables but has superclass etc. instead". Just my two cents :-)

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Freitag, 5. Juni 2020 10:02:11
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: Morphic-mt.1663.mcz

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1663.mcz

==================== Summary ====================

Name: Morphic-mt.1663
Author: mt
Time: 5 June 2020, 10:02:07.727634 am
UUID: a4b01b68-1ce2-8548-8a33-df76f33a3a89
Ancestors: Morphic-mt.1662

Minor fix for class icons in object explorers. If you happen to actually explore the class, not just instances of it, show that icon, too.

=============== Diff against Morphic-mt.1662 ===============

Item was changed:
----- Method: ObjectExplorerWrapper>>icon (in category 'accessing') -----
icon
         "Answer a form to be used as icon"
         ^ Preferences visualExplorer
                 ifTrue: [([self object iconOrThumbnailOfSize: 12] on: Error do: [nil])
                         ifNil: [self class showClassIcons
+                                ifTrue: [ToolIcons iconNamed: self object class theNonMetaClass toolIcon]
-                                ifTrue: [ToolIcons iconNamed: self object class toolIcon]
                                 ifFalse: [self class showContentsInColumns
                                         ifTrue: [ToolIcons iconNamed: #blank]
                                         ifFalse: [nil]]]]
                 ifFalse: [nil]!

Carpe Squeak!