The Trunk: Morphic-mt.870.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-mt.870.mcz

commits-2
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.870.mcz

==================== Summary ====================

Name: Morphic-mt.870
Author: mt
Time: 14 April 2015, 4:58:54.922 pm
UUID: 45d654e6-9c05-454e-b09c-78cdbd3fbfaf
Ancestors: Morphic-mt.869

Fixed a really, really, really nasty GUI bug in system window, which overwrote border width and color of all added morphs.

As I do not want to change all Pluggable*Morphs, I just made ScrollPanes white by default. We could move this down the hierarchy...

=============== Diff against Morphic-mt.869 ===============

Item was added:
+ ----- Method: ScrollPane>>defaultBorderWidth (in category 'initialization') -----
+ defaultBorderWidth
+
+ ^ 1 !

Item was added:
+ ----- Method: ScrollPane>>defaultColor (in category 'initialization') -----
+ defaultColor
+
+ ^ Color white !

Item was changed:
  ----- Method: SystemWindow>>addMorph:fullFrame: (in category 'panes') -----
  addMorph: aMorph fullFrame: aLayoutFrame
  "Add aMorph according to aLayoutFrame."
  | windowBorderWidth |
  windowBorderWidth := self class borderWidth.
  "If the property #allowPaneSplitters is set to false, do *not* inset morphs by the borderWidth
  to make room for splitters.  This allows windows with non-traditional contents to avoid their
  component morphs from being clipped.  Do *NOT* remove this code please!!  Just because
  there may be no setters of allowPaneSplitters to false in the image doesn't mean they're not
  out there.  Thanks!!  eem 6/13/2013"
  (self valueOfProperty: #allowPaneSplitters ifAbsent: [true]) ifTrue:
  [| left right bottom top |
 
  left := aLayoutFrame leftOffset ifNil: [0].
  right := aLayoutFrame rightOffset ifNil: [0].
 
  bottom := aLayoutFrame bottomOffset ifNil: [0].
  top := aLayoutFrame topOffset ifNil: [0].
 
  aLayoutFrame rightFraction = 1 ifTrue: [aLayoutFrame rightOffset: right - windowBorderWidth].
  aLayoutFrame leftFraction = 0
  ifTrue: [aLayoutFrame leftOffset: left + windowBorderWidth]
  ifFalse: [aLayoutFrame leftOffset: left + ProportionalSplitterMorph splitterWidth].
 
  aLayoutFrame bottomFraction = 1 ifTrue: [aLayoutFrame bottomOffset: bottom - windowBorderWidth].
  aLayoutFrame topFraction = 0
  ifTrue: [aLayoutFrame topOffset: top + windowBorderWidth]
  ifFalse: [aLayoutFrame topOffset: top + ProportionalSplitterMorph splitterWidth]].
 
  "this code should not be here!!!!  As of 6/13/2013 there aren't even any users of BrowserCommentTextMorph."
  (aMorph class name = #BrowserCommentTextMorph) ifTrue:
  [aLayoutFrame rightOffset: windowBorderWidth negated.
  aLayoutFrame leftOffset: windowBorderWidth.
  aLayoutFrame bottomOffset: windowBorderWidth negated.
  aLayoutFrame topOffset: (windowBorderWidth negated) + 4].
 
  super addMorph: aMorph fullFrame: aLayoutFrame.
 
  paneMorphs := paneMorphs copyReplaceFrom: 1 to: 0 with: (Array with: aMorph).
+ aMorph isImageMorph ifFalse: [aMorph adoptPaneColor: self paneColor].
- aMorph isImageMorph ifFalse:
- [aMorph adoptPaneColor: self paneColor.
- aMorph borderWidth: 1; borderColor: Color lightGray; color: Color white].
  Preferences scrollBarsOnRight ifTrue:"reorder panes so flop-out right-side scrollbar is visible"
  [self addMorphBack: aMorph].
 
  self addPaneSplitters!