The Trunk: Morphic-topa.1090.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-topa.1090.mcz

commits-2
Tobias Pape uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-topa.1090.mcz

==================== Summary ====================

Name: Morphic-topa.1090
Author: topa
Time: 1 March 2016, 5:27:34.235871 pm
UUID: 1e7c7560-918a-475f-b7dc-52504303fdf1
Ancestors: Morphic-mt.1089

Make keyStroke handling in SimpleHierarchicalListMorph more robust, so it can be used with most of the Tools' key handler methods.

=============== Diff against Morphic-mt.1089 ===============

Item was changed:
  ----- Method: SimpleHierarchicalListMorph>>keyStroke: (in category 'event handling') -----
  keyStroke: event
  "Process potential command keys"
 
  (self scrollByKeyboard: event) ifTrue: [^ true].
 
  event keyCharacter asciiValue < 32 ifTrue: [
  ^ self specialKeyPressed: event keyCharacter asciiValue].
 
+ " A lot of actions do not return a Boolean here (#messageListKey:from:,
+ #classListKey:from:, ...); even most #arrowKey:from: implementors do not.
+ Hence, we explicitely check for false and else assume truthieness"
+ ^ (self keyStrokeAction: event) ~~ false
+ !
- (self keyStrokeAction: event) ifTrue: [^ true].
-
- ^ false!