The Trunk: Morphic-ul.623.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-ul.623.mcz

commits-2
Levente Uzonyi uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-ul.623.mcz

==================== Summary ====================

Name: Morphic-ul.623
Author: ul
Time: 9 September 2012, 3:54:33.811 pm
UUID: e69fe3c1-863e-9446-9935-825988ba7d03
Ancestors: Morphic-cmm.622

Highlight list items based on the selection color instead of the item's preferred color to get better readability.

=============== Diff against Morphic-cmm.622 ===============

Item was changed:
  ----- Method: ListItemWrapper>>highlightingColor (in category 'accessing') -----
  highlightingColor
+
+ ^Preferences menuSelectionColor luminance > 0.5
+ ifTrue: [ Color black ]
+ ifFalse: [ Color white ]!
- ^self preferredColor negated!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-ul.623.mcz

Bert Freudenberg
On 2012-09-09, at 20:17, [hidden email] wrote:

> Levente Uzonyi uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-ul.623.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-ul.623
> Author: ul
> Time: 9 September 2012, 3:54:33.811 pm
> UUID: e69fe3c1-863e-9446-9935-825988ba7d03
> Ancestors: Morphic-cmm.622
>
> Highlight list items based on the selection color instead of the item's preferred color to get better readability.
>
> =============== Diff against Morphic-cmm.622 ===============
>
> Item was changed:
>  ----- Method: ListItemWrapper>>highlightingColor (in category 'accessing') -----
>  highlightingColor
> +
> + ^Preferences menuSelectionColor luminance > 0.5
> + ifTrue: [ Color black ]
> + ifFalse: [ Color white ]!
> - ^self preferredColor negated!



How about using makeForegroundColor?

- Bert -



Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-ul.623.mcz

Levente Uzonyi-2
On Mon, 10 Sep 2012, Bert Freudenberg wrote:

> On 2012-09-09, at 20:17, [hidden email] wrote:
>
>> Levente Uzonyi uploaded a new version of Morphic to project The Trunk:
>> http://source.squeak.org/trunk/Morphic-ul.623.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Morphic-ul.623
>> Author: ul
>> Time: 9 September 2012, 3:54:33.811 pm
>> UUID: e69fe3c1-863e-9446-9935-825988ba7d03
>> Ancestors: Morphic-cmm.622
>>
>> Highlight list items based on the selection color instead of the item's preferred color to get better readability.
>>
>> =============== Diff against Morphic-cmm.622 ===============
>>
>> Item was changed:
>>  ----- Method: ListItemWrapper>>highlightingColor (in category 'accessing') -----
>>  highlightingColor
>> +
>> + ^Preferences menuSelectionColor luminance > 0.5
>> + ifTrue: [ Color black ]
>> + ifFalse: [ Color white ]!
>> - ^self preferredColor negated!
>
>
>
> How about using makeForegroundColor?

Nice, didn't know it exists. :)


Levente

>
> - Bert -
>
>
>
>