The Trunk: MorphicExtras-kfr.227.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: MorphicExtras-kfr.227.mcz

commits-2
Karl Ramberg uploaded a new version of MorphicExtras to project The Trunk:
http://source.squeak.org/trunk/MorphicExtras-kfr.227.mcz

==================== Summary ====================

Name: MorphicExtras-kfr.227
Author: kfr
Time: 15 April 2018, 12:47:19.317391 pm
UUID: 9dd2eaf1-6002-4f42-99c4-65f00426c358
Ancestors: MorphicExtras-kfr.226

BouncingAtomsMorph was not updating drawing bounds once it stopped stepping and got moved

=============== Diff against MorphicExtras-kfr.226 ===============

Item was removed:
- ----- Method: BouncingAtomsMorph>>intoWorld: (in category 'initialization') -----
- intoWorld: aWorld
- "Make sure report damage at least once"
- damageReported := false.
- super intoWorld: aWorld.!

Item was added:
+ ----- Method: BouncingAtomsMorph>>justDroppedInto:event: (in category 'initialization') -----
+ justDroppedInto: newOwner event: evt
+ self startStepping
+ !


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: MorphicExtras-kfr.227.mcz

marcel.taeumel
Hi, there.

Why did it stop stepping in the first place? Here are some thoughts about stepping:

- Drag/drop should not change stepping state of a morph in general.
- #intoWorld: does check #wantsSteps and propagates #startStepping: to submorphs already.

So, maybe we could fix the bounds for non-stepping BouncingAtomsMorph so that drag/drop works w/o start stepping again? :-)

Best,
Marcel

Am 15.04.2018 12:47:53 schrieb [hidden email] <[hidden email]>:

Karl Ramberg uploaded a new version of MorphicExtras to project The Trunk:
http://source.squeak.org/trunk/MorphicExtras-kfr.227.mcz

==================== Summary ====================

Name: MorphicExtras-kfr.227
Author: kfr
Time: 15 April 2018, 12:47:19.317391 pm
UUID: 9dd2eaf1-6002-4f42-99c4-65f00426c358
Ancestors: MorphicExtras-kfr.226

BouncingAtomsMorph was not updating drawing bounds once it stopped stepping and got moved

=============== Diff against MorphicExtras-kfr.226 ===============

Item was removed:
- ----- Method: BouncingAtomsMorph>>intoWorld: (in category 'initialization') -----
- intoWorld: aWorld
- "Make sure report damage at least once"
- damageReported := false.
- super intoWorld: aWorld.!

Item was added:
+ ----- Method: BouncingAtomsMorph>>justDroppedInto:event: (in category 'initialization') -----
+ justDroppedInto: newOwner event: evt
+ self startStepping
+ !




Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: MorphicExtras-kfr.227.mcz

Karl Ramberg
Hi,
Seems you are right.
I'll revert the change

Best,
Karl


On Sun, Apr 15, 2018 at 1:14 PM, Marcel Taeumel <[hidden email]> wrote:
Hi, there.

Why did it stop stepping in the first place? Here are some thoughts about stepping:

- Drag/drop should not change stepping state of a morph in general.
- #intoWorld: does check #wantsSteps and propagates #startStepping: to submorphs already.

So, maybe we could fix the bounds for non-steppingĀ BouncingAtomsMorph so that drag/drop works w/o start stepping again? :-)

Best,
Marcel

Am 15.04.2018 12:47:53 schrieb [hidden email] <[hidden email]>:

Karl Ramberg uploaded a new version of MorphicExtras to project The Trunk:
http://source.squeak.org/trunk/MorphicExtras-kfr.227.mcz

==================== Summary ====================

Name: MorphicExtras-kfr.227
Author: kfr
Time: 15 April 2018, 12:47:19.317391 pm
UUID: 9dd2eaf1-6002-4f42-99c4-65f00426c358
Ancestors: MorphicExtras-kfr.226

BouncingAtomsMorph was not updating drawing bounds once it stopped stepping and got moved

=============== Diff against MorphicExtras-kfr.226 ===============

Item was removed:
- ----- Method: BouncingAtomsMorph>>intoWorld: (in category 'initialization') -----
- intoWorld: aWorld
- "Make sure report damage at least once"
- damageReported := false.
- super intoWorld: aWorld.!

Item was added:
+ ----- Method: BouncingAtomsMorph>>justDroppedInto:event: (in category 'initialization') -----
+ justDroppedInto: newOwner event: evt
+ self startStepping
+ !