The Trunk: MorphicTests-nice.24.mcz

Nicolas Cellier uploaded a new version of MorphicTests to project The Trunk:
http://source.squeak.org/trunk/MorphicTests-nice.24.mcz

==================== Summary ====================

Name: MorphicTests-nice.24
Author: nice
Time: 16 December 2013, 5:25:47.407 pm
UUID: e33a9ad3-2f39-4c19-a3a7-dc87f18177fc
Ancestors: MorphicTests-fbs.23

MorphicToolBuilderTests as other kind of TestCase should go in MorphicTests

=============== Diff against MorphicTests-fbs.23 ===============

Item was added:
+ ToolBuilderTests subclass: #MorphicToolBuilderTests
+ instanceVariableNames: ''
+ classVariableNames: ''
+ poolDictionaries: ''
+ category: 'MorphicTests-ToolBuilder'!
+
+ !MorphicToolBuilderTests commentStamp: 'ar 2/11/2005 15:02' prior: 0!
+ Tests for the Morphic tool builder.!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>acceptWidgetText (in category 'support') -----
+ acceptWidgetText
+ widget hasUnacceptedEdits: true.
+ widget accept.!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>buttonWidgetEnabled (in category 'support') -----
+ buttonWidgetEnabled
+ "Answer whether the current widget (a button) is currently enabled"
+ ^widget enabled!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>changeListWidget (in category 'support') -----
+ changeListWidget
+ widget changeModelSelection: widget getCurrentSelectionIndex + 1.!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>expectedButtonSideEffects (in category 'support') -----
+ expectedButtonSideEffects
+ ^#(getColor getState getEnabled)!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>fireButtonWidget (in category 'support') -----
+ fireButtonWidget
+ widget performAction.!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>fireMenuItemWidget (in category 'support') -----
+ fireMenuItemWidget
+ (widget itemWithWording: 'Menu Item')
+ ifNotNil: [:item | item doButtonAction]!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>setUp (in category 'support') -----
+ setUp
+ super setUp.
+ builder := MorphicToolBuilder new.!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>testWindowDynamicLabel (in category 'tests-window') -----
+ testWindowDynamicLabel
+ self makeWindow.
+ self assert: (widget label = 'TestLabel').!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>testWindowStaticLabel (in category 'tests-window') -----
+ testWindowStaticLabel
+ | spec |
+ spec := builder pluggableWindowSpec new.
+ spec model: self.
+ spec children: #().
+ spec label: 'TestLabel'.
+ widget := builder build: spec.
+ self assert: (widget label = 'TestLabel').!

Item was added:
+ ----- Method: MorphicToolBuilderTests>>widgetColor (in category 'support') -----
+ widgetColor
+ "Answer color from widget"
+ ^widget color!

On 16 December 2013 16:25,  <[hidden email]> wrote:
So this is becoming a habit! I had this change queued up, but the
excitement of last night got in the way of me actually committing it.

Thanks!

frank

On 16 December 2013 16:38, Nicolas Cellier
<[hidden email]> wrote:
> Yes, sorry for encroaching on your territory,

It's just bad timing on my part: if I waited 12 hours I wouldn't have
had to do anything :)

> but I had to unload then
> reload the ToolBuilderTests and that leaved 2 anObsoleteToolBuilderTests
> subclasses on my way...

Here I was hoping that you wouldn't notice. Yes, and IIRC
SUnitToolBuilder will also have AnObsoleteToolBuilder. I thought I
could avoid the problem by putting ToolBuilder-Tests before Morphic
and the other using packages in the config map, but apparently I
didn't do it right or something.

> BTW, I'm not sure I like the move of MorphicToolBuilder -> Morphic because
> it makes Morphic depends on ToolBuilder.
> I would have thought of ToolBuilder as a rather external peel in the package
> onion.

As an _abstract_ tool/UI builder, it makes sense that it's "below" the
UI frameworks. Certainly it makes no sense for ToolBuilder to depend
on Morphic+ST80+Sunit+...

But yes, I was also surprised at how low-level it actually is. Except
for that dependency on System via Project, it only depends on
Collections, Files (through FileDirectory) and Kernel.

frank