Eliot Miranda uploaded a new version of Multilingual to project The Trunk:
http://source.squeak.org/trunk/Multilingual-eem.255.mcz ==================== Summary ==================== Name: Multilingual-eem.255 Author: eem Time: 4 March 2021, 10:23:00.658047 am UUID: 55a1972b-10f3-4938-bc52-fa293e2b7973 Ancestors: Multilingual-ul.254 Cleanup related to Files-eem.187. BTW, seems to me that MultiByteFileStream no longer belongs in Multilingual, but would be better off in Files. =============== Diff against Multilingual-ul.254 =============== Item was changed: ----- Method: MultiByteFileStream>>requestDropStream: (in category 'private') ----- requestDropStream: dropIndex + "Override to install proper converter." - "Needs to install proper converter" + ^(super requestDropStream: dropIndex) ifNotNil: + [:result| - | result | - result := super requestDropStream: dropIndex. - result ifNotNil: [ converter ifNil: [self converter: UTF8TextConverter new]. + lineEndConvention ifNil: [ self detectLineEndConvention ]. + result]! - lineEndConvention ifNil: [ self detectLineEndConvention ] - ]. - ^result! |
+1 for moving MultiByteFileStream from "Multilingual" to "Files". Best, Marcel
|
MultiByteFileStream has a non-file-based sibling:
MultiByteBinaryOrTextStream. It could use some love to be on par with MultiByteFileStream feature-wise, but I didn't do that hoping that by now both would be obsolete and replaced with a composable stream implementation. Levente On Fri, 5 Mar 2021, Marcel Taeumel wrote: > +1 for moving MultiByteFileStream from "Multilingual" to "Files". > Best, > Marcel > > Am 04.03.2021 19:23:10 schrieb [hidden email] <[hidden email]>: > > Eliot Miranda uploaded a new version of Multilingual to project The Trunk: > http://source.squeak.org/trunk/Multilingual-eem.255.mcz > > ==================== Summary ==================== > > Name: Multilingual-eem.255 > Author: eem > Time: 4 March 2021, 10:23:00.658047 am > UUID: 55a1972b-10f3-4938-bc52-fa293e2b7973 > Ancestors: Multilingual-ul.254 > > Cleanup related to Files-eem.187. > > BTW, seems to me that MultiByteFileStream no longer belongs in Multilingual, but would be better off in Files. > > =============== Diff against Multilingual-ul.254 =============== > > Item was changed: > ----- Method: MultiByteFileStream>>requestDropStream: (in category 'private') ----- > requestDropStream: dropIndex > + "Override to install proper converter." > - "Needs to install proper converter" > > + ^(super requestDropStream: dropIndex) ifNotNil: > + [:result| > - | result | > - result := super requestDropStream: dropIndex. > - result ifNotNil: [ > converter ifNil: [self converter: UTF8TextConverter new]. > + lineEndConvention ifNil: [ self detectLineEndConvention ]. > + result]! > - lineEndConvention ifNil: [ self detectLineEndConvention ] > - ]. > - ^result! > > > > |
Free forum by Nabble | Edit this page |