The Trunk: Network-nice.234.mcz

Nicolas Cellier uploaded a new version of Network to project The Trunk:
http://source.squeak.org/trunk/Network-nice.234.mcz

==================== Summary ====================

Name: Network-nice.234
Author: nice
Time: 11 June 2019, 11:22:42.438371 am
UUID: d5e36e0b-da09-e947-8622-e490f6a52f47
Ancestors: Network-pre.233

Stop sending squeakToIso / isoToSqueak.

These methods are no longer needed (at least since 2005!!!)

I don't know if removing such small spots of rust makes sense when the whole package may already have returned to dust, but such cleaning cannot hurt.

=============== Diff against Network-pre.233 ===============

Item was changed:
  ----- Method: PRServerDirectory>>getLines (in category 'private') -----
  getLines
  "private - answer a collection of lines with the server response"
  | url lines string |
  url := self urlFromServer: self server directories: {'programmatic'} , self directories.
  url := url , self slash.
  string := Cursor read
  showWhile: [(HTTPSocket httpGetDocument: url) contents].
  (string beginsWith: '--OK--')
  ifFalse: [^ nil].
  lines := OrderedCollection new.
  (string allButFirst: 6)
+ linesDo: [:line | lines add: line].
- linesDo: [:line | lines add: line squeakToIso].
 
  ^ lines!

Item was changed:
  ----- Method: PRServerDirectory>>getPostArgsFromProject:fileNamed:fromDirectory: (in category 'private') -----
  getPostArgsFromProject: aProject fileNamed: fileNameString fromDirectory: localDirectory
  | args thumbnail uploader |
  args := Dictionary new.
 
  "args at: 'contents' put: {(localDirectory oldFileNamed: fileNameString) contentsOfEntireFile}."
  args at: 'contents' put: {(StandardFileStream
  readOnlyFileNamed: (localDirectory fullNameFor: fileNameString)) contentsOfEntireFile}.
 
+ args at: 'name' put: {aProject name}.
- args at: 'name' put: {aProject name isoToSqueak}.
  args at: 'version' put: {(Project parseProjectFileName: fileNameString) second asString}.
  args at: 'language' put: {aProject naturalLanguage asString}.
 
  uploader := Utilities authorNamePerSe.
  uploader isEmptyOrNil
  ifTrue: [uploader := Utilities authorInitialsPerSe].
  uploader isEmptyOrNil
  ifFalse: [args at: 'uploader' put: {uploader}].
 
  self putSmalltalkInfoInto: args.
 
  thumbnail := self getProjectThumbnail: aProject.
  thumbnail isNil
  ifFalse: [args at: 'thumbnailcontents' put: {thumbnail}].
 
  self putProjectDetailsFrom: aProject to: args.
 
  ^ args!

Item was changed:
  ----- Method: PRServerDirectory>>putProjectDetailsFrom:to: (in category 'private') -----
  putProjectDetailsFrom: aProject to: args
  | projectDetails |
  projectDetails := aProject world
  valueOfProperty: #ProjectDetails
  ifAbsent: [^ self].
  ""
  self flag: #todo.
  "projectname ?"
  projectDetails
  at: 'projectdescription'
+ ifPresent: [:value | args at: 'description' put: {value}].
- ifPresent: [:value | args at: 'description' put: {value isoToSqueak}].
  projectDetails
  at: 'projectauthor'
+ ifPresent: [:value | args at: 'author' put: {value}].
- ifPresent: [:value | args at: 'author' put: {value isoToSqueak}].
  projectDetails
  at: 'projectcategory'
+ ifPresent: [:value | args at: 'category' put: {value}].
- ifPresent: [:value | args at: 'category' put: {value isoToSqueak}].
  projectDetails
  at: 'projectsubcategory'
+ ifPresent: [:value | args at: 'subcategory' put: {value}].
- ifPresent: [:value | args at: 'subcategory' put: {value isoToSqueak}].
  projectDetails
  at: 'projectkeywords'
+ ifPresent: [:value | args at: 'keywords' put: {value}]!
- ifPresent: [:value | args at: 'keywords' put: {value isoToSqueak}]!

Item was changed:
  ----- Method: PRServerDirectory>>putSmalltalkInfoInto: (in category 'private') -----
  putSmalltalkInfoInto: args
  "private - fills args with information from Smalltalk"
  self flag: #todo.
  "
  lastest small-land changeset / small-land version  
  "
  #(#datedVersion #osVersion #platformName #platformSubtype #vmPath #vmVersion #imageName #changesName #sourcesName #listBuiltinModules #listLoadedModules #getVMParameters )
  do: [:each |
  | value |
  value := Smalltalk perform: each.
+ args at: 'extra-' , each asString put: {value asString}]!
- args at: 'extra-' , each asString put: {value asString isoToSqueak}]!