The Trunk: Network-ul.176.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Network-ul.176.mcz

commits-2
Levente Uzonyi uploaded a new version of Network to project The Trunk:
http://source.squeak.org/trunk/Network-ul.176.mcz

==================== Summary ====================

Name: Network-ul.176
Author: ul
Time: 2 April 2016, 9:06:31.957661 pm
UUID: 1b580a49-2663-4d5d-a659-606ba1c698de
Ancestors: Network-ul.175

Use primitiveMakeUUID when it's available in UUID >> #makeUUID. This should keep things snappier when UUIDPlugin works, and it should decrease the possibility of a UUID collision due to our poor seed generation in Random.

=============== Diff against Network-ul.175 ===============

Item was changed:
  ----- Method: UUID>>makeUUID (in category 'as yet unclassified') -----
  makeUUID
+
+ self primMakeUUID ifNil: [
+ UUIDGenerator default generateBytes: self forVersion: 4 ]!
- UUIDGenerator default generateBytes: self forVersion: 4.!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Network-ul.176.mcz

Tobias Pape

On 02.04.2016, at 19:32, [hidden email] wrote:

> Levente Uzonyi uploaded a new version of Network to project The Trunk:
> http://source.squeak.org/trunk/Network-ul.176.mcz
>
> ==================== Summary ====================
>
> Name: Network-ul.176
> Author: ul
> Time: 2 April 2016, 9:06:31.957661 pm
> UUID: 1b580a49-2663-4d5d-a659-606ba1c698de
> Ancestors: Network-ul.175
>
> Use primitiveMakeUUID when it's available in UUID >> #makeUUID. This should keep things snappier when UUIDPlugin works, and it should decrease the possibility of a UUID collision due to our poor seed generation in Random.
>

I thought the non-primitive version was snappy enough already?
libuuid has been a constant nag for me when doing CI stuff...

Best
        -Tobias

> =============== Diff against Network-ul.175 ===============
>
> Item was changed:




Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Network-ul.176.mcz

Levente Uzonyi
Hi Tobias,

It is snappy enough, but it's not such a good idea to rely on
UUIDGenerator while the seeding problem exists in Random[1].
I have a solution for that in progress, which works without VM support,
but it still has a few question marks.
When I asked for a primitive to solve that issue, the thread[1] got
totally derailed.
Btw, this change should have no effect when UUIDPlugin doesn't work.

Levente

[1] http://forum.world.st/Seeding-instances-of-Random-tt4859041.html

On Sat, 2 Apr 2016, Tobias Pape wrote:

>
> On 02.04.2016, at 19:32, [hidden email] wrote:
>
>> Levente Uzonyi uploaded a new version of Network to project The Trunk:
>> http://source.squeak.org/trunk/Network-ul.176.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Network-ul.176
>> Author: ul
>> Time: 2 April 2016, 9:06:31.957661 pm
>> UUID: 1b580a49-2663-4d5d-a659-606ba1c698de
>> Ancestors: Network-ul.175
>>
>> Use primitiveMakeUUID when it's available in UUID >> #makeUUID. This should keep things snappier when UUIDPlugin works, and it should decrease the possibility of a UUID collision due to our poor seed generation in Random.
>>
>
> I thought the non-primitive version was snappy enough already?
> libuuid has been a constant nag for me when doing CI stuff...
>
> Best
> -Tobias
>
>> =============== Diff against Network-ul.175 ===============
>>
>> Item was changed:
>
>
>
>
>