The Trunk: NetworkTests-dtl.30.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: NetworkTests-dtl.30.mcz

commits-2
David T. Lewis uploaded a new version of NetworkTests to project The Trunk:
http://source.squeak.org/trunk/NetworkTests-dtl.30.mcz

==================== Summary ====================

Name: NetworkTests-dtl.30
Author: dtl
Time: 18 June 2012, 7:25:58.497 pm
UUID: d8c8c0b7-1d62-43e4-99a3-162ef830471d
Ancestors: NetworkTests-ul.27

When comparing remoteAddress to #[0 0 0 0] ensure that remoteAddress is a ByteArray. Required for SocketAddress upcoming network updates, no effect on tests when running current Network code.

=============== Diff against NetworkTests-ul.27 ===============

Item was changed:
  ----- Method: SocketTest>>testRemoteAddress (in category 'tests') -----
  testRemoteAddress
  "Tests the various remoteAddress values for sockets"
 
  self testServerAccept.
+ self assert: listenerSocket remoteAddress asByteArray = #[0 0 0 0].
- self assert: listenerSocket remoteAddress = #[0 0 0 0].
  self assert: clientSocket remoteAddress = self listenerAddress.
  self assert: serverSocket remoteAddress = self listenerAddress.
  !


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: NetworkTests-dtl.30.mcz

David T. Lewis
This update is the only change required for NetworkTests to run with both
the current Network code and the Network updates in the inbox. I moved the
intermediate NetworkTests-dtl.28 and NetworkTests-dtl.29 to the treated
inbox, as they contain nothing of value.

There is a series of six recent updates to Network in the inbox, the latest of
which now appears to be stable. If no further issues are seen I will move these
six from inbox to trunk tomorrow.

Dave

On Mon, Jun 18, 2012 at 11:26:03PM +0000, [hidden email] wrote:

> David T. Lewis uploaded a new version of NetworkTests to project The Trunk:
> http://source.squeak.org/trunk/NetworkTests-dtl.30.mcz
>
> ==================== Summary ====================
>
> Name: NetworkTests-dtl.30
> Author: dtl
> Time: 18 June 2012, 7:25:58.497 pm
> UUID: d8c8c0b7-1d62-43e4-99a3-162ef830471d
> Ancestors: NetworkTests-ul.27
>
> When comparing remoteAddress to #[0 0 0 0] ensure that remoteAddress is a ByteArray. Required for SocketAddress upcoming network updates, no effect on tests when running current Network code.
>
> =============== Diff against NetworkTests-ul.27 ===============
>
> Item was changed:
>   ----- Method: SocketTest>>testRemoteAddress (in category 'tests') -----
>   testRemoteAddress
>   "Tests the various remoteAddress values for sockets"
>  
>   self testServerAccept.
> + self assert: listenerSocket remoteAddress asByteArray = #[0 0 0 0].
> - self assert: listenerSocket remoteAddress = #[0 0 0 0].
>   self assert: clientSocket remoteAddress = self listenerAddress.
>   self assert: serverSocket remoteAddress = self listenerAddress.
>   !
>