The Trunk: PreferenceBrowser-mt.102.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: PreferenceBrowser-mt.102.mcz

commits-2
Marcel Taeumel uploaded a new version of PreferenceBrowser to project The Trunk:
http://source.squeak.org/trunk/PreferenceBrowser-mt.102.mcz

==================== Summary ====================

Name: PreferenceBrowser-mt.102
Author: mt
Time: 18 February 2020, 9:09:35.730015 am
UUID: 3a5db0c6-52ec-f94a-a738-680dec6a1dfb
Ancestors: PreferenceBrowser-mt.101

Small fix in the wizard's labels when installing extra packages. Make all labels appear in the same form, which starts with an uppercase letter and is (more or less) title case.

(Note that, after the release, we might want to re-design #findFeatures in String. That extra #asLowercase destroys information from the original text. But maybe that was intended after all to better cluster features.)

=============== Diff against PreferenceBrowser-mt.101 ===============

Item was changed:
  ----- Method: PreferenceWizardMorph>>installExtraPackages (in category 'actions') -----
  installExtraPackages
  "Removes the buttons and adds the progress bar during installation."
 
  | steps page |
  self removeProperty: #checkInternet. "No frequent checks for connectivity from here."
 
  steps := #(
  InstallLatestUpdates
  InstallMetacello
  InstallRefactoringTools
  InstallAutoComplete
  InstallGitInfrastructure
  InstallFFI
  InstallOSProcess )
+ select: [:ea | self perform: ('state', ea) asSymbol].
- select: [:ea | self perform: ('state', ea) asSymbol]
- thenCollect: [:ea | ea withFirstCharacterDownshifted asSymbol].
 
  page := controlMorph firstSubmorph.
 
  page submorphs second hide. "question"
  page submorphs last delete. "url"
  page submorphs last delete. "no button"
  page submorphs last delete. "yes button"
  page submorphs last delete. "package list"
 
  self refreshWorld.
 
  [
  PreferenceWizardProgressMorph install.
  page
  addMorphBack: PreferenceWizardProgressMorph uniqueInstance;
  addMorphBack: self createVerticalSpacer.
 
  steps
+ do: [:step | self perform: step withFirstCharacterDownshifted asSymbol]
+ displayingProgress: [:step | String streamContents: [:s |
+ step findFeatureIndicesDo: [:start :end |
+ s nextPutAll: (step copyFrom: start to: end); space].
+ s nextPutAll: '...']].
- do: [:step | self perform: step]
- displayingProgress: [:step | (step findFeatures joinSeparatedBy: String space), ' ...'].
  ] ensure: [
  PreferenceWizardProgressMorph reset.
  self showSqueak].!