The Trunk: PreferenceBrowser-mt.54.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: PreferenceBrowser-mt.54.mcz

commits-2
Marcel Taeumel uploaded a new version of PreferenceBrowser to project The Trunk:
http://source.squeak.org/trunk/PreferenceBrowser-mt.54.mcz

==================== Summary ====================

Name: PreferenceBrowser-mt.54
Author: mt
Time: 27 August 2015, 10:56:18.032 am
UUID: 10b11ae8-a6bd-a445-a977-b30028b9e507
Ancestors: PreferenceBrowser-mt.53

Some adjustments for cleaned-up preferences interface.

=============== Diff against PreferenceBrowser-mt.53 ===============

Item was changed:
  ----- Method: PreferenceBrowser>>allPreferences (in category 'accessing') -----
  allPreferences
+ ^ preferences allPreferences  asSortedCollection:
- ^ preferences allPreferenceObjects  asSortedCollection:
  [:pref1 :pref2 |
  pref1 viewRegistry viewOrder  <pref2 viewRegistry viewOrder  or:
  [pref1 viewRegistry viewOrder  =pref2 viewRegistry viewOrder
  &(pref1 name  <pref2 name)]]!

Item was changed:
  ----- Method: PreferenceBrowser>>categoryList (in category 'accessing') -----
  categoryList
  ^OrderedCollection new
  add:  self allCategoryLabel;
+ addAll: preferences categoryList asSortedCollection;
- addAll: preferences categoryNames asSortedCollection;
  add: self searchResultsCategoryLabel;
  yourself.
 
  !

Item was changed:
  ----- Method: PreferenceBrowser>>findCategoryFromPreference: (in category 'find') -----
  findCategoryFromPreference: prefSymbol
  "Find all categories in which the preference occurs"
 
  | aMenu|
  aMenu := MenuMorph new defaultTarget: self.
+ (preferences categoryListOfPreference: prefSymbol) do:
- (preferences categoriesContainingPreference: prefSymbol) do:
  [:aCategory | aMenu add: aCategory target: self selector: #selectedCategory: argument: aCategory].
  aMenu popUpInWorld!

Item was changed:
  ----- Method: PreferenceBrowser>>preferencesInCategory: (in category 'accessing') -----
  preferencesInCategory: aCategory
+ ^(preferences preferencesInCategory: aCategory) asSortedCollection:
- ^(preferences preferenceObjectsInCategory: aCategory) asSortedCollection:
  [:pref1 :pref2 |
  pref1 viewRegistry viewOrder  <pref2 viewRegistry viewOrder  or:
  [pref1 viewRegistry viewOrder  =pref2 viewRegistry viewOrder
  &(pref1 name  <pref2 name)]]!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: PreferenceBrowser-mt.54.mcz

Karl Ramberg
Hi,
While you are working on the preferences, it would be great if you could look at this change
http://source.squeak.org/inbox/EToys-kfr.127.mcz

It adds access to change color and border style for menus (and buttons) in the preference  browser
(these methods should really not be in the Etoys category)

Karl

On Thu, Aug 27, 2015 at 10:56 AM, <[hidden email]> wrote:
Marcel Taeumel uploaded a new version of PreferenceBrowser to project The Trunk:
http://source.squeak.org/trunk/PreferenceBrowser-mt.54.mcz

==================== Summary ====================

Name: PreferenceBrowser-mt.54
Author: mt
Time: 27 August 2015, 10:56:18.032 am
UUID: 10b11ae8-a6bd-a445-a977-b30028b9e507
Ancestors: PreferenceBrowser-mt.53

Some adjustments for cleaned-up preferences interface.

=============== Diff against PreferenceBrowser-mt.53 ===============

Item was changed:
  ----- Method: PreferenceBrowser>>allPreferences (in category 'accessing') -----
  allPreferences
+       ^ preferences allPreferences  asSortedCollection:
-       ^ preferences allPreferenceObjects  asSortedCollection:
                        [:pref1 :pref2 |
                        pref1 viewRegistry viewOrder  <pref2 viewRegistry viewOrder  or:
                                        [pref1 viewRegistry viewOrder  =pref2 viewRegistry viewOrder
                                                 &(pref1 name  <pref2 name)]]!

Item was changed:
  ----- Method: PreferenceBrowser>>categoryList (in category 'accessing') -----
  categoryList
        ^OrderedCollection new
                add:  self allCategoryLabel;
+               addAll: preferences categoryList asSortedCollection;
-               addAll: preferences categoryNames asSortedCollection;
                add: self searchResultsCategoryLabel;
                yourself.

        !

Item was changed:
  ----- Method: PreferenceBrowser>>findCategoryFromPreference: (in category 'find') -----
  findCategoryFromPreference: prefSymbol
        "Find all categories in which the preference occurs"

        | aMenu|
        aMenu := MenuMorph new defaultTarget: self.
+       (preferences categoryListOfPreference: prefSymbol) do:
-       (preferences categoriesContainingPreference: prefSymbol) do:
                [:aCategory | aMenu add: aCategory target: self selector: #selectedCategory: argument: aCategory].
        aMenu popUpInWorld!

Item was changed:
  ----- Method: PreferenceBrowser>>preferencesInCategory: (in category 'accessing') -----
  preferencesInCategory: aCategory
+       ^(preferences preferencesInCategory: aCategory) asSortedCollection:
-       ^(preferences preferenceObjectsInCategory: aCategory) asSortedCollection:
                [:pref1 :pref2 |
                                pref1 viewRegistry viewOrder  <pref2 viewRegistry viewOrder  or:
                                                [pref1 viewRegistry viewOrder  =pref2 viewRegistry viewOrder
                                                         &(pref1 name  <pref2 name)]]!





Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: PreferenceBrowser-mt.54.mcz

marcel.taeumel
Sure.

Best,
Marcel
Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: PreferenceBrowser-mt.54.mcz

marcel.taeumel
In reply to this post by Karl Ramberg
Done. :)

Best,
Marcel
Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: PreferenceBrowser-mt.54.mcz

Karl Ramberg
Thank you :-)

Karl

On Fri, Aug 28, 2015 at 10:37 AM, marcel.taeumel <[hidden email]> wrote:
Done. :)

Best,
Marcel



--
View this message in context: http://forum.world.st/The-Trunk-PreferenceBrowser-mt-54-mcz-tp4846279p4846550.html
Sent from the Squeak - Dev mailing list archive at Nabble.com.