The Trunk: ReleaseBuilder-cmm.57.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: ReleaseBuilder-cmm.57.mcz

commits-2
Chris Muller uploaded a new version of ReleaseBuilder to project The Trunk:
http://source.squeak.org/trunk/ReleaseBuilder-cmm.57.mcz

==================== Summary ====================

Name: ReleaseBuilder-cmm.57
Author: cmm
Time: 30 January 2011, 3:13:42.58 pm
UUID: babaad42-304b-4f0e-b72b-7ac91298d655
Ancestors: ReleaseBuilder-cmm.56

Document everything done to make a release via the #prepareNewBuild method, including the opening of the Welcome Workspace.

=============== Diff against ReleaseBuilder-cmm.56 ===============

Item was added:
+ ----- Method: ReleaseBuilderTrunk classSide>>openWelcomeWorkspace (in category 'private') -----
+ openWelcomeWorkspace
+ TheWorldMainDockingBar instance
+ showWelcomeText: #welcomeToSqueak42
+ label: 'Welcome to Squeak 4.2'
+ in: (140 @ 140 extent: 500 @ 300)!

Item was changed:
  ----- Method: ReleaseBuilderTrunk classSide>>prepareNewBuild (in category 'scripts') -----
+ prepareNewBuild
+ "ReleaseBuilderTrunk prepareNewBuild"
- prepareNewBuild "ReleaseBuilderTrunk prepareNewBuild"
  "Prepare everything that should be done for a new image build"
  SystemVersion setVersion.
+ SMLoaderPlus
+ setDefaultFilters: (OrderedCollection with: #filterSafelyAvailable).
+ self setDisplayExtent: 800 @ 600;
+ setBackground;
+ setPreferences;
+ switchTo42Repository;
+ openWelcomeWorkspace.
- MCMcmUpdater defaultUpdateURL: 'http://source.squeak.org/squeak42'.
- SMLoaderPlus setDefaultFilters: (OrderedCollection with: #filterSafelyAvailable).
- self
- setDisplayExtent: 800@600 ;
- setBackground ;
- setPreferences.
  "Make DependencyBrowser accessible on the open menu."
  DependencyBrowser initialize.
  Smalltalk cleanUp: true.
  Undeclared removeUnreferencedKeys.
  Smalltalk garbageCollect.
+ 3
+ timesRepeat: [Smalltalk garbageCollect.
+ Symbol compactSymbolTable]!
- 3 timesRepeat:
- [ Smalltalk garbageCollect.
- Symbol compactSymbolTable ]!

Item was changed:
  ----- Method: ReleaseBuilderTrunk classSide>>setDisplayExtent: (in category 'private') -----
  setDisplayExtent: extent
  DisplayScreen
  depth: 32
  width: extent x
  height: extent y
  fullscreen: false.
+ Display extent = extent ifFalse: [ Warning signal: 'Display extent not set to 800@600.' ]!
- Display extent = extent ifFalse: [ self error: 'Display extent not set.' ]!

Item was added:
+ ----- Method: ReleaseBuilderTrunk classSide>>switchTo42Repository (in category 'private') -----
+ switchTo42Repository
+ | old41Repository |
+ MCMcmUpdater defaultUpdateURL: 'http://source.squeak.org/squeak42'.
+ old41Repository := MCRepositoryGroup default repositories
+ detect: [:each | each description includesSubString: 'squeak41'].
+ old41Repository
+ ifNotNil: [MCRepositoryGroup default removeRepository: old41Repository].
+ MCRepositoryGroup default
+ addRepository: (MCHttpRepository
+ location: 'http://source.squeak.org/squeak42'
+ user: 'squeak'
+ password: 'squeak')!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ReleaseBuilder-cmm.57.mcz

Levente Uzonyi-2
On Sun, 30 Jan 2011, [hidden email] wrote:

> Chris Muller uploaded a new version of ReleaseBuilder to project The Trunk:
> http://source.squeak.org/trunk/ReleaseBuilder-cmm.57.mcz

snip

>  ----- Method: ReleaseBuilderTrunk classSide>>prepareNewBuild (in category 'scripts') -----
> + prepareNewBuild
> + "ReleaseBuilderTrunk prepareNewBuild"
> - prepareNewBuild "ReleaseBuilderTrunk prepareNewBuild"
>   "Prepare everything that should be done for a new image build"
>   SystemVersion setVersion.
> + SMLoaderPlus
> + setDefaultFilters: (OrderedCollection with: #filterSafelyAvailable).
> + self setDisplayExtent: 800 @ 600;
> + setBackground;
> + setPreferences;
> + switchTo42Repository;
> + openWelcomeWorkspace.
> - MCMcmUpdater defaultUpdateURL: 'http://source.squeak.org/squeak42'.
> - SMLoaderPlus setDefaultFilters: (OrderedCollection with: #filterSafelyAvailable).
> - self
> - setDisplayExtent: 800@600 ;
> - setBackground ;
> - setPreferences.
>   "Make DependencyBrowser accessible on the open menu."
>   DependencyBrowser initialize.
>   Smalltalk cleanUp: true.
>   Undeclared removeUnreferencedKeys.
>   Smalltalk garbageCollect.
> + 3
> + timesRepeat: [Smalltalk garbageCollect.
> + Symbol compactSymbolTable]!

What's the point of doing this 3 times? Btw Symbol's #cleanUp already
compacts the symbol table, so it's not 3, but 4 times.

IMHO a real improvement would be to change HashedCollection class >>
#cleanUp: to send #compactAll instead of #rehashAll.

Also #compactSymbolTable starts with a full GC, so it's pointless to do it
one more time in the loop.


Levente

snip