The Trunk: ReleaseBuilder-eem.173.mcz

Eliot Miranda uploaded a new version of ReleaseBuilder to project The Trunk:
http://source.squeak.org/trunk/ReleaseBuilder-eem.173.mcz

==================== Summary ====================

Name: ReleaseBuilder-eem.173
Author: eem
Time: 5 January 2018, 8:32:47.664882 pm
UUID: 285b720e-b53c-41a4-b8a6-d46d379b9acc
Ancestors: ReleaseBuilder-eem.172

Split selecting the bytecode set from installing it, to allow asking promptly and deferring installing until the recmpile step.

=============== Diff against ReleaseBuilder-eem.172 ===============

Item was changed:
  Object subclass: #ReleaseBuilder
  instanceVariableNames: ''
  classVariableNames: 'DeferredTask NextMajorVersion NextMinorVersion NextTask'
  poolDictionaries: ''
  category: 'ReleaseBuilder'!
+ ReleaseBuilder class
+ instanceVariableNames: 'useNewBytecodeSet'!
 
  !ReleaseBuilder commentStamp: 'mt 6/22/2016 18:08' prior: 0!
  I'm the script that prepares a trunk image for release.
 
  Just do "ReleaseBuilder doNextStep" repeatedly until the next release is done.
 
  For the final release step:
  - If you want to try it locally, change #localBuild to return true.
  - Most of the code operates (read-only) on the build repository, which is usually the trunk. For releases, there is a release repository, to which some package versions will be copied from trunk.!
+ ReleaseBuilder class
+ instanceVariableNames: 'useNewBytecodeSet'!

Item was changed:
  ----- Method: ReleaseBuilder class>>recompileAll (in category 'scripts - support') -----
  recompileAll
 
+ useNewBytecodeSet ifTrue:
+ [(Smalltalk classNamed: #EncoderForSistaV1) ifNotNil:
+ [:sistaBytecodeSet|
+ CompiledCode
+ installSecondaryBytecodeSet: sistaBytecodeSet;
+ preferredBytecodeSetEncoderClass: sistaBytecodeSet]].
- (Smalltalk classNamed: #EncoderForSistaV1) ifNotNil:
- [:sistaBytecodeSet|
- CompiledCode preferredBytecodeSetEncoderClass ~~ sistaBytecodeSet ifTrue:
- [(Project uiManager
- confirm: 'Do you want to make it the default in this release?'
- orCancel: [false]
- title: 'The SistaV1 Bytecode Set Is Available') ifTrue:
- [CompiledCode
- installSecondaryBytecodeSet: sistaBytecodeSet;
- preferredBytecodeSetEncoderClass: sistaBytecodeSet]]].
 
  Compiler recompileAll!

Item was added:
+ ----- Method: ReleaseBuilder class>>setBytecodeSet (in category 'scripts') -----
+ setBytecodeSet
+ "If possible and desired. install the SistaV1 byetcode set as the default.
+ Note that we use a variable to ask to use the compiler early so as not
+ to keep the release manager waiting, while deferring installing the
+ bytecode set until the recompileAll phase."
+ useNewBytecodeSet := false.
+ (Smalltalk classNamed: #EncoderForSistaV1) ifNotNil:
+ [:sistaBytecodeSet|
+ CompiledCode preferredBytecodeSetEncoderClass ~~ sistaBytecodeSet ifTrue:
+ [(Project uiManager
+ confirm: 'Do you want to make it the default in this release?'
+ orCancel: [^ Error signal: 'Release building canceled.']
+ title: 'The SistaV1 Bytecode Set Is Available') ifTrue:
+ [useNewBytecodeSet := true]]]!

Item was changed:
  ----- Method: ReleaseBuilder class>>setPreferences (in category 'scripts') -----
  setPreferences
  "Preferences class defaultValueTableForCurrentRelease"
 
  " Preferences outOfTheBox."  "<-- uncomment after #defaultValueTableForCurrentRelease is fixed up."
 
  "General User interaction"
  Preferences
  enable: #generalizedYellowButtonMenu ;
  enable: #swapMouseButtons;
  disable: #mouseOverForKeyboardFocus.
  Morph indicateKeyboardFocus: true.
  Project uiManager openToolsAttachedToMouseCursor: false.
  SearchBar useScratchPad: false.
 
  HandMorph sendMouseWheelToKeyboardFocus: false.
  HandMorph synthesizeMouseWheelEvents: true.
 
  "Text input."
  TextEditor
  autoEnclose: true ;
  autoIndent: true ;
  encloseSelection: false ;
  destructiveBackWord: false ;
  blinkingCursor: true ;
  dumbbellCursor: false.
  PluggableTextMorph simpleFrameAdornments: false.
  TextMorphForEditView draggableTextSelection: true.
 
  "Windows"
  SystemWindow reuseWindows: false.
  SystemWindow windowsRaiseOnClick: true.
  SystemWindow windowTitleActiveOnFirstClick: true.
  Model windowActiveOnFirstClick: false. "Not good for little screen real estate."
  Model useColorfulWindows: false.
 
  Preferences
  disable: #showSplitterHandles;
  disable: #fastDragWindowForMorphic.
  CornerGripMorph
  drawCornerResizeHandles: false;
  passiveColor: (Color gray: 0.85);
  activeColor: (Color r: 1 g: 0.599 b: 0.0).
  ProportionalSplitterMorph
  smartHorizontalSplitters: false ;
  smartVerticalSplitters: false.
 
  "Scroll bars."
  Preferences
  enable: #scrollBarsNarrow;
  enable: #scrollBarsOnRight;
  enable: #alwaysHideHScrollbar;
  disable: #alwaysShowHScrollbar;
  disable: #alwaysShowVScrollbar.
  ScrollBar
  scrollBarsWithoutArrowButtons: true;
  scrollBarsWithoutMenuButton: true.
  ScrollPane
  useRetractableScrollBars: false.
 
  "Rounded corners."
  Morph preferredCornerRadius: 8.
  SystemWindow roundedWindowCorners: false.
  DialogWindow roundedDialogCorners: false.
  MenuMorph roundedMenuCorners: false.
  PluggableButtonMorph roundedButtonCorners: false.
  ScrollBar roundedScrollBarLook: false.
 
  "Gradients."
  SystemWindow gradientWindow: false.
  DialogWindow gradientDialog: false.
  MenuMorph gradientMenu: false.
  PluggableButtonMorph gradientButton: false.
  ScrollBar gradientScrollBar: false.
 
  "Shadows"
  Preferences enable: #menuAppearance3d.
  Morph useSoftDropShadow: true.
 
  "Lists and Trees"
  PluggableListMorph
  filterableLists: true;
  clearFilterAutomatically: false;
  highlightHoveredRow: true;
  menuRequestUpdatesSelection: true.
  PluggableTreeMorph
  filterByLabelsOnly: false;
  maximumSearchDepth: 1.
 
  "Standard Tools"
  TheWorldMainDockingBar
  showWorldMainDockingBar: true;
  showSecondsInClock: true;
  twentyFourHourClock: true.
  SearchBar useSmartSearch: true.
  Workspace shouldStyle: false.
  Browser
  listClassesHierarchically: true;
  showClassIcons: true;
  showMessageIcons: true;
  sortMessageCategoriesAlphabetically: true.
  Preferences enable: #annotationPanes;
  enable: #optionalButtons;
  disable: #diffsWithPrettyPrint;
  enable: #traceMessages;
  enable: #alternativeBrowseIt;
  enable: #menuWithIcons;
  enable: #visualExplorer.
  SystemNavigation thoroughSenders: true.
  Preferences disable: #debugLogTimestamp.
 
  "Halo"
  Preferences
  enable: #showBoundsInHalo ;
  disable: #alternateHandlesLook;
  disable: #showDirectionHandles.
 
  "System"
  NetNameResolver enableIPv6: false.
  Scanner
  allowUnderscoreAsAssignment: true;
  prefAllowUnderscoreSelectors: true.
 
+ Deprecation showDeprecationWarnings: true.
- Deprecation showDeprecationWarnings: true
 
+ self setBytecodeSet.
+
  "that's all, folks"!