The Trunk: SMBase-dtl.131.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: SMBase-dtl.131.mcz

commits-2
David T. Lewis uploaded a new version of SMBase to project The Trunk:
http://source.squeak.org/trunk/SMBase-dtl.131.mcz

==================== Summary ====================

Name: SMBase-dtl.131
Author: dtl
Time: 16 December 2012, 6:04:50.573 pm
UUID: 688798d6-12c7-4c6d-8cca-1f6539b446d8
Ancestors: SMBase-cmm.130

SqueakMap does not consider 'Squeak 4.4' and 'Squeak4.4' to be the same version, but it probably should do so. Remove spaces from the version string compare.

=============== Diff against SMBase-cmm.130 ===============

Item was changed:
  ----- Method: SMPackageRelease>>isCompatibleWithCurrentSystemVersion (in category 'testing') -----
  isCompatibleWithCurrentSystemVersion
  "Return true if this release is listed as being compatible with the SystemVersion of the current image.  Only checks major/minor version number; does not differentiate between alpha/beta/gamma releases.  Checks version categories of both the SMPackageRelease and the parent SMPackage."
 
  | current |
+ current := (self majorMinorVersionFrom: SystemVersion current version)
+ copyWithout: Character space.
- current := self majorMinorVersionFrom: SystemVersion current version.
  self categories, self package categories do: [:c |
  ((c parent name = 'Squeak versions') and: [
+ ((self majorMinorVersionFrom: c name)
+ copyWithout: Character space) = current])
+ ifTrue: [^true]].
- (self majorMinorVersionFrom: c name) = current])
- ifTrue: [^true]].
  ^ false
+ !
-
- " ^ (self categories, self package categories
- detect:
- [:cat | (cat parent name = 'Squeak versions')
- and: [(SystemVersion new version: cat name) majorMinorVersion = SystemVersion current majorMinorVersion]]
- ifNone: []) notNil
- "!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: SMBase-dtl.131.mcz

David T. Lewis
I moved this from inbox to trunk in order to resolve Mantis 7708 "Zippers
package is shown in SqueakMap for 4.4. but does not load".

Dave

On Fri, Dec 21, 2012 at 01:56:13PM +0000, [hidden email] wrote:

> David T. Lewis uploaded a new version of SMBase to project The Trunk:
> http://source.squeak.org/trunk/SMBase-dtl.131.mcz
>
> ==================== Summary ====================
>
> Name: SMBase-dtl.131
> Author: dtl
> Time: 16 December 2012, 6:04:50.573 pm
> UUID: 688798d6-12c7-4c6d-8cca-1f6539b446d8
> Ancestors: SMBase-cmm.130
>
> SqueakMap does not consider 'Squeak 4.4' and 'Squeak4.4' to be the same version, but it probably should do so. Remove spaces from the version string compare.
>
> =============== Diff against SMBase-cmm.130 ===============
>
> Item was changed:
>   ----- Method: SMPackageRelease>>isCompatibleWithCurrentSystemVersion (in category 'testing') -----
>   isCompatibleWithCurrentSystemVersion
>   "Return true if this release is listed as being compatible with the SystemVersion of the current image.  Only checks major/minor version number; does not differentiate between alpha/beta/gamma releases.  Checks version categories of both the SMPackageRelease and the parent SMPackage."
>  
>   | current |
> + current := (self majorMinorVersionFrom: SystemVersion current version)
> + copyWithout: Character space.
> - current := self majorMinorVersionFrom: SystemVersion current version.
>   self categories, self package categories do: [:c |
>   ((c parent name = 'Squeak versions') and: [
> + ((self majorMinorVersionFrom: c name)
> + copyWithout: Character space) = current])
> + ifTrue: [^true]].
> - (self majorMinorVersionFrom: c name) = current])
> - ifTrue: [^true]].
>   ^ false
> + !
> -
> - " ^ (self categories, self package categories
> - detect:
> - [:cat | (cat parent name = 'Squeak versions')
> - and: [(SystemVersion new version: cat name) majorMinorVersion = SystemVersion current majorMinorVersion]]
> - ifNone: []) notNil
> - "!
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: SMBase-dtl.131.mcz

Chris Muller-3
Ok, thanks Dave.

On Fri, Dec 21, 2012 at 8:06 AM, David T. Lewis <[hidden email]> wrote:

> I moved this from inbox to trunk in order to resolve Mantis 7708 "Zippers
> package is shown in SqueakMap for 4.4. but does not load".
>
> Dave
>
> On Fri, Dec 21, 2012 at 01:56:13PM +0000, [hidden email] wrote:
>> David T. Lewis uploaded a new version of SMBase to project The Trunk:
>> http://source.squeak.org/trunk/SMBase-dtl.131.mcz
>>
>> ==================== Summary ====================
>>
>> Name: SMBase-dtl.131
>> Author: dtl
>> Time: 16 December 2012, 6:04:50.573 pm
>> UUID: 688798d6-12c7-4c6d-8cca-1f6539b446d8
>> Ancestors: SMBase-cmm.130
>>
>> SqueakMap does not consider 'Squeak 4.4' and 'Squeak4.4' to be the same version, but it probably should do so. Remove spaces from the version string compare.
>>
>> =============== Diff against SMBase-cmm.130 ===============
>>
>> Item was changed:
>>   ----- Method: SMPackageRelease>>isCompatibleWithCurrentSystemVersion (in category 'testing') -----
>>   isCompatibleWithCurrentSystemVersion
>>       "Return true if this release is listed as being compatible with the SystemVersion of the current image.  Only checks major/minor version number; does not differentiate between alpha/beta/gamma releases.  Checks version categories of both the SMPackageRelease and the parent SMPackage."
>>
>>       | current |
>> +     current := (self majorMinorVersionFrom: SystemVersion current version)
>> +             copyWithout: Character space.
>> -     current := self majorMinorVersionFrom: SystemVersion current version.
>>       self categories, self package categories do: [:c |
>>               ((c parent name = 'Squeak versions') and: [
>> +                     ((self majorMinorVersionFrom: c name)
>> +                             copyWithout: Character space) = current])
>> +                     ifTrue: [^true]].
>> -                     (self majorMinorVersionFrom: c name) = current])
>> -                             ifTrue: [^true]].
>>       ^ false
>> + !
>> -
>> - "   ^ (self categories, self package categories
>> -             detect:
>> -                     [:cat | (cat parent name = 'Squeak versions')
>> -                                     and: [(SystemVersion new version: cat name) majorMinorVersion = SystemVersion current majorMinorVersion]]
>> -             ifNone: []) notNil
>> - "!
>>
>