The Trunk: SMLoader-cmm.93.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: SMLoader-cmm.93.mcz

commits-2
Chris Muller uploaded a new version of SMLoader to project The Trunk:
http://source.squeak.org/trunk/SMLoader-cmm.93.mcz

==================== Summary ====================

Name: SMLoader-cmm.93
Author: cmm
Time: 12 November 2018, 9:32:37.990598 pm
UUID: f8100409-b6fa-45f5-ad2a-acc81a6f614a
Ancestors: SMLoader-cmm.91

- Allow releases which are not necessarily published to be selected when the UI selection was at the package level.
- Fix the problem of Release scripts seemingly not updating, due to not refreshing the local cache after uploading the script to the server.

=============== Diff against SMLoader-cmm.91 ===============

Item was changed:
  ----- Method: SMLoader>>installPackageRelease (in category 'actions') -----
  installPackageRelease
  "Install selected package or release.
  The cache is used."
  | item release |
  item := self selectedPackageOrRelease
  ifNil: [^ nil].
  item isPackageRelease
  ifTrue: [^ self installPackageRelease: item]
+ ifFalse: [release := item lastReleaseForCurrentSystemVersion.
- ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
  release
  ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?')
  ifTrue: [release := item lastPublishedRelease.
  release
  ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?')
  ifTrue: [release := item lastRelease]]]].
  release
  ifNotNil: [^ self installPackageRelease: release]]!

Item was changed:
  ----- Method: SMLoaderPlus>>installPackageRelease (in category 'actions') -----
  installPackageRelease
  "Install selected package or release.
  The cache is used."
  | item release |
  item := self selectedPackageOrRelease
  ifNil: [^ nil].
  item isPackageRelease
  ifTrue: [^ self installPackageRelease: item]
+ ifFalse: [release := item lastReleaseForCurrentSystemVersion.
- ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
  release
  ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?')
  ifTrue: [release := item lastPublishedRelease.
  release
  ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?')
  ifTrue: [release := item lastRelease]]]].
  release
  ifNotNil: [^ self installPackageRelease: release]]!

Item was changed:
  ----- Method: SMReleaseBrowser>>save (in category 'initialize-release') -----
  save
  "Save the release to SqueakMap."
  Cursor wait showWhile:
  [ self dependents do:
  [ : eachWidget | #(#username #password #note #version #content ) do:
  [ : eachName | eachWidget knownName = eachName ifTrue:
  [ eachWidget hasUnacceptedEdits ifTrue: [ eachWidget accept ] ] ] ].
  self validateCanSave.
  [ self
  writeInstallFile ;
  login.
  "Save without a downloadUrl so that SM will update its cache and we can also verify success before uploading the file."
  self savePackageRelease: nil.
  self loadScript isEmptyOrNil ifFalse:
  [ self uploadInstallFile.
  release package addRelease: release.
  "Now save with the correct downloadUrl."
  self
  savePackageRelease: self downloadUrl ;
+ deleteInstallFile ] ] ensure: [ self logout ].
+ release refreshInCache ].
- deleteInstallFile ] ] ensure: [ self logout ] ].
  self closeWindow!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: SMLoader-cmm.93.mcz

Chris Muller-3
I thought I had already moved this to trunk.  It doesn't fix the
timeouts, but I believe it fixes that maddening problem where it
appears the system doesn't save your updates because it wasn't
refreshed in the cache.

 - Chris

On Sun, Apr 21, 2019 at 7:57 PM <[hidden email]> wrote:

>
> Chris Muller uploaded a new version of SMLoader to project The Trunk:
> http://source.squeak.org/trunk/SMLoader-cmm.93.mcz
>
> ==================== Summary ====================
>
> Name: SMLoader-cmm.93
> Author: cmm
> Time: 12 November 2018, 9:32:37.990598 pm
> UUID: f8100409-b6fa-45f5-ad2a-acc81a6f614a
> Ancestors: SMLoader-cmm.91
>
> - Allow releases which are not necessarily published to be selected when the UI selection was at the package level.
> - Fix the problem of Release scripts seemingly not updating, due to not refreshing the local cache after uploading the script to the server.
>
> =============== Diff against SMLoader-cmm.91 ===============
>
> Item was changed:
>   ----- Method: SMLoader>>installPackageRelease (in category 'actions') -----
>   installPackageRelease
>         "Install selected package or release.
>         The cache is used."
>         | item release |
>         item := self selectedPackageOrRelease
>                                 ifNil: [^ nil].
>         item isPackageRelease
>                 ifTrue: [^ self installPackageRelease: item]
> +               ifFalse: [release := item lastReleaseForCurrentSystemVersion.
> -               ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
>                         release
>                                 ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?')
>                                                 ifTrue: [release := item lastPublishedRelease.
>                                                         release
>                                                                 ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?')
>                                                                                 ifTrue: [release := item lastRelease]]]].
>                         release
>                                 ifNotNil: [^ self installPackageRelease: release]]!
>
> Item was changed:
>   ----- Method: SMLoaderPlus>>installPackageRelease (in category 'actions') -----
>   installPackageRelease
>         "Install selected package or release.
>         The cache is used."
>         | item release |
>         item := self selectedPackageOrRelease
>                                 ifNil: [^ nil].
>         item isPackageRelease
>                 ifTrue: [^ self installPackageRelease: item]
> +               ifFalse: [release := item lastReleaseForCurrentSystemVersion.
> -               ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
>                         release
>                                 ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?')
>                                                 ifTrue: [release := item lastPublishedRelease.
>                                                         release
>                                                                 ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?')
>                                                                                 ifTrue: [release := item lastRelease]]]].
>                         release
>                                 ifNotNil: [^ self installPackageRelease: release]]!
>
> Item was changed:
>   ----- Method: SMReleaseBrowser>>save (in category 'initialize-release') -----
>   save
>         "Save the release to SqueakMap."
>         Cursor wait showWhile:
>                 [ self dependents do:
>                         [ : eachWidget | #(#username #password #note #version #content ) do:
>                                 [ : eachName | eachWidget knownName = eachName ifTrue:
>                                         [ eachWidget hasUnacceptedEdits ifTrue: [ eachWidget accept ] ] ] ].
>                 self validateCanSave.
>                 [ self
>                          writeInstallFile ;
>                          login.
>                 "Save without a downloadUrl so that SM will update its cache and we can also verify success before uploading the file."
>                 self savePackageRelease: nil.
>                 self loadScript isEmptyOrNil ifFalse:
>                         [ self uploadInstallFile.
>                         release package addRelease: release.
>                         "Now save with the correct downloadUrl."
>                         self
>                                  savePackageRelease: self downloadUrl ;
> +                                deleteInstallFile ] ] ensure: [ self logout ].
> +               release refreshInCache ].
> -                                deleteInstallFile ] ] ensure: [ self logout ] ].
>         self closeWindow!
>
>