The Trunk: ST80-mt.261.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: ST80-mt.261.mcz

commits-2
Marcel Taeumel uploaded a new version of ST80 to project The Trunk:
http://source.squeak.org/trunk/ST80-mt.261.mcz

==================== Summary ====================

Name: ST80-mt.261
Author: mt
Time: 11 October 2020, 1:39:28.392652 pm
UUID: f6cd6d00-8e76-6d46-86b0-aba6ab9b6db4
Ancestors: ST80-eem.260

Refactoring 'Active' variables -- Step 2 of 2. Removes all uses of Active(World|Hand|Event) by replacing those with "self current(World|Hand|Event)" or "Project current world" when required to not add/cement Morphic dependency.

See http://forum.world.st/Changeset-Eliminating-global-state-from-Morphic-td5121690.html

=============== Diff against ST80-eem.260 ===============

Item was changed:
  ----- Method: FillInTheBlank class>>request: (in category 'instance creation') -----
  request: queryString
  "Create an instance of me whose question is queryString. Invoke it
  centered at the cursor, and answer the string the user accepts. Answer
  the empty string if the user cancels."
 
  "UIManager default request: 'Your name?'"
 
  ^ self
  request: queryString
  initialAnswer: ''
+ centerAt: (self currentHand ifNil: [Sensor]) cursorPoint!
- centerAt: (ActiveHand ifNil:[Sensor]) cursorPoint!

Item was changed:
  ----- Method: FillInTheBlank class>>request:initialAnswer: (in category 'instance creation') -----
  request: queryString initialAnswer: defaultAnswer
  "Create an instance of me whose question is queryString with the given
  initial answer. Invoke it centered at the given point, and answer the
  string the user accepts. Answer the empty string if the user cancels."
 
  "UIManager default
  request: 'What is your favorite color?'
  initialAnswer: 'red, no blue. Ahhh!!'"
 
  ^ self
  request: queryString
  initialAnswer: defaultAnswer
+ centerAt: (self currentHand ifNil: [Sensor]) cursorPoint!
- centerAt: (ActiveHand ifNil:[Sensor]) cursorPoint!

Item was changed:
  ----- Method: FillInTheBlank class>>request:initialAnswer:onCancelReturn: (in category 'instance creation') -----
  request: queryString initialAnswer: defaultAnswer onCancelReturn: cancelResponse
 
  ^ self
  request: queryString
  initialAnswer: defaultAnswer
+ centerAt: (self currentHand ifNil: [Sensor]) cursorPoint
- centerAt: (ActiveHand ifNil:[Sensor]) cursorPoint
  onCancelReturn: cancelResponse!

Item was changed:
  ----- Method: ParagraphEditor>>escapeToDesktop: (in category 'nonediting/nontyping keys') -----
  escapeToDesktop: characterStream
  "Pop up a morph to field keyboard input in the context of the desktop"
 
+ Smalltalk isMorphic ifTrue: [
+ Project current world putUpWorldMenuFromEscapeKey].
- Smalltalk isMorphic ifTrue: [ActiveWorld putUpWorldMenuFromEscapeKey].
  ^ true!