Smalltalk › Squeak › Squeak - Dev

The Trunk: SUnitGUI-cmm.77.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Trunk: SUnitGUI-cmm.77.mcz

Chris Muller uploaded a new version of SUnitGUI to project The Trunk:
http://source.squeak.org/trunk/SUnitGUI-cmm.77.mcz

==================== Summary ====================

Name: SUnitGUI-cmm.77
Author: cmm
Time: 9 October 2019, 4:50:05.629938 pm
UUID: 240949db-946f-4c55-bbec-49f2b069fb2d
Ancestors: SUnitGUI-mt.76

Relieve the user from having to move or delete the unneeded progress bar when debugging individual tests from the Test Runner.

=============== Diff against SUnitGUI-mt.76 ===============

Item was changed:
----- Method: TestRunner>>basicRunSuite:do: (in category 'processing') -----
+ basicRunSuite: aTestSuite do: aBlock
- basicRunSuite: aTestSuite do: aBlock
-
self basicSetUpSuite: aTestSuite.
+ [ | prefix |
+ prefix := aTestSuite name isEmptyOrNil
+ ifTrue: [ '' ]
+ ifFalse: [ aTestSuite name , ' - ' ].
+ aTestSuite tests size = 1
+ ifTrue: [ aTestSuite tests do: aBlock ]
+ ifFalse:
+ [ aTestSuite tests
+ do: aBlock
+ displayingProgress: [ : test | prefix , test printString ]
+ every: 0 ] ] ensure: [ self basicTearDownSuite: aTestSuite ]!
- [
- | prefix |
- prefix := aTestSuite name isEmptyOrNil
- ifTrue: [ '' ]
- ifFalse: [ aTestSuite name, ' - ' ].
- aTestSuite tests
- do: aBlock
- displayingProgress: [ :test | prefix, test printString ]
- every: 0 "Update the label for all tests" ]
- ensure: [ self basicTearDownSuite: aTestSuite ].
- !

marcel.taeumel

Re: The Trunk: SUnitGUI-cmm.77.mcz

"... by adding an explicit check for "tests size = 1" which then avoids the invocation of the progress bar." It took me quite a while to figure out the diff via email because the entire formatting of that method was changed. ;-)

Thanks, that progress bar was annoying.

Best,

Marcel

Am 09.10.2019 23:50:12 schrieb [hidden email] <[hidden email]>:
Chris Muller uploaded a new version of SUnitGUI to project The Trunk:
http://source.squeak.org/trunk/SUnitGUI-cmm.77.mcz

==================== Summary ====================

Name: SUnitGUI-cmm.77
Author: cmm
Time: 9 October 2019, 4:50:05.629938 pm
UUID: 240949db-946f-4c55-bbec-49f2b069fb2d
Ancestors: SUnitGUI-mt.76

Relieve the user from having to move or delete the unneeded progress bar when debugging individual tests from the Test Runner.

=============== Diff against SUnitGUI-mt.76 ===============

Item was changed:
----- Method: TestRunner>>basicRunSuite:do: (in category 'processing') -----
+ basicRunSuite: aTestSuite do: aBlock
- basicRunSuite: aTestSuite do: aBlock
-
self basicSetUpSuite: aTestSuite.
+ [ | prefix |
+ prefix := aTestSuite name isEmptyOrNil
+ ifTrue: [ '' ]
+ ifFalse: [ aTestSuite name , ' - ' ].
+ aTestSuite tests size = 1
+ ifTrue: [ aTestSuite tests do: aBlock ]
+ ifFalse:
+ [ aTestSuite tests
+ do: aBlock
+ displayingProgress: [ : test | prefix , test printString ]
+ every: 0 ] ] ensure: [ self basicTearDownSuite: aTestSuite ]!
- [
- | prefix |
- prefix := aTestSuite name isEmptyOrNil
- ifTrue: [ '' ]
- ifFalse: [ aTestSuite name, ' - ' ].
- aTestSuite tests
- do: aBlock
- displayingProgress: [ :test | prefix, test printString ]
- every: 0 "Update the label for all tests" ]
- ensure: [ self basicTearDownSuite: aTestSuite ].
- !