Smalltalk › Squeak › Squeak - Dev

The Trunk: ShoutCore-eem.75.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

commits-2

The Trunk: ShoutCore-eem.75.mcz

Eliot Miranda uploaded a new version of ShoutCore to project The Trunk:
http://source.squeak.org/trunk/ShoutCore-eem.75.mcz

==================== Summary ====================

Name: ShoutCore-eem.75
Author: eem
Time: 7 October 2019, 12:10:14.151324 pm
UUID: c899dcab-f05f-48a5-b7e8-e1b442163e6a
Ancestors: ShoutCore-ct.74

Make sure SHParserST80's source is a string. various malfunctions can occur if it is a text.

=============== Diff against ShoutCore-ct.74 ===============

Item was changed:
----- Method: SHParserST80>>source: (in category 'accessing') -----
+ source: aStringOrText
- source: aString

+ source := aStringOrText asString!
- source := aString
- !

Levente Uzonyi

Re: The Trunk: ShoutCore-eem.75.mcz

On Mon, 7 Oct 2019, [hidden email] wrote:

> Eliot Miranda uploaded a new version of ShoutCore to project The Trunk:
> http://source.squeak.org/trunk/ShoutCore-eem.75.mcz
>
> ==================== Summary ====================
>
> Name: ShoutCore-eem.75
> Author: eem
> Time: 7 October 2019, 12:10:14.151324 pm
> UUID: c899dcab-f05f-48a5-b7e8-e1b442163e6a
> Ancestors: ShoutCore-ct.74
>
> Make sure SHParserST80's source is a string. various malfunctions can occur if it is a text.

The type information in the variable name was correct. Shout was never
intended to work with Text objects. I see where those Text objects got
into the parser, so if you don't mind, I'll revert this and fix the place
that started introducing Texts as source.

Levente

>
> =============== Diff against ShoutCore-ct.74 ===============
>
> Item was changed:
> ----- Method: SHParserST80>>source: (in category 'accessing') -----
> + source: aStringOrText
> - source: aString
>
> + source := aStringOrText asString!
> - source := aString
> - !

marcel.taeumel

Re: The Trunk: ShoutCore-eem.75.mcz

> Shout was never intended to work with Text objects.

> ... fix the place that started introducing Texts as source.

Best,

Marcel

Am 07.10.2019 23:47:40 schrieb Levente Uzonyi <[hidden email]>:
On Mon, 7 Oct 2019, [hidden email] wrote:

> Eliot Miranda uploaded a new version of ShoutCore to project The Trunk:
> http://source.squeak.org/trunk/ShoutCore-eem.75.mcz
>
> ==================== Summary ====================
>
> Name: ShoutCore-eem.75
> Author: eem
> Time: 7 October 2019, 12:10:14.151324 pm
> UUID: c899dcab-f05f-48a5-b7e8-e1b442163e6a
> Ancestors: ShoutCore-ct.74
>
> Make sure SHParserST80's source is a string. various malfunctions can occur if it is a text.

The type information in the variable name was correct. Shout was never
intended to work with Text objects. I see where those Text objects got
into the parser, so if you don't mind, I'll revert this and fix the place
that started introducing Texts as source.

Levente

>
> =============== Diff against ShoutCore-ct.74 ===============
>
> Item was changed:
> ----- Method: SHParserST80>>source: (in category 'accessing') -----
> + source: aStringOrText
> - source: aString
>
> + source := aStringOrText asString!
> - source := aString
> - !

Eliot Miranda-2

Re: The Trunk: ShoutCore-eem.75.mcz

In reply to this post by Levente Uzonyi

Hi Levente,

On Mon, Oct 7, 2019 at 2:47 PM Levente Uzonyi <[hidden email]> wrote:

On Mon, 7 Oct 2019, [hidden email] wrote:

> Eliot Miranda uploaded a new version of ShoutCore to project The Trunk:
> http://source.squeak.org/trunk/ShoutCore-eem.75.mcz
>
> ==================== Summary ====================
>
> Name: ShoutCore-eem.75
> Author: eem
> Time: 7 October 2019, 12:10:14.151324 pm
> UUID: c899dcab-f05f-48a5-b7e8-e1b442163e6a
> Ancestors: ShoutCore-ct.74
>
> Make sure SHParserST80's source is a string. various malfunctions can occur if it is a text.

The type information in the variable name was correct. Shout was never
intended to work with Text objects. I see where those Text objects got
into the parser, so if you don't mind, I'll revert this and fix the place
that started introducing Texts as source.

No problem. I didn't spot where the bug was so just hacked a fix. Apologies.

Levente

>
> =============== Diff against ShoutCore-ct.74 ===============
>
> Item was changed:
> ----- Method: SHParserST80>>source: (in category 'accessing') -----
> + source: aStringOrText
> - source: aString
>
> + source := aStringOrText asString!
> - source := aString
> - !

_,,,^..^,,,_

best, Eliot