The Trunk: ShoutCore-eem.84.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: ShoutCore-eem.84.mcz

commits-2
Eliot Miranda uploaded a new version of ShoutCore to project The Trunk:
http://source.squeak.org/trunk/ShoutCore-eem.84.mcz

==================== Summary ====================

Name: ShoutCore-eem.84
Author: eem
Time: 4 July 2020, 11:51:47.113679 am
UUID: 56a7592a-90ef-4c61-8b03-51094781d61f
Ancestors: ShoutCore-mt.83

Shout robustness.  If anything goes wron with source file access (recursive errors in the debugger, etc) then method getSource may not answer sufficient text and a bounds violation can occur in Shout.  This prevents that.

=============== Diff against ShoutCore-mt.83 ===============

Item was changed:
  ----- Method: SHParserST80>>initializeVariablesFromContext (in category 'parse support') -----
  initializeVariablesFromContext
 
+ | contextSourcePcIndex contextSource contextSourceParser |
- | contextSourcePcIndex contextSourceParser |
  contextSourcePcIndex := (context debuggerMap
  rangeForPC: (context isDead ifTrue: [context endPC] ifFalse: [context pc])
  in: context method
  contextIsActiveContext: true "... to really use the context's pc.")
  start.
+ contextSource := context method getSource.
  contextSourceParser := self class new
  classOrMetaClass: context method methodClass;
  environment: self environment;
+ source: (contextSource first: (contextSourcePcIndex min: contextSource size));
- source: (context method getSource first: contextSourcePcIndex);
  yourself.
  contextSourceParser parse.
  arguments := contextSourceParser activeArguments.
+ temporaries  := contextSourceParser activeTemporaries!
- temporaries  := contextSourceParser activeTemporaries.!