The Trunk: SqueakSSL-Tests-pre.20.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: SqueakSSL-Tests-pre.20.mcz

commits-2
Patrick Rein uploaded a new version of SqueakSSL-Tests to project The Trunk:
http://source.squeak.org/trunk/SqueakSSL-Tests-pre.20.mcz

==================== Summary ====================

Name: SqueakSSL-Tests-pre.20
Author: pre
Time: 15 August 2016, 11:22:51.609656 pm
UUID: 0d02ceb1-b791-bc49-bba6-4b3e3809a8d1
Ancestors: SqueakSSL-Tests-topa.19

Declares facebook test to require an internet connection

=============== Diff against SqueakSSL-Tests-topa.19 ===============

Item was changed:
  ----- Method: SqueakSSLTest>>testFaceBookAPI (in category 'tests') -----
  testFaceBookAPI
  "Facebook sends incomplete data during SSL handshake.
  Useful for testing an edge condition in SqueakSSL."
 
+ self ensureInternetConnectionTo: 'http://www.facebook.com'.
+
  Smalltalk at: #WebClient ifPresent:[:webClient|
  self shouldnt:[
  [webClient httpGet: 'https://graph.facebook.com/oauth/access_token']
  "Allow certificate errors on the Mac since cert validation isn't
  implemented yet."
  on: SqueakSSLCertificateError do:[:ex|
  SqueakSSL platformName = 'Mac OS'
  ifTrue:[ex resume]
  ifFalse:[ex pass]].
  ] raise: Error.
  ]..
  !


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: SqueakSSL-Tests-pre.20.mcz

Levente Uzonyi
On Mon, 15 Aug 2016, [hidden email] wrote:

> Patrick Rein uploaded a new version of SqueakSSL-Tests to project The Trunk:
> http://source.squeak.org/trunk/SqueakSSL-Tests-pre.20.mcz
>
> ==================== Summary ====================
>
> Name: SqueakSSL-Tests-pre.20
> Author: pre
> Time: 15 August 2016, 11:22:51.609656 pm
> UUID: 0d02ceb1-b791-bc49-bba6-4b3e3809a8d1
> Ancestors: SqueakSSL-Tests-topa.19
>
> Declares facebook test to require an internet connection
>
> =============== Diff against SqueakSSL-Tests-topa.19 ===============
>
> Item was changed:
>  ----- Method: SqueakSSLTest>>testFaceBookAPI (in category 'tests') -----
>  testFaceBookAPI
>   "Facebook sends incomplete data during SSL handshake.
>   Useful for testing an edge condition in SqueakSSL."
>
> + self ensureInternetConnectionTo: 'http://www.facebook.com'.

Isn't it graph.facebook.com you want to ensure access to?

> +
>   Smalltalk at: #WebClient ifPresent:[:webClient|
>   self shouldnt:[
>   [webClient httpGet: 'https://graph.facebook.com/oauth/access_token']
>   "Allow certificate errors on the Mac since cert validation isn't
>   implemented yet."
>   on: SqueakSSLCertificateError do:[:ex|
>   SqueakSSL platformName = 'Mac OS'
>   ifTrue:[ex resume]
>   ifFalse:[ex pass]].
>   ] raise: Error.
>   ]..
>  !
>
>
>