The Trunk: System-ar.371.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: System-ar.371.mcz

commits-2
Andreas Raab uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-ar.371.mcz

==================== Summary ====================

Name: System-ar.371
Author: ar
Time: 5 September 2010, 10:04:07.062 pm
UUID: 04394b54-f2ec-fc4b-9d4a-43b80ca15f94
Ancestors: System-ar.370

Fixes a nasty bug in SystemChangeNotifier which would not provide the selector in the event when reclassifying a method. This causes MC to miss dirty package notifications when one (for example) moves a method from class to an extension category.


=============== Diff against System-ar.370 ===============

Item was added:
+ ----- Method: RecategorizedEvent class>>selector:method:protocol:class:oldProtocol: (in category 'instance creation') -----
+ selector: aSelector method: aMethod protocol: prot class: aClass oldProtocol: oldName
+
+ ^(self method: aMethod protocol: prot class: aClass)
+ itemSelector: aSelector;
+ oldCategory: oldName;
+ yourself!

Item was changed:
  ----- Method: SystemChangeNotifier>>selector:recategorizedFrom:to:inClass: (in category 'system triggers') -----
  selector: selector recategorizedFrom: oldCategory to: newCategory inClass: aClass
 
  self trigger: (RecategorizedEvent
+ selector: selector
  method: (aClass compiledMethodAt: selector ifAbsent: [nil])
  protocol: newCategory
  class: aClass
  oldProtocol: oldCategory)!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-ar.371.mcz

Chris Muller-3
I don't know how you found it, but way to go Andreas!  This was an
insidious bug since "not seeing something" made it transparent, and
yet it could sting good by causing loss of work..


On Mon, Sep 6, 2010 at 12:04 AM,  <[hidden email]> wrote:

> Andreas Raab uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-ar.371.mcz
>
> ==================== Summary ====================
>
> Name: System-ar.371
> Author: ar
> Time: 5 September 2010, 10:04:07.062 pm
> UUID: 04394b54-f2ec-fc4b-9d4a-43b80ca15f94
> Ancestors: System-ar.370
>
> Fixes a nasty bug in SystemChangeNotifier which would not provide the selector in the event when reclassifying a method. This causes MC to miss dirty package notifications when one (for example) moves a method from class to an extension category.
>
>
> =============== Diff against System-ar.370 ===============
>
> Item was added:
> + ----- Method: RecategorizedEvent class>>selector:method:protocol:class:oldProtocol: (in category 'instance creation') -----
> + selector: aSelector method: aMethod protocol: prot class: aClass oldProtocol: oldName
> +
> +       ^(self method: aMethod protocol: prot class: aClass)
> +               itemSelector: aSelector;
> +               oldCategory: oldName;
> +               yourself!
>
> Item was changed:
>  ----- Method: SystemChangeNotifier>>selector:recategorizedFrom:to:inClass: (in category 'system triggers') -----
>  selector: selector recategorizedFrom: oldCategory to: newCategory inClass: aClass
>
>        self trigger: (RecategorizedEvent
> +                               selector: selector
>                                method: (aClass compiledMethodAt: selector ifAbsent: [nil])
>                                protocol: newCategory
>                                class: aClass
>                                oldProtocol: oldCategory)!
>
>
>