Chris Muller uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-cmm.275.mcz ==================== Summary ==================== Name: System-cmm.275 Author: cmm Time: 2 March 2010, 9:48:35.173 pm UUID: 2f46dbd4-b790-41cc-b8c4-76d1b7eb1b15 Ancestors: System-cmm.274 Added #traceMessages preference. =============== Diff against System-cmm.274 =============== Item was added: + ----- Method: Preferences class>>traceMessages (in category 'standard queries') ----- + traceMessages + ^ self + valueOfFlag: #traceMessages + ifAbsent: [ false ]! |
Hi Chris
Did you notice new pattern for creating preferences ? We prefer a method annotation (pragme) because it will prevent Preferences to be bloated. like TextDiffBuilder>>ignoreLineEndings "Answer a boolean telling if line endings differences should be ignored or emphasized" <preference: 'ignoreLineEndings' category: 'TextDiff' description: 'When enabled, source code differences in line endings will be ignored.' type: #Boolean> ^IgnoreLineEndings ifNil: [ false ] Cheers Nicolas 2010/3/3 <[hidden email]>: > Chris Muller uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-cmm.275.mcz > > ==================== Summary ==================== > > Name: System-cmm.275 > Author: cmm > Time: 2 March 2010, 9:48:35.173 pm > UUID: 2f46dbd4-b790-41cc-b8c4-76d1b7eb1b15 > Ancestors: System-cmm.274 > > Added #traceMessages preference. > > =============== Diff against System-cmm.274 =============== > > Item was added: > + ----- Method: Preferences class>>traceMessages (in category 'standard queries') ----- > + traceMessages > + ^ self > + valueOfFlag: #traceMessages > + ifAbsent: [ false ]! > > > |
Hi, yes, I did! And, in fact, I have already used the new preference
Pragma's in restoring the Auto Indent preference. Now, the rationale I had heard from Andreas was that *localized* preferences, such as Auto Indent or things related to TextEditor, or such as the one example you mentioned (TextDiffBuilder>>ignoreLineEndings), could be made as Class-vars there. But, in this case, the #traceMessages is a truly global setting. I would be happy to make it a pragma, but I just didn't see a good candidate class for this global preference other than "Preferences" class itself which, you as you said, we are trying to avoid bloat. I guess the bloating of Preferences class is independent of whether we use a Pragma or not. If you have suggestions for both issues, I'd be happy to follow them.. Thanks, Chris On Wed, Mar 3, 2010 at 3:38 PM, Nicolas Cellier <[hidden email]> wrote: > Hi Chris > > Did you notice new pattern for creating preferences ? > We prefer a method annotation (pragme) because it will prevent > Preferences to be bloated. > > like TextDiffBuilder>>ignoreLineEndings > "Answer a boolean telling if line endings differences should be > ignored or emphasized" > > <preference: 'ignoreLineEndings' > category: 'TextDiff' > description: 'When enabled, source code differences in line endings > will be ignored.' > type: #Boolean> > ^IgnoreLineEndings ifNil: [ false ] > > Cheers > > Nicolas > > 2010/3/3 <[hidden email]>: >> Chris Muller uploaded a new version of System to project The Trunk: >> http://source.squeak.org/trunk/System-cmm.275.mcz >> >> ==================== Summary ==================== >> >> Name: System-cmm.275 >> Author: cmm >> Time: 2 March 2010, 9:48:35.173 pm >> UUID: 2f46dbd4-b790-41cc-b8c4-76d1b7eb1b15 >> Ancestors: System-cmm.274 >> >> Added #traceMessages preference. >> >> =============== Diff against System-cmm.274 =============== >> >> Item was added: >> + ----- Method: Preferences class>>traceMessages (in category 'standard queries') ----- >> + traceMessages >> + ^ self >> + valueOfFlag: #traceMessages >> + ifAbsent: [ false ]! >> >> >> > > |
2010/3/3 Chris Muller <[hidden email]>:
> Hi, yes, I did! And, in fact, I have already used the new preference > Pragma's in restoring the Auto Indent preference. > > Now, the rationale I had heard from Andreas was that *localized* > preferences, such as Auto Indent or things related to TextEditor, or > such as the one example you mentioned > (TextDiffBuilder>>ignoreLineEndings), could be made as Class-vars > there. > > But, in this case, the #traceMessages is a truly global setting. I > would be happy to make it a pragma, but I just didn't see a good > candidate class for this global preference other than "Preferences" > class itself which, you as you said, we are trying to avoid bloat. > > I guess the bloating of Preferences class is independent of whether we > use a Pragma or not. If you have suggestions for both issues, I'd be > happy to follow them.. > > Thanks, > Chris > Ah yes I see... SystemNavigation ? Nicolas > > On Wed, Mar 3, 2010 at 3:38 PM, Nicolas Cellier > <[hidden email]> wrote: >> Hi Chris >> >> Did you notice new pattern for creating preferences ? >> We prefer a method annotation (pragme) because it will prevent >> Preferences to be bloated. >> >> like TextDiffBuilder>>ignoreLineEndings >> "Answer a boolean telling if line endings differences should be >> ignored or emphasized" >> >> <preference: 'ignoreLineEndings' >> category: 'TextDiff' >> description: 'When enabled, source code differences in line endings >> will be ignored.' >> type: #Boolean> >> ^IgnoreLineEndings ifNil: [ false ] >> >> Cheers >> >> Nicolas >> >> 2010/3/3 <[hidden email]>: >>> Chris Muller uploaded a new version of System to project The Trunk: >>> http://source.squeak.org/trunk/System-cmm.275.mcz >>> >>> ==================== Summary ==================== >>> >>> Name: System-cmm.275 >>> Author: cmm >>> Time: 2 March 2010, 9:48:35.173 pm >>> UUID: 2f46dbd4-b790-41cc-b8c4-76d1b7eb1b15 >>> Ancestors: System-cmm.274 >>> >>> Added #traceMessages preference. >>> >>> =============== Diff against System-cmm.274 =============== >>> >>> Item was added: >>> + ----- Method: Preferences class>>traceMessages (in category 'standard queries') ----- >>> + traceMessages >>> + ^ self >>> + valueOfFlag: #traceMessages >>> + ifAbsent: [ false ]! >>> >>> >>> >> >> > > |
Yeah, I agree SystemNavigation would seem to be the most appropriate
place. I'll do that. - Chris On Wed, Mar 3, 2010 at 3:58 PM, Nicolas Cellier <[hidden email]> wrote: > 2010/3/3 Chris Muller <[hidden email]>: >> Hi, yes, I did! And, in fact, I have already used the new preference >> Pragma's in restoring the Auto Indent preference. >> >> Now, the rationale I had heard from Andreas was that *localized* >> preferences, such as Auto Indent or things related to TextEditor, or >> such as the one example you mentioned >> (TextDiffBuilder>>ignoreLineEndings), could be made as Class-vars >> there. >> >> But, in this case, the #traceMessages is a truly global setting. I >> would be happy to make it a pragma, but I just didn't see a good >> candidate class for this global preference other than "Preferences" >> class itself which, you as you said, we are trying to avoid bloat. >> >> I guess the bloating of Preferences class is independent of whether we >> use a Pragma or not. If you have suggestions for both issues, I'd be >> happy to follow them.. >> >> Thanks, >> Chris >> > > Ah yes I see... > SystemNavigation ? > > Nicolas > >> >> On Wed, Mar 3, 2010 at 3:38 PM, Nicolas Cellier >> <[hidden email]> wrote: >>> Hi Chris >>> >>> Did you notice new pattern for creating preferences ? >>> We prefer a method annotation (pragme) because it will prevent >>> Preferences to be bloated. >>> >>> like TextDiffBuilder>>ignoreLineEndings >>> "Answer a boolean telling if line endings differences should be >>> ignored or emphasized" >>> >>> <preference: 'ignoreLineEndings' >>> category: 'TextDiff' >>> description: 'When enabled, source code differences in line endings >>> will be ignored.' >>> type: #Boolean> >>> ^IgnoreLineEndings ifNil: [ false ] >>> >>> Cheers >>> >>> Nicolas >>> >>> 2010/3/3 <[hidden email]>: >>>> Chris Muller uploaded a new version of System to project The Trunk: >>>> http://source.squeak.org/trunk/System-cmm.275.mcz >>>> >>>> ==================== Summary ==================== >>>> >>>> Name: System-cmm.275 >>>> Author: cmm >>>> Time: 2 March 2010, 9:48:35.173 pm >>>> UUID: 2f46dbd4-b790-41cc-b8c4-76d1b7eb1b15 >>>> Ancestors: System-cmm.274 >>>> >>>> Added #traceMessages preference. >>>> >>>> =============== Diff against System-cmm.274 =============== >>>> >>>> Item was added: >>>> + ----- Method: Preferences class>>traceMessages (in category 'standard queries') ----- >>>> + traceMessages >>>> + ^ self >>>> + valueOfFlag: #traceMessages >>>> + ifAbsent: [ false ]! >>>> >>>> >>>> >>> >>> >> >> > > |
Free forum by Nabble | Edit this page |